How to contribute to the linux kernel

How to contribute to the linux kernel

[Qianqiang Liu]

[-- Attachment #1.1: Type: text/plain, Size: 1533 bytes --]


Hi all,

I am an embedded software engineer. I use Linux every day, and I appreciate its neatness and simplicity.

One day, I watched a video from Greg: https://youtu.be/LLBrBBImJt4, and I started wondering if maybe I could contribute to the Linux kernel. So, I sent a very simple (and maybe stupid) patch to the community:

> On Fri, Aug 30, 2024 at 04:54:38PM +0800, Qianqiang Liu wrote:
> There is no need to add parentheses around 'devcode != 0x0000' and
> 'devcode != 0x9320'
> 
> Signed-off-by: Qianqiang Liu <qianqiang.liu@163.com>
> ---
> drivers/staging/fbtft/fb_ili9320.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fb_ili9320.c b/drivers/staging/fbtft/fb_ili9320.c
> index 0be7c2d51548..409b54cc562e 100644
> --- a/drivers/staging/fbtft/fb_ili9320.c
> +++ b/drivers/staging/fbtft/fb_ili9320.c
> @@ -37,7 +37,7 @@ static int init_display(struct fbtft_par *par)
>    devcode = read_devicecode(par);
>    fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "Device code: 0x%04X\n",
>              devcode);
> -    if ((devcode != 0x0000) && (devcode != 0x9320))
> +    if (devcode != 0x0000 && devcode != 0x9320)
>        dev_warn(par->info->device,
>             "Unrecognized Device code: 0x%04X (expected 0x9320)\n",
>            devcode);
> -- 
> 2.39.2


It turns out that the patch was rejected.

So, my question is: how can I start contributing to the Linux kernel? Maybe I could start by fixing some small bugs?

Thanks,
Qianqiang Liu

[-- Attachment #1.2: Type: text/html, Size: 4727 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: How to contribute to the linux kernel

[Greg KH]

On Sat, Aug 31, 2024 at 04:17:35PM +0800, Qianqiang Liu wrote:
> 
> Hi all,
> 
> I am an embedded software engineer. I use Linux every day, and I appreciate its neatness and simplicity.
> 
> One day, I watched a video from Greg: https://youtu.be/LLBrBBImJt4, and I started wondering if maybe I could contribute to the Linux kernel. So, I sent a very simple (and maybe stupid) patch to the community:
> 
> > On Fri, Aug 30, 2024 at 04:54:38PM +0800, Qianqiang Liu wrote:
> > There is no need to add parentheses around 'devcode != 0x0000' and
> > 'devcode != 0x9320'
> > 
> > Signed-off-by: Qianqiang Liu <qianqiang.liu@163.com>
> > ---
> > drivers/staging/fbtft/fb_ili9320.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/fbtft/fb_ili9320.c b/drivers/staging/fbtft/fb_ili9320.c
> > index 0be7c2d51548..409b54cc562e 100644
> > --- a/drivers/staging/fbtft/fb_ili9320.c
> > +++ b/drivers/staging/fbtft/fb_ili9320.c
> > @@ -37,7 +37,7 @@ static int init_display(struct fbtft_par *par)
> >    devcode = read_devicecode(par);
> >    fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "Device code: 0x%04X\n",
> >              devcode);
> > -    if ((devcode != 0x0000) && (devcode != 0x9320))
> > +    if (devcode != 0x0000 && devcode != 0x9320)
> >        dev_warn(par->info->device,
> >             "Unrecognized Device code: 0x%04X (expected 0x9320)\n",
> >            devcode);
> > -- 
> > 2.39.2
> 
> 
> It turns out that the patch was rejected.

That's just because it's something that I don't think should be changed,
not because it was "stupid" or anything like that.  It's been discussed
many times in the past, not a big deal.

> So, my question is: how can I start contributing to the Linux kernel?
> Maybe I could start by fixing some small bugs?

Sure, try reading this:
	https://lists.kernelnewbies.org/pipermail/kernelnewbies/2017-April/017765.html

Good luck!

greg k-h

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: How to contribute to the linux kernel

[Qianqiang Liu]

Hi Greg,

Thanks a lot.

Best,
Qianqiang Liu

On Sat, Aug 31, 2024 at 07:32:04PM +0200, Greg KH wrote:
> On Sat, Aug 31, 2024 at 04:17:35PM +0800, Qianqiang Liu wrote:
> > 
> > Hi all,
> > 
> > I am an embedded software engineer. I use Linux every day, and I appreciate its neatness and simplicity.
> > 
> > One day, I watched a video from Greg: https://youtu.be/LLBrBBImJt4, and I started wondering if maybe I could contribute to the Linux kernel. So, I sent a very simple (and maybe stupid) patch to the community:
> > 
> > > On Fri, Aug 30, 2024 at 04:54:38PM +0800, Qianqiang Liu wrote:
> > > There is no need to add parentheses around 'devcode != 0x0000' and
> > > 'devcode != 0x9320'
> > > 
> > > Signed-off-by: Qianqiang Liu <qianqiang.liu@163.com>
> > > ---
> > > drivers/staging/fbtft/fb_ili9320.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/staging/fbtft/fb_ili9320.c b/drivers/staging/fbtft/fb_ili9320.c
> > > index 0be7c2d51548..409b54cc562e 100644
> > > --- a/drivers/staging/fbtft/fb_ili9320.c
> > > +++ b/drivers/staging/fbtft/fb_ili9320.c
> > > @@ -37,7 +37,7 @@ static int init_display(struct fbtft_par *par)
> > >    devcode = read_devicecode(par);
> > >    fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "Device code: 0x%04X\n",
> > >              devcode);
> > > -    if ((devcode != 0x0000) && (devcode != 0x9320))
> > > +    if (devcode != 0x0000 && devcode != 0x9320)
> > >        dev_warn(par->info->device,
> > >             "Unrecognized Device code: 0x%04X (expected 0x9320)\n",
> > >            devcode);
> > > -- 
> > > 2.39.2
> > 
> > 
> > It turns out that the patch was rejected.
> 
> That's just because it's something that I don't think should be changed,
> not because it was "stupid" or anything like that.  It's been discussed
> many times in the past, not a big deal.
> 
> > So, my question is: how can I start contributing to the Linux kernel?
> > Maybe I could start by fixing some small bugs?
> 
> Sure, try reading this:
> 	https://lists.kernelnewbies.org/pipermail/kernelnewbies/2017-April/017765.html
> 
> Good luck!
> 
> greg k-h
> 
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: How to contribute to the linux kernel

[Philipp Hortmann]

On 8/31/24 10:17, Qianqiang Liu wrote:
> 
> Hi all,
> 
> I am an embedded software engineer. I use Linux every day, and I 
> appreciate its neatness and simplicity.

Hi Qiangiang,

it seems that the driver rtl7823bs has the following

enum p2p_wpsinfo
struct	getcountjudge_rsp

that is not used.

It makes sense to remove it.

Thanks for your support.

Bye Philipp

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: How to contribute to the linux kernel

[Qianqiang Liu]

Hi Philipp,

Thanks, I will prepare a patch for it.

Best,
Qianqiang Liu

On Mon, Sep 02, 2024 at 07:49:25PM +0200, Philipp Hortmann wrote:
> On 8/31/24 10:17, Qianqiang Liu wrote:
> > 
> > Hi all,
> > 
> > I am an embedded software engineer. I use Linux every day, and I
> > appreciate its neatness and simplicity.
> 
> Hi Qiangiang,
> 
> it seems that the driver rtl7823bs has the following
> 
> enum p2p_wpsinfo
> struct	getcountjudge_rsp
> 
> that is not used.
> 
> It makes sense to remove it.
> 
> Thanks for your support.
> 
> Bye Philipp
> 
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: How to contribute to the linux kernel

[Gustavo A. R. Silva]

Hi!

> One day, I watched a video from Greg: https://youtu.be/LLBrBBImJt4, and I started wondering if maybe I could contribute to the Linux kernel. 


If you are interested in security, fixing Coverity issues is a great way to
contribute to the kernel. Here are some presentations that you might find
useful:

https://embeddedor.com/slides/2017/kr/kr2017.pdf
https://embeddedor.com/slides/2018/kr/kr2018.pdf
https://embeddedor.com/slides/2019/kr/kr2019.pdf

You can also watch these presentations on YouTube for additional context.

You can sign up here for linux-next scans:
https://scan.coverity.com/projects/linux-next-weekly-scan

and here for -rc scans:
https://scan.coverity.com/projects/linux

I hope this helps.
--
Gustavo

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: How to contribute to the linux kernel

[Qianqiang Liu]

Hi Gustavo,

Thanks! I will take a look at it.

On Mon, Sep 02, 2024 at 08:11:57PM -0600, Gustavo A. R. Silva wrote:
> Hi!
> 
> > One day, I watched a video from Greg: https://youtu.be/LLBrBBImJt4, and
> > I started wondering if maybe I could contribute to the Linux kernel.
> 
> 
> If you are interested in security, fixing Coverity issues is a great way to
> contribute to the kernel. Here are some presentations that you might find
> useful:
> 
> https://embeddedor.com/slides/2017/kr/kr2017.pdf
> https://embeddedor.com/slides/2018/kr/kr2018.pdf
> https://embeddedor.com/slides/2019/kr/kr2019.pdf
> 
> You can also watch these presentations on YouTube for additional context.
> 
> You can sign up here for linux-next scans:
> https://scan.coverity.com/projects/linux-next-weekly-scan
> 
> and here for -rc scans:
> https://scan.coverity.com/projects/linux
> 
> I hope this helps.
> --
> Gustavo
> 
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

-- 
Best,
Qianqiang Liu


_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: How to contribute to the linux kernel

[Qianqiang Liu]

Hi,

Thank you all for the good advice.
I have now successfully submitted some small changes to the kernel:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9b4af913465cc5f903227237d833b4911430fd97
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=590efcd3c75f0e1f7208cf1c8dff5452818b70f2
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7fd551a87ba427fee2df8af4d83f4b7c220cc9dd
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=93497752dfed196b41d2804503e80b9a04318adb

Contributing to the Linux kernel is not that hard, all we need is
patience and persistence.

I definitely will do more work on the Linux kernel!

-- 
Best,
Qianqiang Liu


_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: How to contribute to the linux kernel

[Malatesh]

[-- Attachment #1.1: Type: text/plain, Size: 1298 bytes --]

Hi Qianqiang,


Nice to see your commits, Great.

I have tried many times but could not do any contribution till now.


Can you help me to contribute, what I needs to do ?


Regards,

Malatesh

On Tue, 24 Sept, 2024, 7:44 am Qianqiang Liu, <qianqiang.liu@163.com> wrote:

> Hi,
>
> Thank you all for the good advice.
> I have now successfully submitted some small changes to the kernel:
>
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9b4af913465cc5f903227237d833b4911430fd97
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=590efcd3c75f0e1f7208cf1c8dff5452818b70f2
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7fd551a87ba427fee2df8af4d83f4b7c220cc9dd
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=93497752dfed196b41d2804503e80b9a04318adb
>
> Contributing to the Linux kernel is not that hard, all we need is
> patience and persistence.
>
> I definitely will do more work on the Linux kernel!
>
> --
> Best,
> Qianqiang Liu
>
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>

[-- Attachment #1.2: Type: text/html, Size: 2654 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: How to contribute to the linux kernel

[Qianqiang Liu]

Hi Malatesh,

> Can you help me to contribute, what I needs to do ?

You can refer to this mail thread. The advice from Gustavo is pretty
useful.

Also, there is a document for submitting your first kernel patch:
https://kernelnewbies.org/FirstKernelPatch

-- 
Best,
Qianqiang Liu


_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: How to contribute to the linux kernel

[Gustavo A. R. Silva]

On 24/09/24 04:14, Qianqiang Liu wrote:
> Hi,
> 
> Thank you all for the good advice.
> I have now successfully submitted some small changes to the kernel:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9b4af913465cc5f903227237d833b4911430fd97
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=590efcd3c75f0e1f7208cf1c8dff5452818b70f2
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7fd551a87ba427fee2df8af4d83f4b7c220cc9dd
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=93497752dfed196b41d2804503e80b9a04318adb
> 

This is really great to see! Congrats.

> Contributing to the Linux kernel is not that hard, all we need is
> patience and persistence.
> 
> I definitely will do more work on the Linux kernel!
Yes, please. Keep learning and keep sending patches. :)

--
Gustavo

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies