From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ye Zhang <ye.zhang@rock-chips.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, heiko@sntech.de,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
mika.westerberg@linux.intel.com, tao.huang@rock-chips.com,
finley.xiao@rock-chips.com, tim.chen@rock-chips.com,
elaine.zhang@rock-chips.com
Subject: Re: [PATCH v3 00/12] gpio: rockchip: Update the GPIO driver
Date: Tue, 3 Sep 2024 19:00:43 +0300 [thread overview]
Message-ID: <Ztcyq2lb1YS43ncV@smile.fi.intel.com> (raw)
In-Reply-To: <20240903073649.237362-1-ye.zhang@rock-chips.com>
On Tue, Sep 03, 2024 at 03:36:37PM +0800, Ye Zhang wrote:
> GPIO driver support acpi and new version, set input direction in
> irq_request_resources, fix division error and debounce config error.
Looking at patch 7 it seems the new feature has been barely tested.
First of all, I recommend to split out the real fixes for now and send them
separately while working on the rest. Second, perform better bisectability
(both compile and run time) and overall test coverage in different scenarios.
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ye Zhang <ye.zhang@rock-chips.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, heiko@sntech.de,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
mika.westerberg@linux.intel.com, tao.huang@rock-chips.com,
finley.xiao@rock-chips.com, tim.chen@rock-chips.com,
elaine.zhang@rock-chips.com
Subject: Re: [PATCH v3 00/12] gpio: rockchip: Update the GPIO driver
Date: Tue, 3 Sep 2024 19:00:43 +0300 [thread overview]
Message-ID: <Ztcyq2lb1YS43ncV@smile.fi.intel.com> (raw)
In-Reply-To: <20240903073649.237362-1-ye.zhang@rock-chips.com>
On Tue, Sep 03, 2024 at 03:36:37PM +0800, Ye Zhang wrote:
> GPIO driver support acpi and new version, set input direction in
> irq_request_resources, fix division error and debounce config error.
Looking at patch 7 it seems the new feature has been barely tested.
First of all, I recommend to split out the real fixes for now and send them
separately while working on the rest. Second, perform better bisectability
(both compile and run time) and overall test coverage in different scenarios.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-09-03 16:00 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 7:36 [PATCH v3 00/12] gpio: rockchip: Update the GPIO driver Ye Zhang
2024-09-03 7:36 ` Ye Zhang
2024-09-03 7:36 ` [PATCH v3 01/12] gpio: rockchip: avoid division by zero Ye Zhang
2024-09-03 7:36 ` Ye Zhang
2024-09-03 15:53 ` Andy Shevchenko
2024-09-03 15:53 ` Andy Shevchenko
2024-09-03 7:36 ` [PATCH v3 02/12] gpio: rockchip: release reference to device node Ye Zhang
2024-09-03 7:36 ` Ye Zhang
2024-09-03 7:36 ` [PATCH v3 03/12] gpio: rockchip: resolve overflow issues Ye Zhang
2024-09-03 7:36 ` Ye Zhang
2024-09-03 7:36 ` [PATCH v3 04/12] gpio: rockchip: resolve underflow issue Ye Zhang
2024-09-03 7:36 ` Ye Zhang
2024-09-03 15:55 ` Andy Shevchenko
2024-09-03 15:55 ` Andy Shevchenko
2024-09-03 7:36 ` [PATCH v3 05/12] gpio: rockchip: fix debounce calculate Ye Zhang
2024-09-03 7:36 ` Ye Zhang
2024-09-03 7:36 ` [PATCH v3 06/12] gpio: rockchip: Update debounce config function Ye Zhang
2024-09-03 7:36 ` Ye Zhang
2024-09-03 7:36 ` [PATCH v3 07/12] gpio: rockchip: support 'clock-names' from dt nodes Ye Zhang
2024-09-03 7:36 ` Ye Zhang
2024-09-03 15:59 ` Andy Shevchenko
2024-09-03 15:59 ` Andy Shevchenko
2024-09-03 7:36 ` [PATCH v3 08/12] gpio: rockchip: explan the format of the GPIO version ID Ye Zhang
2024-09-03 7:36 ` Ye Zhang
2024-09-03 16:03 ` Andy Shevchenko
2024-09-03 16:03 ` Andy Shevchenko
2024-09-03 7:36 ` [PATCH v3 09/12] gpio: rockchip: change the GPIO version judgment logic Ye Zhang
2024-09-03 7:36 ` Ye Zhang
2024-09-03 16:05 ` Andy Shevchenko
2024-09-03 16:05 ` Andy Shevchenko
2024-09-03 7:36 ` [PATCH v3 10/12] gpio: rockchip: support new version gpio Ye Zhang
2024-09-03 7:36 ` Ye Zhang
2024-09-03 16:07 ` Andy Shevchenko
2024-09-03 16:07 ` Andy Shevchenko
2024-09-03 7:36 ` [PATCH v3 11/12] gpio: rockchip: Set input direction when request irq Ye Zhang
2024-09-03 7:36 ` Ye Zhang
2024-09-03 16:08 ` Andy Shevchenko
2024-09-03 16:08 ` Andy Shevchenko
2024-09-03 7:36 ` [PATCH v3 12/12] gpio: rockchip: replace mutex_lock() with guard() Ye Zhang
2024-09-03 7:36 ` Ye Zhang
2024-09-03 16:10 ` Andy Shevchenko
2024-09-03 16:10 ` Andy Shevchenko
2024-09-03 16:52 ` Christophe JAILLET
2024-09-03 16:52 ` Christophe JAILLET
2024-09-03 16:52 ` Christophe JAILLET
2024-09-03 16:00 ` Andy Shevchenko [this message]
2024-09-03 16:00 ` [PATCH v3 00/12] gpio: rockchip: Update the GPIO driver Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ztcyq2lb1YS43ncV@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=elaine.zhang@rock-chips.com \
--cc=finley.xiao@rock-chips.com \
--cc=heiko@sntech.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mika.westerberg@linux.intel.com \
--cc=tao.huang@rock-chips.com \
--cc=tim.chen@rock-chips.com \
--cc=ye.zhang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.