All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cristian Marussi <cristian.marussi@arm.com>
To: Sibi Sankar <quic_sibis@quicinc.com>
Cc: sudeep.holla@arm.com, cristian.marussi@arm.com,
	linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, johan@kernel.org,
	konradybcio@kernel.org
Subject: Re: [PATCH V2 2/2] firmware: arm_scmi: Skip adding bad duplicates
Date: Wed, 4 Sep 2024 16:30:24 +0100	[thread overview]
Message-ID: <Zth9EMydkwvJ30T0@pluto> (raw)
In-Reply-To: <Zth7DZmkpOieSZEr@pluto>

On Wed, Sep 04, 2024 at 04:21:49PM +0100, Cristian Marussi wrote:
> On Wed, Sep 04, 2024 at 08:43:24AM +0530, Sibi Sankar wrote:
> > Ensure that the bad duplicates reported by the platform firmware doesn't
> > get added to the opp-tables.
> > 
> 
> Hi Sibi,
> 
> so if the idea is to make the code more robust when FW sends BAD
> duplicates, you necessarily need to properly drop opps in opp_count too.
> 
> One other option would be to just loop with xa_for_each BUT opp_count is
> used in a number of places...so first of all let's try drop count properly.
> 
> Can you try this patch down below, instead of your patch.
> If it solves, I will send a patch (after testing it a bit more :D)

Hold on... I sent you a diff that does not apply probably on your tree due
to some uncomitted local work of mine...my bad...let me resend.

Thanks,
Cristian

  reply	other threads:[~2024-09-04 15:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-04  3:13 [PATCH V2 0/2] firmware: arm_scmi: Misc Fixes Sibi Sankar
2024-09-04  3:13 ` [PATCH V2 1/2] firmware: arm_scmi: Ensure that the message-id supports fastchannel Sibi Sankar
2024-09-04  7:00   ` Johan Hovold
2024-09-04 11:29     ` Konrad Dybcio
2024-09-04 12:38       ` Sudeep Holla
2024-09-04 14:20         ` Cristian Marussi
2024-09-05 12:54           ` Konrad Dybcio
2024-10-07  6:46             ` Sibi Sankar
2024-09-04  3:13 ` [PATCH V2 2/2] firmware: arm_scmi: Skip adding bad duplicates Sibi Sankar
2024-09-04  7:09   ` Johan Hovold
2024-09-04  8:05     ` Johan Hovold
2024-09-04 13:56   ` Konrad Dybcio
2024-09-04 14:00     ` Konrad Dybcio
2024-09-04 15:21   ` Cristian Marussi
2024-09-04 15:30     ` Cristian Marussi [this message]
2024-09-04 15:46       ` Cristian Marussi
2024-09-05 12:43         ` Cristian Marussi
2024-10-07  7:00       ` Sibi Sankar
2024-10-09 14:20         ` Cristian Marussi
2024-09-04 16:12   ` Sudeep Holla
2024-09-04 16:20     ` Cristian Marussi
2024-10-07  6:51       ` Sibi Sankar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zth9EMydkwvJ30T0@pluto \
    --to=cristian.marussi@arm.com \
    --cc=arm-scmi@vger.kernel.org \
    --cc=johan@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_sibis@quicinc.com \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.