* [Buildroot] [PATCH 1/2] package/perl-file-slurp: add host package
@ 2024-09-05 9:48 Guillaume GC. Chaye
2024-09-05 9:48 ` [Buildroot] [PATCH 2/2] package/systemd: add efi support option Guillaume GC. Chaye
2024-09-05 12:18 ` [Buildroot] [PATCH 1/2] package/perl-file-slurp: add host package Yann E. MORIN
0 siblings, 2 replies; 6+ messages in thread
From: Guillaume GC. Chaye @ 2024-09-05 9:48 UTC (permalink / raw)
To: buildroot
Cc: Christopher McCrory, Sen Hastings, Norbert Lange,
Guillaume GC. Chaye, Yann E . MORIN
Some project like efitools requires host version of this package to build properly.
Signed-off-by: Guillaume GC. Chaye <guillaume.chaye@zeetim.com>
---
package/perl-file-slurp/perl-file-slurp.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/perl-file-slurp/perl-file-slurp.mk b/package/perl-file-slurp/perl-file-slurp.mk
index 0d4ab94034..7cada58070 100644
--- a/package/perl-file-slurp/perl-file-slurp.mk
+++ b/package/perl-file-slurp/perl-file-slurp.mk
@@ -12,3 +12,4 @@ PERL_FILE_SLURP_LICENSE_FILES = README.md
PERL_FILE_SLURP_DISTNAME = File-Slurp
$(eval $(perl-package))
+$(eval $(host-perl-package))
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] package/systemd: add efi support option
2024-09-05 9:48 [Buildroot] [PATCH 1/2] package/perl-file-slurp: add host package Guillaume GC. Chaye
@ 2024-09-05 9:48 ` Guillaume GC. Chaye
2024-09-05 12:04 ` Yann E. MORIN
2024-09-05 12:18 ` [Buildroot] [PATCH 1/2] package/perl-file-slurp: add host package Yann E. MORIN
1 sibling, 1 reply; 6+ messages in thread
From: Guillaume GC. Chaye @ 2024-09-05 9:48 UTC (permalink / raw)
To: buildroot
Cc: Christopher McCrory, Sen Hastings, Norbert Lange,
Guillaume GC. Chaye, Yann E . MORIN
We need to compile systemd with -Defi=true flag to mount automatically efivarfs in /sys/firmware/efi/efivars
Signed-off-by: Guillaume GC. Chaye <guillaume.chaye@zeetim.com>
---
package/systemd/Config.in | 3 +++
package/systemd/systemd.mk | 7 ++++++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/package/systemd/Config.in b/package/systemd/Config.in
index 345f08590e..d1ca6e7f85 100644
--- a/package/systemd/Config.in
+++ b/package/systemd/Config.in
@@ -161,6 +161,9 @@ config BR2_PACKAGE_SYSTEMD_BOOT_EFI_ARCH
default "x64" if BR2_x86_64
depends on BR2_PACKAGE_SYSTEMD_BOOT
+config BR2_PACKAGE_SYSTEMD_EFI
+ bool "enable EFI support"
+
config BR2_PACKAGE_SYSTEMD_JOURNAL_REMOTE
bool "enable journal remote tools"
select BR2_PACKAGE_LIBCURL
diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
index 5dca8681bc..7b3eabbd0d 100644
--- a/package/systemd/systemd.mk
+++ b/package/systemd/systemd.mk
@@ -660,7 +660,12 @@ define SYSTEMD_INSTALL_BOOT_FILES
endef
else
-SYSTEMD_CONF_OPTS += -Defi=false -Dbootloader=disabled
+SYSTEMD_CONF_OPTS += -Dbootloader=disabled
+ifeq ($(BR2_PACKAGE_SYSTEMD_EFI),y)
+SYSTEMD_CONF_OPTS += -Defi=true
+else
+SYSTEMD_CONF_OPTS += -Defi=false
+endif
endif # BR2_PACKAGE_SYSTEMD_BOOT == y
SYSTEMD_FALLBACK_HOSTNAME = $(call qstrip,$(BR2_TARGET_GENERIC_HOSTNAME))
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 2/2] package/systemd: add efi support option
2024-09-05 9:48 ` [Buildroot] [PATCH 2/2] package/systemd: add efi support option Guillaume GC. Chaye
@ 2024-09-05 12:04 ` Yann E. MORIN
0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2024-09-05 12:04 UTC (permalink / raw)
To: Guillaume GC. Chaye
Cc: Christopher McCrory, Norbert Lange, Sen Hastings, buildroot
Guillsume, All,
On 2024-09-05 11:48 +0200, Guillaume GC. Chaye spake thusly:
> We need to compile systemd with -Defi=true flag to mount automatically efivarfs in /sys/firmware/efi/efivars
Please, wrap your commitlogs to 72 char-wide lines.
> Signed-off-by: Guillaume GC. Chaye <guillaume.chaye@zeetim.com>
> ---
> package/systemd/Config.in | 3 +++
> package/systemd/systemd.mk | 7 ++++++-
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/package/systemd/Config.in b/package/systemd/Config.in
> index 345f08590e..d1ca6e7f85 100644
> --- a/package/systemd/Config.in
> +++ b/package/systemd/Config.in
> @@ -161,6 +161,9 @@ config BR2_PACKAGE_SYSTEMD_BOOT_EFI_ARCH
> default "x64" if BR2_x86_64
> depends on BR2_PACKAGE_SYSTEMD_BOOT
>
> +config BR2_PACKAGE_SYSTEMD_EFI
> + bool "enable EFI support"
With this, when the user enables BR2_PACKAGE_SYSTEMD_BOOT but does not
enable BR2_PACKAGE_SYSTEMD_EFI, then -Defi=true is still passed, and
systemd still has EFI support. This is misleading, because the user sees
"enale EFI support" disabled.
But see below..
> config BR2_PACKAGE_SYSTEMD_JOURNAL_REMOTE
> bool "enable journal remote tools"
> select BR2_PACKAGE_LIBCURL
> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> index 5dca8681bc..7b3eabbd0d 100644
> --- a/package/systemd/systemd.mk
> +++ b/package/systemd/systemd.mk
> @@ -660,7 +660,12 @@ define SYSTEMD_INSTALL_BOOT_FILES
> endef
>
> else
> -SYSTEMD_CONF_OPTS += -Defi=false -Dbootloader=disabled
> +SYSTEMD_CONF_OPTS += -Dbootloader=disabled
> +ifeq ($(BR2_PACKAGE_SYSTEMD_EFI),y)
> +SYSTEMD_CONF_OPTS += -Defi=true
> +else
> +SYSTEMD_CONF_OPTS += -Defi=false
> +endif
> endif # BR2_PACKAGE_SYSTEMD_BOOT == y
The -Defi option should be moved outside the bootloader conditional
block altogether, and BR2_PACKAGE_SYSTEMD_BOOT should select
BR2_PACKAGE_SYSTEMD_EFI.
Regards,
Yann E. MORIN.
> SYSTEMD_FALLBACK_HOSTNAME = $(call qstrip,$(BR2_TARGET_GENERIC_HOSTNAME))
> --
> 2.39.2
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/perl-file-slurp: add host package
2024-09-05 9:48 [Buildroot] [PATCH 1/2] package/perl-file-slurp: add host package Guillaume GC. Chaye
2024-09-05 9:48 ` [Buildroot] [PATCH 2/2] package/systemd: add efi support option Guillaume GC. Chaye
@ 2024-09-05 12:18 ` Yann E. MORIN
1 sibling, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2024-09-05 12:18 UTC (permalink / raw)
To: Guillaume GC. Chaye
Cc: Christopher McCrory, Norbert Lange, Sen Hastings, buildroot
Guillaume, All,
On 2024-09-05 11:48 +0200, Guillaume GC. Chaye spake thusly:
> Some project like efitools requires host version of this package to build properly.
Please wrap your commit logs t o72-char wide lines.
As is, this change will never be tested, because we have nothing in the
Buildroot tree that depends on host-perl-file-slurp.
We ciurrently do not have efitools packaged in Buildroot. Are you
planning to do so? If so, then please include this change into a series
that adds efitools.
Also, I don't think there is a relation between this patch, and the
folowing one about systemd, so don't send tem as a series.
Regards,
Yann E. MORIN.
> Signed-off-by: Guillaume GC. Chaye <guillaume.chaye@zeetim.com>
> ---
> package/perl-file-slurp/perl-file-slurp.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/perl-file-slurp/perl-file-slurp.mk b/package/perl-file-slurp/perl-file-slurp.mk
> index 0d4ab94034..7cada58070 100644
> --- a/package/perl-file-slurp/perl-file-slurp.mk
> +++ b/package/perl-file-slurp/perl-file-slurp.mk
> @@ -12,3 +12,4 @@ PERL_FILE_SLURP_LICENSE_FILES = README.md
> PERL_FILE_SLURP_DISTNAME = File-Slurp
>
> $(eval $(perl-package))
> +$(eval $(host-perl-package))
> --
> 2.39.2
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] package/perl-file-slurp: add host package.
@ 2025-03-25 13:46 Guillaume Chaye
2025-05-16 19:06 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 6+ messages in thread
From: Guillaume Chaye @ 2025-03-25 13:46 UTC (permalink / raw)
To: buildroot; +Cc: Christopher McCrory, Guillaume Chaye, Thomas Petazzoni
Some project like efitools requires host version of this package to build properly.
Signed-off-by: Guillaume Chaye <guillaume.chaye@zeetim.com>
---
package/perl-file-slurp/perl-file-slurp.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/perl-file-slurp/perl-file-slurp.mk b/package/perl-file-slurp/perl-file-slurp.mk
index 0d4ab94034..7cada58070 100644
--- a/package/perl-file-slurp/perl-file-slurp.mk
+++ b/package/perl-file-slurp/perl-file-slurp.mk
@@ -12,3 +12,4 @@ PERL_FILE_SLURP_LICENSE_FILES = README.md
PERL_FILE_SLURP_DISTNAME = File-Slurp
$(eval $(perl-package))
+$(eval $(host-perl-package))
--
2.39.5
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/perl-file-slurp: add host package.
2025-03-25 13:46 Guillaume Chaye
@ 2025-05-16 19:06 ` Thomas Petazzoni via buildroot
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni via buildroot @ 2025-05-16 19:06 UTC (permalink / raw)
To: Guillaume Chaye; +Cc: buildroot, Christopher McCrory
Hello Guillaume,
Some minor comments for this patch (which I could have fixed locally,
but I have plenty of comments on PATCH 2, so the series will anyway
need a new iteration).
First of all, please make sure version your series, and correctly. You
send v1, v2, v3 (two times), v4, then v6 (no v5) and then here you're
back with no version.
Small detail: don't add a full stop ("point final" in French) at the
end of the commit title.
On Tue, 25 Mar 2025 09:46:08 -0400
Guillaume Chaye <guillaume.chaye@zeetim.com> wrote:
> Some project like efitools requires host version of this package to build properly.
Please wrap your commit message to ~80 columns.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-05-16 19:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-05 9:48 [Buildroot] [PATCH 1/2] package/perl-file-slurp: add host package Guillaume GC. Chaye
2024-09-05 9:48 ` [Buildroot] [PATCH 2/2] package/systemd: add efi support option Guillaume GC. Chaye
2024-09-05 12:04 ` Yann E. MORIN
2024-09-05 12:18 ` [Buildroot] [PATCH 1/2] package/perl-file-slurp: add host package Yann E. MORIN
-- strict thread matches above, loose matches on Subject: below --
2025-03-25 13:46 Guillaume Chaye
2025-05-16 19:06 ` Thomas Petazzoni via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.