From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kimriver Liu <kimriver.liu@siengine.com>
Cc: jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
jsd@semihalf.com, andi.shyti@kernel.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: designware: fix master is holding SCL low while ENABLE bit is disabled
Date: Fri, 6 Sep 2024 14:52:09 +0300 [thread overview]
Message-ID: <Ztrs6bA7gfSCl4e7@smile.fi.intel.com> (raw)
In-Reply-To: <20240906074731.3064-1-kimriver.liu@siengine.com>
On Fri, Sep 06, 2024 at 03:47:31PM +0800, Kimriver Liu wrote:
> It was observed issuing ABORT bit(IC_ENABLE[1]) will not work when
> IC_ENABLE is already disabled.
>
> Check if ENABLE bit(IC_ENABLE[0]) is disabled when the master is
> holding SCL low. If ENABLE bit is disabled, the software need
> enable it before trying to issue ABORT bit. otherwise,
> the controller ignores any write to ABORT bit.
This is *still* version 1!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-06 11:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 7:47 [PATCH] i2c: designware: fix master is holding SCL low while ENABLE bit is disabled Kimriver Liu
2024-09-06 8:07 ` Mika Westerberg
2024-09-08 2:39 ` 回复: " Liu Kimriver/刘金河
2024-09-06 11:52 ` Andy Shevchenko [this message]
2024-09-06 16:03 ` Andi Shyti
2024-09-06 21:34 ` Andi Shyti
2024-09-08 2:56 ` Liu Kimriver/刘金河
-- strict thread matches above, loose matches on Subject: below --
2024-09-06 6:54 Kimriver Liu
2024-09-06 7:05 ` Mika Westerberg
2024-09-06 11:50 ` Andy Shevchenko
2024-09-06 5:42 Kimriver Liu
2024-09-06 6:16 ` Mika Westerberg
2024-09-06 11:47 ` Andy Shevchenko
2024-09-08 2:12 ` Liu Kimriver/刘金河
2024-09-05 7:42 kimriver liu
2024-09-05 11:03 ` Andy Shevchenko
2024-09-08 13:31 ` kernel test robot
2024-09-09 1:31 ` Liu Kimriver/刘金河
2024-09-09 6:50 ` Liu Kimriver/刘金河
2024-09-05 5:57 kimriver liu
2024-09-05 11:00 ` Andy Shevchenko
2024-09-04 6:42 kimriver liu
2024-09-04 12:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ztrs6bA7gfSCl4e7@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=kimriver.liu@siengine.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.