Re: [PATCH 06/11] drm/i915/reg: fix PCH transcoder timing and data/link m/n style

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Sep 10, 2024 at 11:05:10AM +0300, Jani Nikula wrote:
> On Tue, 10 Sep 2024, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > On Mon, Sep 09, 2024 at 09:58:57PM +0300, Jani Nikula wrote:
> >> Adhere to the style described at the top of i915_reg.h.
> >> 
> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >> ---
> >>  drivers/gpu/drm/i915/i915_reg.h | 77 ++++++++++++++++++---------------
> >>  1 file changed, 43 insertions(+), 34 deletions(-)
> >> 
> >> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> >> index 2f09145b9791..e439a67fde61 100644
> >> --- a/drivers/gpu/drm/i915/i915_reg.h
> >> +++ b/drivers/gpu/drm/i915/i915_reg.h
> >> @@ -3160,33 +3160,76 @@
> >>  /* transcoder */
> >>  
> >>  #define _PCH_TRANS_HTOTAL_A		0xe0000
> >> +#define _PCH_TRANS_HTOTAL_B          0xe1000
> >
> > There's some tab vs. space damage in this patch.
> 
> Ah, the damage is there before, and I'm just moving lines around. Fixing
> in the same patch breaks git show --color-moved, do you prefer fixing in
> the same patch or a separate patch?

Separate patch seems fine.

-- 
Ville Syrjälä
Intel