From: Benjamin Marzinski <bmarzins@redhat.com>
To: Martin Wilck <martin.wilck@suse.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>,
device-mapper development <dm-devel@lists.linux.dev>
Subject: Re: [PATCH v2 00/22] Yet Another path checker refactor
Date: Mon, 16 Sep 2024 17:11:37 -0400 [thread overview]
Message-ID: <ZuifCU3K3sYojQQC@redhat.com> (raw)
In-Reply-To: <c8ac1916a0595aa74fa8c63cd62648d89802a38c.camel@suse.com>
On Fri, Sep 13, 2024 at 11:30:23AM +0200, Martin Wilck wrote:
> On Thu, 2024-09-12 at 17:49 -0400, Benjamin Marzinski wrote:
> > This patchset cleans up some of the ugly code from my last refactor,
> > and
> > speeds up multipathd path checking, by refactoring how paths are
> > checked.
> >
>
> I haven't started reviewing this yet, but I'm seeing a CI problem with
> the sysfs test, only with clang 18 on Fedora 40:
> https://github.com/openSUSE/multipath-tools/actions/runs/10845899189
I'm not sure what this is and I've been entirely unable to reproduce it
using Fedora 40 and clang 18.1.8 (the current f40 version of clang). It
seems pretty obvious that I has nothing to do with my patchset. It
looks like it's related to the renaming open() issues. Given the
"%s() has remaining non-returned values."
and
"__wrap___open64_2: '%s' parameter still has values that haven't been
checked."
messages, I'm guessing something other than __open64_2() was called. But
like I said, I can't reproduce this.
-Ben
>
> Martin
next prev parent reply other threads:[~2024-09-16 21:11 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 21:49 [PATCH v2 00/22] Yet Another path checker refactor Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 01/22] libmultipath: store checker_check() result in checker struct Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 02/22] libmultipath: add missing checker function prototypes Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 03/22] libmultipath: split out the code to wait for pending checkers Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 04/22] libmultipath: remove pending wait code from libcheck_check calls Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 05/22] multipath-tools tests: fix up directio tests Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 06/22] libmultipath: split get_state into two functions Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 07/22] libmultipath: change path_offline to path_sysfs_state Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 08/22] multipathd: split check_path_state into two functions Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 09/22] multipathd: split do_checker_path Benjamin Marzinski
2024-10-03 20:23 ` Martin Wilck
2024-10-08 18:18 ` Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 10/22] multipathd: split check_path into two functions Benjamin Marzinski
2024-10-03 20:23 ` Martin Wilck
2024-10-08 18:29 ` Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 11/22] multipathd: split handle_uninitialized_path " Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 12/22] multipathd: split check_paths " Benjamin Marzinski
2024-10-03 20:41 ` Martin Wilck
2024-10-08 19:16 ` Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 13/22] multipathd: fix "fail path" and "reinstate path" commands Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 14/22] multipathd: update priority once after updating all paths Benjamin Marzinski
2024-10-03 21:00 ` Martin Wilck
2024-10-08 19:17 ` Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 15/22] multipathd: simplify checking for followover_should_failback Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 16/22] multipathd: only refresh prios on PATH_UP and PATH_GHOST Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 17/22] multipathd: remove pointless check Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 18/22] multipathd: fix deferred_failback_tick for reload removes Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 19/22] libmultipath: add libcheck_need_wait checker function Benjamin Marzinski
2024-10-03 21:15 ` Martin Wilck
2024-10-08 19:33 ` Benjamin Marzinski
2024-10-09 15:49 ` Martin Wilck
2024-10-14 17:48 ` Benjamin Marzinski
2024-10-14 21:08 ` Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 20/22] libmultipath: don't wait in libcheck_pending Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 21/22] multipathd: wait for checkers to complete Benjamin Marzinski
2024-09-12 21:49 ` [PATCH v2 22/22] multipath-tools tests: fix up directio tests Benjamin Marzinski
2024-09-13 9:30 ` [PATCH v2 00/22] Yet Another path checker refactor Martin Wilck
2024-09-16 21:11 ` Benjamin Marzinski [this message]
2024-09-17 10:13 ` Martin Wilck
2024-10-03 21:23 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuifCU3K3sYojQQC@redhat.com \
--to=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@lists.linux.dev \
--cc=martin.wilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.