All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: Ma Xinjian <maxj.fnst@fujitsu.com>,
	keyrings@vger.kernel.org, ltp@lists.linux.it,
	Eric Biggers <ebiggers@google.com>
Subject: Re: [LTP] [PATCH] request_key: Add negative tests for request_key
Date: Tue, 17 Sep 2024 10:18:34 +0200	[thread overview]
Message-ID: <Zuk7Wn1CWSLaicut@yuki.lan> (raw)
In-Reply-To: <20240730103431.GA1371143@pevik>

Hi!
> LGTM, thanks!
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> 
> We also somehow test EACCES (request_key04.c). Looking into man page, there are
> other interesting errno to test I suppose (EDQUOT, EKEYEXPIRED, EKEYREJECTED,
> ...)
> 
> @Eric, other devs, would you have time to have a quick look on the test?

I've pushed the patch, we can add more tests later on.

-- 
Cyril Hrubis
chrubis@suse.cz

WARNING: multiple messages have this Message-ID (diff)
From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: keyrings@vger.kernel.org, ltp@lists.linux.it,
	Eric Biggers <ebiggers@google.com>
Subject: Re: [LTP] [PATCH] request_key: Add negative tests for request_key
Date: Tue, 17 Sep 2024 10:18:34 +0200	[thread overview]
Message-ID: <Zuk7Wn1CWSLaicut@yuki.lan> (raw)
In-Reply-To: <20240730103431.GA1371143@pevik>

Hi!
> LGTM, thanks!
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> 
> We also somehow test EACCES (request_key04.c). Looking into man page, there are
> other interesting errno to test I suppose (EDQUOT, EKEYEXPIRED, EKEYREJECTED,
> ...)
> 
> @Eric, other devs, would you have time to have a quick look on the test?

I've pushed the patch, we can add more tests later on.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-09-17  8:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-21  8:15 [LTP] [PATCH] request_key: Add negative tests for request_key Ma Xinjian via ltp
2024-07-30 10:34 ` Petr Vorel
2024-07-30 10:34   ` Petr Vorel
2024-09-17  8:18   ` Cyril Hrubis [this message]
2024-09-17  8:18     ` Cyril Hrubis
2024-09-17  8:18 ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zuk7Wn1CWSLaicut@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ebiggers@google.com \
    --cc=keyrings@vger.kernel.org \
    --cc=ltp@lists.linux.it \
    --cc=maxj.fnst@fujitsu.com \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.