From: "Daniel P. Berrangé" <berrange@redhat.com>
To: dave@treblig.org
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] sockets: Remove deadcode
Date: Thu, 19 Sep 2024 14:12:43 +0200 [thread overview]
Message-ID: <ZuwVLemC3hVirWGZ@redhat.com> (raw)
In-Reply-To: <20240918232633.463861-1-dave@treblig.org>
On Thu, Sep 19, 2024 at 12:26:33AM +0100, dave@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <dave@treblig.org>
>
> socket_remote_address hasn't been used since it was added in
> 17c55decec ("sockets: add helpers for creating SocketAddress from a socket")
>
> inet_connect hasn't been used since 2017's
> 8ecc2f9eab ("sheepdog: Use SocketAddress and socket_connect()")
Excellent ! The more of sockets.h we can remove the better.
>
> Remove them.
>
> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> ---
> include/qemu/sockets.h | 16 ----------------
> util/qemu-sockets.c | 35 -----------------------------------
> 2 files changed, 51 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
and queued.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-09-19 12:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 23:26 [PATCH] sockets: Remove deadcode dave
2024-09-19 12:12 ` Daniel P. Berrangé [this message]
2024-10-19 12:02 ` Dr. David Alan Gilbert
2024-10-21 8:27 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuwVLemC3hVirWGZ@redhat.com \
--to=berrange@redhat.com \
--cc=dave@treblig.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.