Re: [PATCH] sockets: Remove deadcode

["Daniel P. Berrangé" <berrange@redhat.com>]

On Sat, Oct 19, 2024 at 12:02:01PM +0000, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrangé (berrange@redhat.com) wrote:
> > On Thu, Sep 19, 2024 at 12:26:33AM +0100, dave@treblig.org wrote:
> > > From: "Dr. David Alan Gilbert" <dave@treblig.org>
> > > 
> > > socket_remote_address hasn't been used since it was added in
> > >   17c55decec ("sockets: add helpers for creating SocketAddress from a socket")
> > > 
> > > inet_connect hasn't been used since 2017's
> > >   8ecc2f9eab ("sheepdog: Use SocketAddress and socket_connect()")
> > 
> > Excellent ! The more of sockets.h we can remove the better.
> > 
> > > 
> > > Remove them.
> > > 
> > > Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> > > ---
> > >  include/qemu/sockets.h | 16 ----------------
> > >  util/qemu-sockets.c    | 35 -----------------------------------
> > >  2 files changed, 51 deletions(-)
> > 
> > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> > 
> > and queued.
> 
> Hi Dan,
>   Just checking, I noticed this one and the crypto patch haven't made
> it to master yet.

Yeah, sorry, I still have them in a pending queue.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|