From: Catalin Marinas <catalin.marinas@arm.com>
To: Kristina Martsenko <kristina.martsenko@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Marc Zyngier <maz@kernel.org>
Subject: Re: [PATCH 1/5] arm64: probes: Disable kprobes/uprobes on MOPS instructions
Date: Wed, 2 Oct 2024 11:28:24 +0100 [thread overview]
Message-ID: <Zv0gSAaPTSZH0jQv@arm.com> (raw)
In-Reply-To: <20240930161051.3777828-2-kristina.martsenko@arm.com>
On Mon, Sep 30, 2024 at 05:10:47PM +0100, Kristina Martsenko wrote:
> FEAT_MOPS instructions require that all three instructions (prologue,
> main and epilogue) appear consecutively in memory. Placing a
> kprobe/uprobe on one of them doesn't work as only a single instruction
> gets executed out-of-line or simulated. So don't allow placing a probe
> on a MOPS instruction.
>
> Fixes: b7564127ffcb ("arm64: mops: detect and enable FEAT_MOPS")
> Signed-off-by: Kristina Martsenko <kristina.martsenko@arm.com>
I think this would benefit from a cc stable:
Cc: <stable@vger.kernel.org> # 6.5.x
I can add it when applying the patch.
--
Catalin
next prev parent reply other threads:[~2024-10-02 10:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 16:10 [PATCH 0/5] arm64: Use memory copy instructions in kernel routines Kristina Martsenko
2024-09-30 16:10 ` [PATCH 1/5] arm64: probes: Disable kprobes/uprobes on MOPS instructions Kristina Martsenko
2024-10-02 10:28 ` Catalin Marinas [this message]
2024-09-30 16:10 ` [PATCH 2/5] arm64: mops: Handle MOPS exceptions from EL1 Kristina Martsenko
2024-09-30 16:10 ` [PATCH 3/5] arm64: mops: Document booting requirement for HCR_EL2.MCE2 Kristina Martsenko
2024-10-02 10:38 ` Catalin Marinas
2024-10-02 13:31 ` Kristina Martsenko
2024-10-02 17:09 ` Catalin Marinas
2024-09-30 16:10 ` [PATCH 4/5] arm64: lib: Use MOPS for memcpy() routines Kristina Martsenko
2024-10-02 15:29 ` Catalin Marinas
2024-10-03 16:46 ` Kristina Martsenko
2024-10-04 10:07 ` Catalin Marinas
2024-10-16 13:08 ` Kristina Martsenko
2024-10-17 11:57 ` Catalin Marinas
2024-09-30 16:10 ` [PATCH 5/5] arm64: lib: Use MOPS for copy_page() and clear_page() Kristina Martsenko
2024-10-02 15:37 ` Catalin Marinas
2024-10-02 16:20 ` [PATCH 0/5] arm64: Use memory copy instructions in kernel routines Catalin Marinas
2024-10-03 16:49 ` Kristina Martsenko
2024-10-04 10:10 ` Catalin Marinas
2024-10-17 18:00 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv0gSAaPTSZH0jQv@arm.com \
--to=catalin.marinas@arm.com \
--cc=kristina.martsenko@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.