All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Righi <andrea.righi@linux.dev>
To: Phil Auld <pauld@redhat.com>
Cc: Tejun Heo <tj@kernel.org>, David Vernet <void@manifault.com>,
	Giovanni Gherdovich <giovanni.gherdovich@suse.com>,
	Kleber Sacilotto de Souza <kleber.souza@canonical.com>,
	Marcelo Henrique Cerri <marcelo.cerri@canonical.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched_ext: Provide a sysfs enable_seq counter
Date: Mon, 23 Sep 2024 18:34:20 +0200	[thread overview]
Message-ID: <ZvGYjKAB07VJW7jq@gpd3> (raw)
In-Reply-To: <20240923160007.GA313849@pauld.westford.csb>

On Mon, Sep 23, 2024 at 12:00:07PM -0400, Phil Auld wrote:
> On Mon, Sep 23, 2024 at 05:32:15AM -1000 Tejun Heo wrote:
> > Hello,
> > 
> > On Mon, Sep 23, 2024 at 12:45:48PM +0200, Phil Auld wrote:
> > ...
> > > It's not a per scheduler counter, though. It's global. We want to know
> > 
> > Yeah, the sequence is global but we can report the sequence at which a given
> > scheduler is loaded on each scheduler. That way, e.g., you can tell whether
> > a particular scheduler instance is the same one you looked at the last time
> > too.
> > 
> > > that a (any) scx scheduler has been loaded at some time in the past. It's
> > > really only interesting when 0 or > 0. The actual non-zero number and which
> > > scheduler(s) don't matter that much.
> > 
> > Not necessarily. e.g. You can also detect scheduler failing or being updated
> > for other reasons.
> 
> Sure, but the primary purpose is practically boolean. 
> 
> > 
> > > And it needs to persist when the scheduler is unloaded (I didn't look but
> > > I uspect the per scheduler attrs come and go?).
> > 
> > Yes, the load sequence number should stay persistent across all schedulers,
> > but each scheduler should report the sequence number at which *it* was
> > loaded. Note that this doesn't really change anything now. If you only care
> > whether any SCX scheduler has ever been loaded, you'd always look under
> > root.
> >
> 
> In my testing root is not there is nothing is loaded. 

Right, there's no root if no sched_ext scheduler is loaded. Maybe we
should always keep root present, or have a global counter and one
per-sched?

-Andrea

  reply	other threads:[~2024-09-23 16:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-21 19:39 [PATCH] sched_ext: Provide a sysfs enable_seq counter andrea.righi
2024-09-22 21:21 ` Tejun Heo
2024-09-23 10:45   ` Phil Auld
2024-09-23 15:14     ` Andrea Righi
2024-09-23 15:32     ` Tejun Heo
2024-09-23 16:00       ` Phil Auld
2024-09-23 16:34         ` Andrea Righi [this message]
2024-09-23 16:47           ` Tejun Heo
2024-09-23 16:57             ` Phil Auld
2024-09-23 17:01               ` Tejun Heo
2024-09-23 17:16               ` andrea.righi
2024-09-23 10:48 ` Phil Auld
2024-09-23 16:53 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZvGYjKAB07VJW7jq@gpd3 \
    --to=andrea.righi@linux.dev \
    --cc=giovanni.gherdovich@suse.com \
    --cc=kleber.souza@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.cerri@canonical.com \
    --cc=pauld@redhat.com \
    --cc=tj@kernel.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.