All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrea.righi@linux.dev
To: "Phil Auld" <pauld@redhat.com>, "Tejun Heo" <tj@kernel.org>
Cc: "David Vernet" <void@manifault.com>,
	"Giovanni Gherdovich" <giovanni.gherdovich@suse.com>,
	"Kleber Sacilotto de Souza" <kleber.souza@canonical.com>,
	"Marcelo Henrique Cerri" <marcelo.cerri@canonical.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched_ext: Provide a sysfs enable_seq counter
Date: Mon, 23 Sep 2024 17:16:16 +0000	[thread overview]
Message-ID: <e93dca67d070beb548c771a8836110cd015b7c48@linux.dev> (raw)
In-Reply-To: <20240923165749.GB313849@pauld.westford.csb>

September 23, 2024 at 6:57 PM, "Phil Auld" <pauld@redhat.com> wrote:
> 
> On Mon, Sep 23, 2024 at 06:47:12AM -1000 Tejun Heo wrote:
> 
> > 
> > Hello,
> > 
> >  
> > 
> >  On Mon, Sep 23, 2024 at 06:34:20PM +0200, Andrea Righi wrote:
> > 
> >  ...
> > 
> >  > > Yes, the load sequence number should stay persistent across all schedulers,
> > 
> >  > > but each scheduler should report the sequence number at which *it* was
> > 
> >  > > loaded. Note that this doesn't really change anything now. If you only care
> > 
> >  > > whether any SCX scheduler has ever been loaded, you'd always look under
> > 
> >  > > root.
> > 
> >  > >
> > 
> >  > 
> > 
> >  > In my testing root is not there is nothing is loaded. 
> > 
> >  
> > 
> >  Ah, right.
> > 
> >  
> > 
> >  Right, there's no root if no sched_ext scheduler is loaded. Maybe we
> > 
> >  should always keep root present, or have a global counter and one
> > 
> >  per-sched?
> > 
> >  
> > 
> >  I'll apply as-is. Let's add per-scheduler load seq separately.
> > 
> 
> Thanks! I was thinking that per-scheduler you could just snapshot the
> 
> global counter (either before or after increment) on load. Then you
> 
> could easily tell when each was loaded relative to each other etc.
> 
> Especially while "per-scheduler" is defined by string comparison I'd
> 
> prefer not to rely on that for this use case. 

Right, and it should be a trivial change, I'll work on that as soon as I find a stable spot (still on the road for conferences) :)

-Andrea

  parent reply	other threads:[~2024-09-23 17:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-21 19:39 [PATCH] sched_ext: Provide a sysfs enable_seq counter andrea.righi
2024-09-22 21:21 ` Tejun Heo
2024-09-23 10:45   ` Phil Auld
2024-09-23 15:14     ` Andrea Righi
2024-09-23 15:32     ` Tejun Heo
2024-09-23 16:00       ` Phil Auld
2024-09-23 16:34         ` Andrea Righi
2024-09-23 16:47           ` Tejun Heo
2024-09-23 16:57             ` Phil Auld
2024-09-23 17:01               ` Tejun Heo
2024-09-23 17:16               ` andrea.righi [this message]
2024-09-23 10:48 ` Phil Auld
2024-09-23 16:53 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e93dca67d070beb548c771a8836110cd015b7c48@linux.dev \
    --to=andrea.righi@linux.dev \
    --cc=giovanni.gherdovich@suse.com \
    --cc=kleber.souza@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.cerri@canonical.com \
    --cc=pauld@redhat.com \
    --cc=tj@kernel.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.