All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: renesas: add proper node names to (L)BSC devices
Date: Thu, 26 Sep 2024 12:04:53 +0200	[thread overview]
Message-ID: <ZvUxxWTIDCGOUQjh@shikoro> (raw)
In-Reply-To: <CAMuHMdVBAWny2Z1e6_D+v+=jd2y63a=HDe9+cnRMwfNTeh0cpA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

Hi Geert,

thanks for the review!

> The "@<unit-address>" part is optional.

Ah! Then, I actually prefer dropping the unit address.

> Actually, I cannot find that in the DT spec, only:
> 
>    "If the node has no reg property, the @unit-address must be omitted".

Sounds good to me. However, sh73a0 and r8a73a4 are still a bit strange.
They have a unit-address because they have a reg-property which is
documented for renesas,bsc. However, there is no driver for the BSC.
AFAICS, this could work as well with "simple-pm-bus" and we could drop
the renesas,bsc bindings? This probably is a separate issue, though.

Happy hacking,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-09-26 10:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-26  7:57 [PATCH 0/2] ARM: dts: renesas: fix BSC nodes Wolfram Sang
2024-09-26  7:57 ` [PATCH 1/2] ARM: dts: renesas: add proper node names to (L)BSC devices Wolfram Sang
2024-09-26  8:25   ` Geert Uytterhoeven
2024-09-26 10:04     ` Wolfram Sang [this message]
2024-09-26 10:09       ` Geert Uytterhoeven
2024-09-26  7:57 ` [PATCH 2/2] ARM: dts: renesas: r8a7778: rename 'bsc' to 'lbsc' Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZvUxxWTIDCGOUQjh@shikoro \
    --to=wsa+renesas@sang-engineering.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.