* [PATCH 0/2] ARM: dts: renesas: fix BSC nodes @ 2024-09-26 7:57 Wolfram Sang 2024-09-26 7:57 ` [PATCH 1/2] ARM: dts: renesas: add proper node names to (L)BSC devices Wolfram Sang 2024-09-26 7:57 ` [PATCH 2/2] ARM: dts: renesas: r8a7778: rename 'bsc' to 'lbsc' Wolfram Sang 0 siblings, 2 replies; 6+ messages in thread From: Wolfram Sang @ 2024-09-26 7:57 UTC (permalink / raw) To: linux-renesas-soc; +Cc: Wolfram Sang While cleaning up the Genmai DTS, I stumbled upon further checks regarding the (L)BSC. These patches fix them. Wolfram Sang (2): ARM: dts: renesas: add proper node names to (L)BSC devices ARM: dts: renesas: r8a7778: rename 'bsc' to 'lbsc' arch/arm/boot/dts/renesas/r7s72100.dtsi | 2 +- arch/arm/boot/dts/renesas/r8a7778-bockw.dts | 2 +- arch/arm/boot/dts/renesas/r8a7778.dtsi | 2 +- arch/arm/boot/dts/renesas/r8a7779.dtsi | 2 +- arch/arm/boot/dts/renesas/r8a7792.dtsi | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) -- 2.45.2 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] ARM: dts: renesas: add proper node names to (L)BSC devices 2024-09-26 7:57 [PATCH 0/2] ARM: dts: renesas: fix BSC nodes Wolfram Sang @ 2024-09-26 7:57 ` Wolfram Sang 2024-09-26 8:25 ` Geert Uytterhoeven 2024-09-26 7:57 ` [PATCH 2/2] ARM: dts: renesas: r8a7778: rename 'bsc' to 'lbsc' Wolfram Sang 1 sibling, 1 reply; 6+ messages in thread From: Wolfram Sang @ 2024-09-26 7:57 UTC (permalink / raw) To: linux-renesas-soc; +Cc: Wolfram Sang (L)BSC should have a "bus" node name together with its register set [1]. Add the missing names, and change one with a wrong address not matching the register space. [1] lbsc: $nodename:0: 'lbsc' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$' Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- arch/arm/boot/dts/renesas/r7s72100.dtsi | 2 +- arch/arm/boot/dts/renesas/r8a7778.dtsi | 2 +- arch/arm/boot/dts/renesas/r8a7779.dtsi | 2 +- arch/arm/boot/dts/renesas/r8a7792.dtsi | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/renesas/r7s72100.dtsi b/arch/arm/boot/dts/renesas/r7s72100.dtsi index 07ffd9ec96cc..a460a9092c43 100644 --- a/arch/arm/boot/dts/renesas/r7s72100.dtsi +++ b/arch/arm/boot/dts/renesas/r7s72100.dtsi @@ -36,7 +36,7 @@ b_clk: b { clock-div = <3>; }; - bsc: bsc { + bsc: bus@3fffc000 { compatible = "simple-bus"; #address-cells = <1>; #size-cells = <1>; diff --git a/arch/arm/boot/dts/renesas/r8a7778.dtsi b/arch/arm/boot/dts/renesas/r8a7778.dtsi index b80e832c9277..ab0b76eacd3c 100644 --- a/arch/arm/boot/dts/renesas/r8a7778.dtsi +++ b/arch/arm/boot/dts/renesas/r8a7778.dtsi @@ -40,7 +40,7 @@ aliases { spi2 = &hspi2; }; - bsc: bus@1c000000 { + bsc: bus@ff800000 { compatible = "simple-bus"; #address-cells = <1>; #size-cells = <1>; diff --git a/arch/arm/boot/dts/renesas/r8a7779.dtsi b/arch/arm/boot/dts/renesas/r8a7779.dtsi index 1944703cba4f..3c5746dbe639 100644 --- a/arch/arm/boot/dts/renesas/r8a7779.dtsi +++ b/arch/arm/boot/dts/renesas/r8a7779.dtsi @@ -704,7 +704,7 @@ R8A7779_CLK_MMC1 R8A7779_CLK_MMC0 }; }; - lbsc: lbsc { + lbsc: bus@ff800000 { compatible = "simple-bus"; #address-cells = <1>; #size-cells = <1>; diff --git a/arch/arm/boot/dts/renesas/r8a7792.dtsi b/arch/arm/boot/dts/renesas/r8a7792.dtsi index dd3bc32668b7..471a2913e51e 100644 --- a/arch/arm/boot/dts/renesas/r8a7792.dtsi +++ b/arch/arm/boot/dts/renesas/r8a7792.dtsi @@ -84,7 +84,7 @@ extal_clk: extal { clock-frequency = <0>; }; - lbsc: lbsc { + lbsc: bus@fec00000 { compatible = "simple-bus"; #address-cells = <1>; #size-cells = <1>; -- 2.45.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ARM: dts: renesas: add proper node names to (L)BSC devices 2024-09-26 7:57 ` [PATCH 1/2] ARM: dts: renesas: add proper node names to (L)BSC devices Wolfram Sang @ 2024-09-26 8:25 ` Geert Uytterhoeven 2024-09-26 10:04 ` Wolfram Sang 0 siblings, 1 reply; 6+ messages in thread From: Geert Uytterhoeven @ 2024-09-26 8:25 UTC (permalink / raw) To: Wolfram Sang; +Cc: linux-renesas-soc Hi Wolfram, On Thu, Sep 26, 2024 at 9:58 AM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > (L)BSC should have a "bus" node name together with its register set [1]. > Add the missing names, and change one with a wrong address not matching > the register space. Thanks for your patch! > [1] lbsc: $nodename:0: 'lbsc' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$' The "@<unit-address>" part is optional. > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > arch/arm/boot/dts/renesas/r7s72100.dtsi | 2 +- > arch/arm/boot/dts/renesas/r8a7778.dtsi | 2 +- > arch/arm/boot/dts/renesas/r8a7779.dtsi | 2 +- > arch/arm/boot/dts/renesas/r8a7792.dtsi | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/renesas/r7s72100.dtsi b/arch/arm/boot/dts/renesas/r7s72100.dtsi > index 07ffd9ec96cc..a460a9092c43 100644 > --- a/arch/arm/boot/dts/renesas/r7s72100.dtsi > +++ b/arch/arm/boot/dts/renesas/r7s72100.dtsi > @@ -36,7 +36,7 @@ b_clk: b { > clock-div = <3>; > }; > > - bsc: bsc { > + bsc: bus@3fffc000 { In the absence of a "reg" property, shouldn't the unit-address match the "ranges" property? Actually, I cannot find that in the DT spec, only: "If the node has no reg property, the @unit-address must be omitted". > compatible = "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > diff --git a/arch/arm/boot/dts/renesas/r8a7778.dtsi b/arch/arm/boot/dts/renesas/r8a7778.dtsi > index b80e832c9277..ab0b76eacd3c 100644 > --- a/arch/arm/boot/dts/renesas/r8a7778.dtsi > +++ b/arch/arm/boot/dts/renesas/r8a7778.dtsi > @@ -40,7 +40,7 @@ aliases { > spi2 = &hspi2; > }; > > - bsc: bus@1c000000 { > + bsc: bus@ff800000 { "ranges" says 0x1c000000, so the former was correct? > compatible = "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > diff --git a/arch/arm/boot/dts/renesas/r8a7779.dtsi b/arch/arm/boot/dts/renesas/r8a7779.dtsi > index 1944703cba4f..3c5746dbe639 100644 > --- a/arch/arm/boot/dts/renesas/r8a7779.dtsi > +++ b/arch/arm/boot/dts/renesas/r8a7779.dtsi > @@ -704,7 +704,7 @@ R8A7779_CLK_MMC1 R8A7779_CLK_MMC0 > }; > }; > > - lbsc: lbsc { > + lbsc: bus@ff800000 { 0x1c000000 according to "ranges". > compatible = "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > diff --git a/arch/arm/boot/dts/renesas/r8a7792.dtsi b/arch/arm/boot/dts/renesas/r8a7792.dtsi > index dd3bc32668b7..471a2913e51e 100644 > --- a/arch/arm/boot/dts/renesas/r8a7792.dtsi > +++ b/arch/arm/boot/dts/renesas/r8a7792.dtsi > @@ -84,7 +84,7 @@ extal_clk: extal { > clock-frequency = <0>; > }; > > - lbsc: lbsc { > + lbsc: bus@fec00000 { 0x1c000000 according to "ranges". > compatible = "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ARM: dts: renesas: add proper node names to (L)BSC devices 2024-09-26 8:25 ` Geert Uytterhoeven @ 2024-09-26 10:04 ` Wolfram Sang 2024-09-26 10:09 ` Geert Uytterhoeven 0 siblings, 1 reply; 6+ messages in thread From: Wolfram Sang @ 2024-09-26 10:04 UTC (permalink / raw) To: Geert Uytterhoeven; +Cc: linux-renesas-soc [-- Attachment #1: Type: text/plain, Size: 665 bytes --] Hi Geert, thanks for the review! > The "@<unit-address>" part is optional. Ah! Then, I actually prefer dropping the unit address. > Actually, I cannot find that in the DT spec, only: > > "If the node has no reg property, the @unit-address must be omitted". Sounds good to me. However, sh73a0 and r8a73a4 are still a bit strange. They have a unit-address because they have a reg-property which is documented for renesas,bsc. However, there is no driver for the BSC. AFAICS, this could work as well with "simple-pm-bus" and we could drop the renesas,bsc bindings? This probably is a separate issue, though. Happy hacking, Wolfram [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ARM: dts: renesas: add proper node names to (L)BSC devices 2024-09-26 10:04 ` Wolfram Sang @ 2024-09-26 10:09 ` Geert Uytterhoeven 0 siblings, 0 replies; 6+ messages in thread From: Geert Uytterhoeven @ 2024-09-26 10:09 UTC (permalink / raw) To: Wolfram Sang; +Cc: linux-renesas-soc Hi Wolfram, On Thu, Sep 26, 2024 at 12:04 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > The "@<unit-address>" part is optional. > > Ah! Then, I actually prefer dropping the unit address. Fine for me! > > Actually, I cannot find that in the DT spec, only: > > > > "If the node has no reg property, the @unit-address must be omitted". > > Sounds good to me. However, sh73a0 and r8a73a4 are still a bit strange. > They have a unit-address because they have a reg-property which is > documented for renesas,bsc. However, there is no driver for the BSC. > AFAICS, this could work as well with "simple-pm-bus" and we could drop > the renesas,bsc bindings? This probably is a separate issue, though. You can have DT bindings without a (full) driver. Probably the other (L)BSC variants could be extended with a register block and interrupts, too, but so far we didn't have a need to describe them fully. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] ARM: dts: renesas: r8a7778: rename 'bsc' to 'lbsc' 2024-09-26 7:57 [PATCH 0/2] ARM: dts: renesas: fix BSC nodes Wolfram Sang 2024-09-26 7:57 ` [PATCH 1/2] ARM: dts: renesas: add proper node names to (L)BSC devices Wolfram Sang @ 2024-09-26 7:57 ` Wolfram Sang 1 sibling, 0 replies; 6+ messages in thread From: Wolfram Sang @ 2024-09-26 7:57 UTC (permalink / raw) To: linux-renesas-soc; +Cc: Wolfram Sang R-Car Gen1 has an LBSC which has quite a different register set from the former BSC. To match H1 with M1, rename the nodes to LBSC. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- arch/arm/boot/dts/renesas/r8a7778-bockw.dts | 2 +- arch/arm/boot/dts/renesas/r8a7778.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/renesas/r8a7778-bockw.dts b/arch/arm/boot/dts/renesas/r8a7778-bockw.dts index a3f9d74e8877..d79095470a02 100644 --- a/arch/arm/boot/dts/renesas/r8a7778-bockw.dts +++ b/arch/arm/boot/dts/renesas/r8a7778-bockw.dts @@ -61,7 +61,7 @@ sndcodec: simple-audio-card,codec { }; }; -&bsc { +&lbsc { flash@0 { compatible = "cfi-flash"; reg = <0x0 0x04000000>; diff --git a/arch/arm/boot/dts/renesas/r8a7778.dtsi b/arch/arm/boot/dts/renesas/r8a7778.dtsi index ab0b76eacd3c..c2464602cbb8 100644 --- a/arch/arm/boot/dts/renesas/r8a7778.dtsi +++ b/arch/arm/boot/dts/renesas/r8a7778.dtsi @@ -40,7 +40,7 @@ aliases { spi2 = &hspi2; }; - bsc: bus@ff800000 { + lbsc: bus@ff800000 { compatible = "simple-bus"; #address-cells = <1>; #size-cells = <1>; -- 2.45.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-09-26 10:09 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-09-26 7:57 [PATCH 0/2] ARM: dts: renesas: fix BSC nodes Wolfram Sang 2024-09-26 7:57 ` [PATCH 1/2] ARM: dts: renesas: add proper node names to (L)BSC devices Wolfram Sang 2024-09-26 8:25 ` Geert Uytterhoeven 2024-09-26 10:04 ` Wolfram Sang 2024-09-26 10:09 ` Geert Uytterhoeven 2024-09-26 7:57 ` [PATCH 2/2] ARM: dts: renesas: r8a7778: rename 'bsc' to 'lbsc' Wolfram Sang
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.