[XEN PATCH 0/2] blkif: Fix discard req align requirement and various typos

[XEN PATCH 0/2] blkif: Fix discard req align requirement and various typos

[Anthony PERARD]

Patch series available in this git branch:
https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.blkif-wording-fix-v1

Cheers,

Anthony PERARD (2):
  blkif: Fix alignment description for discard request
  blkif: Fix a couple of typos

 xen/include/public/io/blkif.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 


Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

[XEN PATCH 1/2] blkif: Fix alignment description for discard request

[Anthony PERARD]

The discard feature have an other xenstore node to described the size
of the blocks than can be discarded, "discard-granularity", which
default to "sector-size" when absent as noted in the properties and in
note 4. So discard request should be aligned on this value.

Fixes: 221f2748e8da ("blkif: reconcile protocol specification with in-use implementations")
Signed-off-by: Anthony PERARD <anthony.perard@vates.tech>
---
 xen/include/public/io/blkif.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h
index 9b00d633d3..789bab65ab 100644
--- a/xen/include/public/io/blkif.h
+++ b/xen/include/public/io/blkif.h
@@ -668,7 +668,7 @@ typedef struct blkif_request blkif_request_t;
  *
  * The 'sector_number' field is in units of 512b, despite the value of the
  * 'sector-size' xenstore node.  Note however that the offset in
- * 'sector_number' must be aligned to 'sector-size'.
+ * 'sector_number' must be aligned to 'discard-granularity'.
  */
 struct blkif_request_discard {
     uint8_t        operation;    /* BLKIF_OP_DISCARD                     */
-- 


Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

[XEN PATCH 2/2] blkif: Fix a couple of typos

[Anthony PERARD]

Those where fixed in OVMF's copy. (And one of them fixed in QEMU's
copy but later discarded by an update.)

Signed-off-by: Anthony PERARD <anthony.perard@vates.tech>
---
 xen/include/public/io/blkif.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h
index 789bab65ab..8407453324 100644
--- a/xen/include/public/io/blkif.h
+++ b/xen/include/public/io/blkif.h
@@ -42,7 +42,7 @@
  * All data in the XenStore is stored as strings.  Nodes specifying numeric
  * values are encoded in decimal.  Integer value ranges listed below are
  * expressed as fixed sized integer types capable of storing the conversion
- * of a properly formated node string, without loss of information.
+ * of a properly formatted node string, without loss of information.
  *
  * Any specified default value is in effect if the corresponding XenBus node
  * is not present in the XenStore.
@@ -328,7 +328,7 @@
  *      access (even when it should be read-only). If the frontend hits the
  *      maximum number of allowed persistently mapped grants, it can fallback
  *      to non persistent mode. This will cause a performance degradation,
- *      since the the backend driver will still try to map those grants
+ *      since the backend driver will still try to map those grants
  *      persistently. Since the persistent grants protocol is compatible with
  *      the previous protocol, a frontend driver can choose to work in
  *      persistent mode even when the backend doesn't support it.
-- 


Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

Re: [XEN PATCH 2/2] blkif: Fix a couple of typos

[Frediano Ziglio]

On Thu, Sep 26, 2024 at 1:54 PM Anthony PERARD
<anthony.perard@vates.tech> wrote:
>
> Those where fixed in OVMF's copy. (And one of them fixed in QEMU's
> copy but later discarded by an update.)
>
> Signed-off-by: Anthony PERARD <anthony.perard@vates.tech>
> ---
>  xen/include/public/io/blkif.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h
> index 789bab65ab..8407453324 100644
> --- a/xen/include/public/io/blkif.h
> +++ b/xen/include/public/io/blkif.h
> @@ -42,7 +42,7 @@
>   * All data in the XenStore is stored as strings.  Nodes specifying numeric
>   * values are encoded in decimal.  Integer value ranges listed below are
>   * expressed as fixed sized integer types capable of storing the conversion
> - * of a properly formated node string, without loss of information.
> + * of a properly formatted node string, without loss of information.
>   *
>   * Any specified default value is in effect if the corresponding XenBus node
>   * is not present in the XenStore.
> @@ -328,7 +328,7 @@
>   *      access (even when it should be read-only). If the frontend hits the
>   *      maximum number of allowed persistently mapped grants, it can fallback
>   *      to non persistent mode. This will cause a performance degradation,
> - *      since the the backend driver will still try to map those grants
> + *      since the backend driver will still try to map those grants
>   *      persistently. Since the persistent grants protocol is compatible with
>   *      the previous protocol, a frontend driver can choose to work in
>   *      persistent mode even when the backend doesn't support it.

Reviewed-by: Frediano Ziglio <frediano.ziglio@cloud.com>

Frediano

Re: [XEN PATCH 0/2] blkif: Fix discard req align requirement and various typos

[Jürgen Groß]

[-- Attachment #1.1.1: Type: text/plain, Size: 503 bytes --]

On 26.09.24 14:53, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.blkif-wording-fix-v1
> 
> Cheers,
> 
> Anthony PERARD (2):
>    blkif: Fix alignment description for discard request
>    blkif: Fix a couple of typos
> 
>   xen/include/public/io/blkif.h | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 

For the series:

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

Re: [XEN PATCH 0/2] blkif: Fix discard req align requirement and various typos

[Roger Pau Monné]

On Thu, Sep 26, 2024 at 12:53:49PM +0000, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.blkif-wording-fix-v1

That was fast, thanks:

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Regards, Roger.