From: Alexey Gladkov <legion@kernel.org>
To: Callum Andrew <contact@candrew.net>
Cc: kbd@lists.linux.dev
Subject: Re: [PATCH v2] Update Colemak-DH keymaps with upstream changes
Date: Sat, 28 Sep 2024 10:48:03 +0200 [thread overview]
Message-ID: <ZvfCwyirwkfoQ4Nq@example.org> (raw)
In-Reply-To: <20240928012936.22351-1-contact@candrew.net>
On Sat, Sep 28, 2024 at 11:29:34AM +1000, Callum Andrew wrote:
> - Make Wide Mod mappings consistent with specification
Don't mix file modifications and file renaming.
> - Rename from mod-dh (the name of the project) to colemak-dh (the name
> of the layout)
This renaming looks useless to me. The "colemak" is already present in
the path. You can always do that:
loadkeys colemak/mod-dh-ansi-us
in the same way as
loadkeys qwerty/cz
This is how keymaps search has been working for a very long time.
Duplicating the architecture, keymaps family, and everything else (in most
cases) but the language is bad practice.
I can understand why the author of colemak keymaps named them that in his
standalone project. But in kbd such naming does not seem correct to me.
> Signed-off-by: Callum Andrew <contact@candrew.net>
> ---
> ...-dh-ansi-us-awing.map => colemak-dh-ansi-us-awing.map} | 0
> ...-us-fatz-wide.map => colemak-dh-ansi-us-fatz-wide.map} | 4 ++--
> ...od-dh-ansi-us-fatz.map => colemak-dh-ansi-us-fatz.map} | 0
> ...od-dh-ansi-us-wide.map => colemak-dh-ansi-us-wide.map} | 4 ++--
> .../{mod-dh-ansi-us.map => colemak-dh-ansi-us.map} | 0
> ...{mod-dh-iso-uk-wide.map => colemak-dh-iso-uk-wide.map} | 8 ++++----
> .../colemak/{mod-dh-iso-uk.map => colemak-dh-iso-uk.map} | 0
> ...{mod-dh-iso-us-wide.map => colemak-dh-iso-us-wide.map} | 8 ++++----
> .../colemak/{mod-dh-iso-us.map => colemak-dh-iso-us.map} | 0
> .../{mod-dh-matrix-us.map => colemak-dh-matrix-us.map} | 0
> 10 files changed, 12 insertions(+), 12 deletions(-)
> rename data/keymaps/i386/colemak/{mod-dh-ansi-us-awing.map => colemak-dh-ansi-us-awing.map} (100%)
> rename data/keymaps/i386/colemak/{mod-dh-ansi-us-fatz-wide.map => colemak-dh-ansi-us-fatz-wide.map} (97%)
> rename data/keymaps/i386/colemak/{mod-dh-ansi-us-fatz.map => colemak-dh-ansi-us-fatz.map} (100%)
> rename data/keymaps/i386/colemak/{mod-dh-ansi-us-wide.map => colemak-dh-ansi-us-wide.map} (97%)
> rename data/keymaps/i386/colemak/{mod-dh-ansi-us.map => colemak-dh-ansi-us.map} (100%)
> rename data/keymaps/i386/colemak/{mod-dh-iso-uk-wide.map => colemak-dh-iso-uk-wide.map} (94%)
> rename data/keymaps/i386/colemak/{mod-dh-iso-uk.map => colemak-dh-iso-uk.map} (100%)
> rename data/keymaps/i386/colemak/{mod-dh-iso-us-wide.map => colemak-dh-iso-us-wide.map} (94%)
> rename data/keymaps/i386/colemak/{mod-dh-iso-us.map => colemak-dh-iso-us.map} (100%)
> rename data/keymaps/i386/colemak/{mod-dh-matrix-us.map => colemak-dh-matrix-us.map} (100%)
--
Rgrds, legion
next prev parent reply other threads:[~2024-09-28 8:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-28 1:29 [PATCH v2] Update Colemak-DH keymaps with upstream changes Callum Andrew
2024-09-28 8:48 ` Alexey Gladkov [this message]
2024-09-28 9:47 ` Callum Andrew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvfCwyirwkfoQ4Nq@example.org \
--to=legion@kernel.org \
--cc=contact@candrew.net \
--cc=kbd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.