All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: boris.brezillon@collabora.com
Cc: nicolas.ferre@microchip.com, miquel.raynal@bootlin.com,
	richard@nod.at, linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: of atmel_pmecc_destroy_user
Date: Sun, 29 Sep 2024 17:05:01 +0000	[thread overview]
Message-ID: <ZvmIvRJCf6VhHvpo@gallifrey> (raw)

Hi Boris and co,
  One of my scripts noticed that 'atmel_pmecc_destroy_user'
isn't called anywhere; I was going to delete it, but hmm, I wonder
if it's actually a missing call and leaking (in the unlikely case
the device was ever removed).

It was added by your:
  commit f88fc122cc34c2545dec9562eaab121494e401ef
  Author: Boris Brezillon <bbrezillon@kernel.org>
  Date:   Thu Mar 16 09:02:40 2017 +0100

    mtd: nand: Cleanup/rework the atmel_nand driver

and I see the allocation in:
     user = kzalloc(size, GFP_KERNEL);
       in
     nand->pmecc = atmel_pmecc_create_user(nc->pmecc, &req);
       called in atmel_nand_pmecc_init
         from atmel_nand_ecc_init
           from atmel_hsmc_nand_ecc_init
 
But I don't see any freeing.

(I don't knowingly have hardware to test a fix, although I guess
there's probably one somewhere....)

Suggestions?

Thanks,

Dave
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: boris.brezillon@collabora.com
Cc: richard@nod.at, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com,
	linux-arm-kernel@lists.infradead.org
Subject: of atmel_pmecc_destroy_user
Date: Sun, 29 Sep 2024 17:05:01 +0000	[thread overview]
Message-ID: <ZvmIvRJCf6VhHvpo@gallifrey> (raw)

Hi Boris and co,
  One of my scripts noticed that 'atmel_pmecc_destroy_user'
isn't called anywhere; I was going to delete it, but hmm, I wonder
if it's actually a missing call and leaking (in the unlikely case
the device was ever removed).

It was added by your:
  commit f88fc122cc34c2545dec9562eaab121494e401ef
  Author: Boris Brezillon <bbrezillon@kernel.org>
  Date:   Thu Mar 16 09:02:40 2017 +0100

    mtd: nand: Cleanup/rework the atmel_nand driver

and I see the allocation in:
     user = kzalloc(size, GFP_KERNEL);
       in
     nand->pmecc = atmel_pmecc_create_user(nc->pmecc, &req);
       called in atmel_nand_pmecc_init
         from atmel_nand_ecc_init
           from atmel_hsmc_nand_ecc_init
 
But I don't see any freeing.

(I don't knowingly have hardware to test a fix, although I guess
there's probably one somewhere....)

Suggestions?

Thanks,

Dave
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/


WARNING: multiple messages have this Message-ID (diff)
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: boris.brezillon@collabora.com
Cc: nicolas.ferre@microchip.com, miquel.raynal@bootlin.com,
	richard@nod.at, linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: of atmel_pmecc_destroy_user
Date: Sun, 29 Sep 2024 17:05:01 +0000	[thread overview]
Message-ID: <ZvmIvRJCf6VhHvpo@gallifrey> (raw)

Hi Boris and co,
  One of my scripts noticed that 'atmel_pmecc_destroy_user'
isn't called anywhere; I was going to delete it, but hmm, I wonder
if it's actually a missing call and leaking (in the unlikely case
the device was ever removed).

It was added by your:
  commit f88fc122cc34c2545dec9562eaab121494e401ef
  Author: Boris Brezillon <bbrezillon@kernel.org>
  Date:   Thu Mar 16 09:02:40 2017 +0100

    mtd: nand: Cleanup/rework the atmel_nand driver

and I see the allocation in:
     user = kzalloc(size, GFP_KERNEL);
       in
     nand->pmecc = atmel_pmecc_create_user(nc->pmecc, &req);
       called in atmel_nand_pmecc_init
         from atmel_nand_ecc_init
           from atmel_hsmc_nand_ecc_init
 
But I don't see any freeing.

(I don't knowingly have hardware to test a fix, although I guess
there's probably one somewhere....)

Suggestions?

Thanks,

Dave
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

             reply	other threads:[~2024-09-29 17:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-29 17:05 Dr. David Alan Gilbert [this message]
2024-09-29 17:05 ` of atmel_pmecc_destroy_user Dr. David Alan Gilbert
2024-09-29 17:05 ` Dr. David Alan Gilbert
2024-09-30  7:08 ` Boris Brezillon
2024-09-30  7:08   ` Boris Brezillon
2024-09-30  7:08   ` Boris Brezillon
2024-10-01 20:37   ` Dr. David Alan Gilbert
2024-10-01 20:37     ` Dr. David Alan Gilbert
2024-10-01 20:37     ` Dr. David Alan Gilbert
2024-10-01 20:41     ` Miquel Raynal
2024-10-01 20:41       ` Miquel Raynal
2024-10-01 20:41       ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZvmIvRJCf6VhHvpo@gallifrey \
    --to=linux@treblig.org \
    --cc=boris.brezillon@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.