Re: [PATCH v3 1/2] iommu/arm-smmu-v3: Print better events records

[Nicolin Chen <nicolinc@nvidia.com>]

On Tue, Oct 01, 2024 at 08:52:57PM +0000, Pranjal Shrivastava wrote:
> > > +static void arm_smmu_dump_raw_event(struct arm_smmu_device *smmu,
> > > +                                   struct arm_smmu_event *event)
> > > +{
> > > +       int i;
> > > +
> > > +       dev_err(smmu->dev, "event 0x%02x received: master %s:\n",
> > > +               event->id, event->master_name);
> > > +
> > > +       for (i = 0; i < EVTQ_ENT_DWORDS; ++i)
> > > +               dev_err(smmu->dev, "\t0x%016llx\n",
> > > +                        (unsigned long long)event->raw[i]);
> >
> > Though I know that is what we have been doing in the driver, I
> > wonder if we have to cast from u64 to ull?
> >
> 
> I think we can do that?

I think so.

> Are we avoiding potential compiler troubles?

I assume so. But I am not sure what's the back story.

> > > +                               event->s2 ? "S2|" : "S1|", class_str[event->class],
> >
> > The previous flags have spaces: " Inst |", " Read |". So, maybe:
> >                        " S2 |" and " S1 |" here?
> >
> 
> Ack. I'm guessing even in the worst case we'd get to 78 chars so adding
> a space should be fine?

Well, if we want to manage the length. Perhaps printing them with
no space at all could be a choice too. Just, if we ever add space,
we'd better keep the consistency.

Thanks
Nicolin