Re: [PATCH v3 2/2] iommu/arm-smmu-v3: Adopt arm_smmu_event in handlers

[Pranjal Shrivastava <praan@google.com>]

On Thu, Oct 03, 2024 at 03:53:15PM -0700, Nicolin Chen wrote:
> On Thu, Oct 03, 2024 at 09:34:35PM +0000, Pranjal Shrivastava wrote:
> > > The master and master_name are not that necessary to be in the
> > > arm_smmu_event. I would keep both of them as local variables in
> > > arm_smmu_handle_evt and pass master_name in to dump().
> > 
> > Hmm, right or maybe ONLY have the master_name in arm_smmu_event?
> 
> Just move both out of arm_smmu_event. Keep the master_name as a
> local variable like the "master". You'd just need to pass it in
> to the dump(). They both are in that same handle_evt().
> 

Ack.

> > > > Also, shall we rename it to `arm_smmu_read_evt_info` ?
> > >
> > > I'd probably use arm_smmu_event_get_from_raw()? Trying to high-
> > > light struct arm_smmu_event v.s. u64 evt[EVTQ_ENT_DWORDS]. Yet,
> > > no strong feeling about that.
> > >
> > 
> > Ack. How about `read_arm_smmu_event` :)
> > Unless, we wanna follow the arm_smmu_<func> convention?
> 
> I think it'd be nicer if we do.
> 

Ack. `arm_smmu_get_evt_from_raw` it is!

> Nicolin
Thanks,
Pranjal