From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Tang Yizhou <yizhou.tang@shopee.com>,
jack@suse.cz, hch@infradead.org, willy@infradead.org,
akpm@linux-foundation.org, chandan.babu@oracle.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2 3/3] xfs: Let the max iomap length be consistent with the writeback code
Date: Mon, 7 Oct 2024 23:35:04 -0700 [thread overview]
Message-ID: <ZwTSmHM4o8Gg5NRW@infradead.org> (raw)
In-Reply-To: <ZwRUQvq4wqfL8rBd@dread.disaster.area>
On Tue, Oct 08, 2024 at 08:36:02AM +1100, Dave Chinner wrote:
> I think this map size limiting is completely unnecessary for
> buffered writeback - buffered writes are throttled against writeback
> by balance_dirty_pages(), not by extent allocation size. The size of
> the delayed allocation or the overwrite map is largely irrelevant -
> we're going to map the entire range during a write, do it just
> doesn't matter what size the mapping is...
Yes. This goes back all the way to your original iomap prototype,
but even back then balance_dirty_pages should have done all the
work.
next prev parent reply other threads:[~2024-10-08 6:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-06 15:28 [PATCH v2 0/3] Cleanup some writeback codes Tang Yizhou
2024-10-06 15:28 ` [PATCH v2 1/3] mm/page-writeback.c: Rename BANDWIDTH_INTERVAL to BW_DIRTYLIMIT_INTERVAL Tang Yizhou
2024-10-06 15:28 ` [PATCH v2 2/3] mm/page-writeback.c: Fix comment of wb_domain_writeout_add() Tang Yizhou
2024-10-06 15:28 ` [PATCH v2 3/3] xfs: Let the max iomap length be consistent with the writeback code Tang Yizhou
2024-10-06 16:30 ` Darrick J. Wong
2024-10-07 5:36 ` Tang Yizhou
2024-10-07 16:36 ` Jan Kara
2024-10-07 17:52 ` Darrick J. Wong
2024-10-07 21:36 ` Dave Chinner
2024-10-08 6:35 ` Christoph Hellwig [this message]
2024-10-09 7:24 ` kernel test robot
2024-10-09 8:26 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwTSmHM4o8Gg5NRW@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=chandan.babu@oracle.com \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
--cc=yizhou.tang@shopee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.