All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Damato <jdamato@fastly.com>
To: netdev@vger.kernel.org
Cc: mkarsten@uwaterloo.ca, skhawaja@google.com, sdf@fomichev.me,
	bjorn@rivosinc.com, amritha.nambiar@intel.com,
	sridhar.samudrala@intel.com, willemdebruijn.kernel@gmail.com,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>, Jiri Pirko <jiri@resnulli.us>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	Johannes Berg <johannes.berg@intel.com>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC net-next v4 5/9] net: napi: Add napi_config
Date: Tue, 8 Oct 2024 11:19:24 -0700	[thread overview]
Message-ID: <ZwV3rOFhsEyVoNtR@LQ3V64L9R2> (raw)
In-Reply-To: <20241001235302.57609-6-jdamato@fastly.com>

On Tue, Oct 01, 2024 at 11:52:36PM +0000, Joe Damato wrote:
> Add a persistent NAPI config area for NAPI configuration to the core.
> Drivers opt-in to setting the persistent config for a NAPI by passing an
> index when calling netif_napi_add_config.
> 
> napi_config is allocated in alloc_netdev_mqs, freed in free_netdev
> (after the NAPIs are deleted).
> 
> Drivers which call netif_napi_add_config will have persistent per-NAPI
> settings: NAPI IDs, gro_flush_timeout, and defer_hard_irq settings.
> 
> Per-NAPI settings are saved in napi_disable and restored in napi_enable.
> 
> Co-developed-by: Martin Karsten <mkarsten@uwaterloo.ca>
> Signed-off-by: Martin Karsten <mkarsten@uwaterloo.ca>
> Signed-off-by: Joe Damato <jdamato@fastly.com>
> ---
>  .../networking/net_cachelines/net_device.rst  |  1 +
>  include/linux/netdevice.h                     | 32 ++++++++
>  net/core/dev.c                                | 79 +++++++++++++++++--
>  net/core/dev.h                                | 14 ++++
>  4 files changed, 119 insertions(+), 7 deletions(-)

[...]
  
> +/**
> + * netif_napi_add_config - initialize a NAPI context with persistent config
> + * @dev: network device
> + * @napi: NAPI context
> + * @poll: polling function
> + * @weight: the poll weight of this NAPI

For anyone following along, I noticed this unnecessary bit of kdoc
left in from a previous revision and will remove it when submitting
v5.

  parent reply	other threads:[~2024-10-08 18:19 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-01 23:52 [Intel-wired-lan] [RFC net-next v4 0/9] Add support for per-NAPI config via netlink Joe Damato
2024-10-01 23:52 ` Joe Damato
2024-10-01 23:52 ` [RFC net-next v4 1/9] net: napi: Make napi_defer_hard_irqs per-NAPI Joe Damato
2024-10-08 22:08   ` Jakub Kicinski
2024-10-01 23:52 ` [RFC net-next v4 2/9] netdev-genl: Dump napi_defer_hard_irqs Joe Damato
2024-10-01 23:52 ` [Intel-wired-lan] [RFC net-next v4 3/9] net: napi: Make gro_flush_timeout per-NAPI Joe Damato
2024-10-01 23:52   ` Joe Damato
2024-10-08 18:22   ` [Intel-wired-lan] " Joe Damato
2024-10-08 18:22     ` Joe Damato
2024-10-08 22:10   ` [Intel-wired-lan] " Jakub Kicinski
2024-10-08 22:10     ` Jakub Kicinski
2024-10-01 23:52 ` [RFC net-next v4 4/9] netdev-genl: Dump gro_flush_timeout Joe Damato
2024-10-01 23:52 ` [RFC net-next v4 5/9] net: napi: Add napi_config Joe Damato
2024-10-05  6:33   ` kernel test robot
2024-10-05  9:50   ` kernel test robot
2024-10-08 18:19   ` Joe Damato [this message]
2024-10-08 22:17   ` Jakub Kicinski
2024-10-08 22:28     ` Joe Damato
2024-10-01 23:52 ` [RFC net-next v4 6/9] netdev-genl: Support setting per-NAPI config values Joe Damato
2024-10-08 18:20   ` Joe Damato
2024-10-08 22:19     ` Jakub Kicinski
2024-10-08 23:00       ` Joe Damato
2024-10-08 23:19         ` Jakub Kicinski
2024-10-08 23:57           ` Joe Damato
2024-10-01 23:52 ` [RFC net-next v4 7/9] bnxt: Add support for persistent NAPI config Joe Damato
2024-10-01 23:52 ` [RFC net-next v4 8/9] mlx5: " Joe Damato
2024-10-01 23:52 ` [RFC net-next v4 9/9] mlx4: Add support for persistent NAPI config to RX CQs Joe Damato
2024-10-03 23:29 ` [Intel-wired-lan] [RFC net-next v4 0/9] Add support for per-NAPI config via netlink Stanislav Fomichev
2024-10-03 23:29   ` Stanislav Fomichev
2024-10-03 23:53   ` [Intel-wired-lan] " Joe Damato
2024-10-03 23:53     ` Joe Damato
2024-10-04  2:33     ` [Intel-wired-lan] " Joe Damato
2024-10-04  2:33       ` Joe Damato
2024-10-04 16:22       ` [Intel-wired-lan] " Stanislav Fomichev
2024-10-04 16:22         ` Stanislav Fomichev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZwV3rOFhsEyVoNtR@LQ3V64L9R2 \
    --to=jdamato@fastly.com \
    --cc=amritha.nambiar@intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=bjorn@rivosinc.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jiri@resnulli.us \
    --cc=johannes.berg@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=mkarsten@uwaterloo.ca \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    --cc=skhawaja@google.com \
    --cc=sridhar.samudrala@intel.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.