All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/cdclk: Check cdclk value before division
@ 2024-10-09  8:46 Suraj Kandpal
  2024-10-09  9:01 ` Ville Syrjälä
                   ` (10 more replies)
  0 siblings, 11 replies; 13+ messages in thread
From: Suraj Kandpal @ 2024-10-09  8:46 UTC (permalink / raw)
  To: intel-xe, intel-gfx; +Cc: uma.shankar, chaitanya.kumar.borah, Suraj Kandpal

Check cdclk value to avoid a divide by zero error. Since
bxt_cdclk_init_hw has cdclk can end up being 0 and then
we have a call to bxt_set_cdclk where we may end up dividing
this value by 0.

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
index fa1c2012b10c..a5acc70fb87c 100644
--- a/drivers/gpu/drm/i915/display/intel_cdclk.c
+++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
@@ -1921,7 +1921,7 @@ static u32 xe2lpd_mdclk_source_sel(struct intel_display *display)
 int intel_mdclk_cdclk_ratio(struct intel_display *display,
 			    const struct intel_cdclk_config *cdclk_config)
 {
-	if (mdclk_source_is_cdclk_pll(display))
+	if (mdclk_source_is_cdclk_pll(display) && cdclk_config->cdclk)
 		return DIV_ROUND_UP(cdclk_config->vco, cdclk_config->cdclk);
 
 	/* Otherwise, source for MDCLK is CD2XCLK. */
-- 
2.43.2


^ permalink raw reply related	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2024-10-10 11:45 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-09  8:46 [PATCH] drm/i915/cdclk: Check cdclk value before division Suraj Kandpal
2024-10-09  9:01 ` Ville Syrjälä
2024-10-09  9:25   ` Kandpal, Suraj
2024-10-09 10:10 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-10-09 11:34 ` ✓ CI.Patch_applied: " Patchwork
2024-10-09 11:34 ` ✓ CI.checkpatch: " Patchwork
2024-10-09 11:36 ` ✓ CI.KUnit: " Patchwork
2024-10-09 11:48 ` ✓ CI.Build: " Patchwork
2024-10-09 11:50 ` ✓ CI.Hooks: " Patchwork
2024-10-09 11:52 ` ✗ CI.checksparse: warning " Patchwork
2024-10-09 12:12 ` ✓ CI.BAT: success " Patchwork
2024-10-09 18:44 ` ✗ CI.FULL: failure " Patchwork
2024-10-10 11:45 ` ✗ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.