From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tyrone Ting <warp5tw@gmail.com>
Cc: avifishman70@gmail.com, tmaimon77@gmail.com,
tali.perry1@gmail.com, venture@google.com, yuenn@google.com,
benjaminfair@google.com, andi.shyti@kernel.org, wsa@kernel.org,
rand.sec96@gmail.com, wsa+renesas@sang-engineering.com,
tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com,
tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com,
kfting@nuvoton.com, openbmc@lists.ozlabs.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/4] i2c: npcm: Modify the client address assignment
Date: Fri, 11 Oct 2024 16:58:28 +0300 [thread overview]
Message-ID: <ZwkvBFHS1m3N2yoW@smile.fi.intel.com> (raw)
In-Reply-To: <CACD3sJY_79_VTe1EHPdh-1+FCBwb2KCW_N19==TMHAsrFL-rzg@mail.gmail.com>
On Fri, Oct 11, 2024 at 09:44:42PM +0800, Tyrone Ting wrote:
> > On Fri, Oct 11, 2024 at 01:52:29PM +0800, Tyrone Ting wrote:
...
> > > + if (bus->dest_addr & I2C_M_RD)
> >
> > Redundant.
>
> Just to double check. Is the code "if (bus->dest_addr & I2C_M_RD)" redundant?
Yes.
> > > + bus->dest_addr &= ~I2C_M_RD;
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tyrone Ting <warp5tw@gmail.com>
Cc: KWLIU@nuvoton.com, tomer.maimon@nuvoton.com,
linux-kernel@vger.kernel.org, benjaminfair@google.com,
wsa+renesas@sang-engineering.com, avifishman70@gmail.com,
venture@google.com, openbmc@lists.ozlabs.org, kfting@nuvoton.com,
JJLIU0@nuvoton.com, tali.perry@nuvoton.com,
tali.perry1@gmail.com, wsa@kernel.org, andi.shyti@kernel.org,
linux-i2c@vger.kernel.org, Avi.Fishman@nuvoton.com,
rand.sec96@gmail.com, tmaimon77@gmail.com
Subject: Re: [PATCH v6 2/4] i2c: npcm: Modify the client address assignment
Date: Fri, 11 Oct 2024 16:58:28 +0300 [thread overview]
Message-ID: <ZwkvBFHS1m3N2yoW@smile.fi.intel.com> (raw)
In-Reply-To: <CACD3sJY_79_VTe1EHPdh-1+FCBwb2KCW_N19==TMHAsrFL-rzg@mail.gmail.com>
On Fri, Oct 11, 2024 at 09:44:42PM +0800, Tyrone Ting wrote:
> > On Fri, Oct 11, 2024 at 01:52:29PM +0800, Tyrone Ting wrote:
...
> > > + if (bus->dest_addr & I2C_M_RD)
> >
> > Redundant.
>
> Just to double check. Is the code "if (bus->dest_addr & I2C_M_RD)" redundant?
Yes.
> > > + bus->dest_addr &= ~I2C_M_RD;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-10-11 13:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 5:52 [PATCH v6 0/4] i2c: npcm: read/write operation, checkpatch Tyrone Ting
2024-10-11 5:52 ` [PATCH v6 1/4] i2c: npcm: Modify timeout evaluation mechanism Tyrone Ting
2024-10-11 5:52 ` [PATCH v6 2/4] i2c: npcm: Modify the client address assignment Tyrone Ting
2024-10-11 11:00 ` Andy Shevchenko
2024-10-11 11:00 ` Andy Shevchenko
2024-10-11 13:44 ` Tyrone Ting
2024-10-11 13:44 ` Tyrone Ting
2024-10-11 13:58 ` Andy Shevchenko [this message]
2024-10-11 13:58 ` Andy Shevchenko
2024-10-11 14:10 ` Tyrone Ting
2024-10-11 14:10 ` Tyrone Ting
2024-10-11 5:52 ` [PATCH v6 3/4] i2c: npcm: use i2c frequency table Tyrone Ting
2024-10-11 5:52 ` [PATCH v6 4/4] i2c: npcm: Enable slave in eob interrupt Tyrone Ting
2024-10-11 5:52 ` Tyrone Ting
2024-10-11 11:02 ` Andy Shevchenko
2024-10-11 11:02 ` Andy Shevchenko
2024-10-14 7:55 ` Tyrone Ting
2024-10-14 7:55 ` Tyrone Ting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwkvBFHS1m3N2yoW@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Avi.Fishman@nuvoton.com \
--cc=JJLIU0@nuvoton.com \
--cc=KWLIU@nuvoton.com \
--cc=andi.shyti@kernel.org \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=kfting@nuvoton.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=rand.sec96@gmail.com \
--cc=tali.perry1@gmail.com \
--cc=tali.perry@nuvoton.com \
--cc=tmaimon77@gmail.com \
--cc=tomer.maimon@nuvoton.com \
--cc=venture@google.com \
--cc=warp5tw@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.