From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com
Cc: x86@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/boot: Remove unused function 'atou'
Date: Sun, 13 Oct 2024 13:46:25 +0000 [thread overview]
Message-ID: <ZwvPMYWYfVFMonDL@gallifrey> (raw)
In-Reply-To: <20240913005753.1392431-1-linux@treblig.org>
* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> I can't find any sign of 'atou' having been used.
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Ping
Dave
> ---
> arch/x86/boot/boot.h | 1 -
> arch/x86/boot/string.c | 8 --------
> arch/x86/boot/string.h | 1 -
> 3 files changed, 10 deletions(-)
>
> diff --git a/arch/x86/boot/boot.h b/arch/x86/boot/boot.h
> index 148ba5c5106e..0f24f7ebec9b 100644
> --- a/arch/x86/boot/boot.h
> +++ b/arch/x86/boot/boot.h
> @@ -305,7 +305,6 @@ void initregs(struct biosregs *regs);
> int strcmp(const char *str1, const char *str2);
> int strncmp(const char *cs, const char *ct, size_t count);
> size_t strnlen(const char *s, size_t maxlen);
> -unsigned int atou(const char *s);
> unsigned long long simple_strtoull(const char *cp, char **endp, unsigned int base);
> size_t strlen(const char *s);
> char *strchr(const char *s, int c);
> diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c
> index c23f3b9c84fe..84f7a883ce1e 100644
> --- a/arch/x86/boot/string.c
> +++ b/arch/x86/boot/string.c
> @@ -88,14 +88,6 @@ size_t strnlen(const char *s, size_t maxlen)
> return (es - s);
> }
>
> -unsigned int atou(const char *s)
> -{
> - unsigned int i = 0;
> - while (isdigit(*s))
> - i = i * 10 + (*s++ - '0');
> - return i;
> -}
> -
> /* Works only for digits and letters, but small and fast */
> #define TOLOWER(x) ((x) | 0x20)
>
> diff --git a/arch/x86/boot/string.h b/arch/x86/boot/string.h
> index e5d2c6b8c2f1..a5b05ebc037d 100644
> --- a/arch/x86/boot/string.h
> +++ b/arch/x86/boot/string.h
> @@ -24,7 +24,6 @@ extern size_t strlen(const char *s);
> extern char *strstr(const char *s1, const char *s2);
> extern char *strchr(const char *s, int c);
> extern size_t strnlen(const char *s, size_t maxlen);
> -extern unsigned int atou(const char *s);
> extern unsigned long long simple_strtoull(const char *cp, char **endp,
> unsigned int base);
> long simple_strtol(const char *cp, char **endp, unsigned int base);
> --
> 2.46.0
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
next prev parent reply other threads:[~2024-10-13 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 0:57 [PATCH] x86/boot: Remove unused function 'atou' linux
2024-10-13 13:46 ` Dr. David Alan Gilbert [this message]
2024-11-07 17:23 ` [tip: x86/cleanups] x86/boot: Remove unused function atou() tip-bot2 for Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwvPMYWYfVFMonDL@gallifrey \
--to=linux@treblig.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.