* [PATCH] x86/boot: Remove unused function 'atou'
@ 2024-09-13 0:57 linux
2024-10-13 13:46 ` Dr. David Alan Gilbert
2024-11-07 17:23 ` [tip: x86/cleanups] x86/boot: Remove unused function atou() tip-bot2 for Dr. David Alan Gilbert
0 siblings, 2 replies; 3+ messages in thread
From: linux @ 2024-09-13 0:57 UTC (permalink / raw)
To: tglx, mingo, bp, dave.hansen
Cc: x86, hpa, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
I can't find any sign of 'atou' having been used.
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
arch/x86/boot/boot.h | 1 -
arch/x86/boot/string.c | 8 --------
arch/x86/boot/string.h | 1 -
3 files changed, 10 deletions(-)
diff --git a/arch/x86/boot/boot.h b/arch/x86/boot/boot.h
index 148ba5c5106e..0f24f7ebec9b 100644
--- a/arch/x86/boot/boot.h
+++ b/arch/x86/boot/boot.h
@@ -305,7 +305,6 @@ void initregs(struct biosregs *regs);
int strcmp(const char *str1, const char *str2);
int strncmp(const char *cs, const char *ct, size_t count);
size_t strnlen(const char *s, size_t maxlen);
-unsigned int atou(const char *s);
unsigned long long simple_strtoull(const char *cp, char **endp, unsigned int base);
size_t strlen(const char *s);
char *strchr(const char *s, int c);
diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c
index c23f3b9c84fe..84f7a883ce1e 100644
--- a/arch/x86/boot/string.c
+++ b/arch/x86/boot/string.c
@@ -88,14 +88,6 @@ size_t strnlen(const char *s, size_t maxlen)
return (es - s);
}
-unsigned int atou(const char *s)
-{
- unsigned int i = 0;
- while (isdigit(*s))
- i = i * 10 + (*s++ - '0');
- return i;
-}
-
/* Works only for digits and letters, but small and fast */
#define TOLOWER(x) ((x) | 0x20)
diff --git a/arch/x86/boot/string.h b/arch/x86/boot/string.h
index e5d2c6b8c2f1..a5b05ebc037d 100644
--- a/arch/x86/boot/string.h
+++ b/arch/x86/boot/string.h
@@ -24,7 +24,6 @@ extern size_t strlen(const char *s);
extern char *strstr(const char *s1, const char *s2);
extern char *strchr(const char *s, int c);
extern size_t strnlen(const char *s, size_t maxlen);
-extern unsigned int atou(const char *s);
extern unsigned long long simple_strtoull(const char *cp, char **endp,
unsigned int base);
long simple_strtol(const char *cp, char **endp, unsigned int base);
--
2.46.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] x86/boot: Remove unused function 'atou'
2024-09-13 0:57 [PATCH] x86/boot: Remove unused function 'atou' linux
@ 2024-10-13 13:46 ` Dr. David Alan Gilbert
2024-11-07 17:23 ` [tip: x86/cleanups] x86/boot: Remove unused function atou() tip-bot2 for Dr. David Alan Gilbert
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2024-10-13 13:46 UTC (permalink / raw)
To: tglx, mingo, bp, dave.hansen; +Cc: x86, hpa, linux-kernel
* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> I can't find any sign of 'atou' having been used.
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Ping
Dave
> ---
> arch/x86/boot/boot.h | 1 -
> arch/x86/boot/string.c | 8 --------
> arch/x86/boot/string.h | 1 -
> 3 files changed, 10 deletions(-)
>
> diff --git a/arch/x86/boot/boot.h b/arch/x86/boot/boot.h
> index 148ba5c5106e..0f24f7ebec9b 100644
> --- a/arch/x86/boot/boot.h
> +++ b/arch/x86/boot/boot.h
> @@ -305,7 +305,6 @@ void initregs(struct biosregs *regs);
> int strcmp(const char *str1, const char *str2);
> int strncmp(const char *cs, const char *ct, size_t count);
> size_t strnlen(const char *s, size_t maxlen);
> -unsigned int atou(const char *s);
> unsigned long long simple_strtoull(const char *cp, char **endp, unsigned int base);
> size_t strlen(const char *s);
> char *strchr(const char *s, int c);
> diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c
> index c23f3b9c84fe..84f7a883ce1e 100644
> --- a/arch/x86/boot/string.c
> +++ b/arch/x86/boot/string.c
> @@ -88,14 +88,6 @@ size_t strnlen(const char *s, size_t maxlen)
> return (es - s);
> }
>
> -unsigned int atou(const char *s)
> -{
> - unsigned int i = 0;
> - while (isdigit(*s))
> - i = i * 10 + (*s++ - '0');
> - return i;
> -}
> -
> /* Works only for digits and letters, but small and fast */
> #define TOLOWER(x) ((x) | 0x20)
>
> diff --git a/arch/x86/boot/string.h b/arch/x86/boot/string.h
> index e5d2c6b8c2f1..a5b05ebc037d 100644
> --- a/arch/x86/boot/string.h
> +++ b/arch/x86/boot/string.h
> @@ -24,7 +24,6 @@ extern size_t strlen(const char *s);
> extern char *strstr(const char *s1, const char *s2);
> extern char *strchr(const char *s, int c);
> extern size_t strnlen(const char *s, size_t maxlen);
> -extern unsigned int atou(const char *s);
> extern unsigned long long simple_strtoull(const char *cp, char **endp,
> unsigned int base);
> long simple_strtol(const char *cp, char **endp, unsigned int base);
> --
> 2.46.0
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip: x86/cleanups] x86/boot: Remove unused function atou()
2024-09-13 0:57 [PATCH] x86/boot: Remove unused function 'atou' linux
2024-10-13 13:46 ` Dr. David Alan Gilbert
@ 2024-11-07 17:23 ` tip-bot2 for Dr. David Alan Gilbert
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Dr. David Alan Gilbert @ 2024-11-07 17:23 UTC (permalink / raw)
To: linux-tip-commits
Cc: Dr. David Alan Gilbert, Borislav Petkov (AMD), x86, linux-kernel
The following commit has been merged into the x86/cleanups branch of tip:
Commit-ID: 97ecb260d9c19aa044871ae2c89408c340717b61
Gitweb: https://git.kernel.org/tip/97ecb260d9c19aa044871ae2c89408c340717b61
Author: Dr. David Alan Gilbert <linux@treblig.org>
AuthorDate: Fri, 13 Sep 2024 01:57:53 +01:00
Committer: Borislav Petkov (AMD) <bp@alien8.de>
CommitterDate: Thu, 07 Nov 2024 18:08:23 +01:00
x86/boot: Remove unused function atou()
I can't find any sign of atou() having been used. Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/20240913005753.1392431-1-linux@treblig.org
---
arch/x86/boot/boot.h | 1 -
arch/x86/boot/string.c | 8 --------
arch/x86/boot/string.h | 1 -
3 files changed, 10 deletions(-)
diff --git a/arch/x86/boot/boot.h b/arch/x86/boot/boot.h
index 148ba5c..0f24f7e 100644
--- a/arch/x86/boot/boot.h
+++ b/arch/x86/boot/boot.h
@@ -305,7 +305,6 @@ void initregs(struct biosregs *regs);
int strcmp(const char *str1, const char *str2);
int strncmp(const char *cs, const char *ct, size_t count);
size_t strnlen(const char *s, size_t maxlen);
-unsigned int atou(const char *s);
unsigned long long simple_strtoull(const char *cp, char **endp, unsigned int base);
size_t strlen(const char *s);
char *strchr(const char *s, int c);
diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c
index c23f3b9..84f7a88 100644
--- a/arch/x86/boot/string.c
+++ b/arch/x86/boot/string.c
@@ -88,14 +88,6 @@ size_t strnlen(const char *s, size_t maxlen)
return (es - s);
}
-unsigned int atou(const char *s)
-{
- unsigned int i = 0;
- while (isdigit(*s))
- i = i * 10 + (*s++ - '0');
- return i;
-}
-
/* Works only for digits and letters, but small and fast */
#define TOLOWER(x) ((x) | 0x20)
diff --git a/arch/x86/boot/string.h b/arch/x86/boot/string.h
index e5d2c6b..a5b05eb 100644
--- a/arch/x86/boot/string.h
+++ b/arch/x86/boot/string.h
@@ -24,7 +24,6 @@ extern size_t strlen(const char *s);
extern char *strstr(const char *s1, const char *s2);
extern char *strchr(const char *s, int c);
extern size_t strnlen(const char *s, size_t maxlen);
-extern unsigned int atou(const char *s);
extern unsigned long long simple_strtoull(const char *cp, char **endp,
unsigned int base);
long simple_strtol(const char *cp, char **endp, unsigned int base);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-07 17:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-13 0:57 [PATCH] x86/boot: Remove unused function 'atou' linux
2024-10-13 13:46 ` Dr. David Alan Gilbert
2024-11-07 17:23 ` [tip: x86/cleanups] x86/boot: Remove unused function atou() tip-bot2 for Dr. David Alan Gilbert
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.