* [PATCH] efi_loader: Mark efi_bootmgr_release_uridp as static
@ 2024-10-26 7:37 Ilias Apalodimas
2024-10-26 7:44 ` Heinrich Schuchardt
2024-10-28 7:53 ` Andy Shevchenko
0 siblings, 2 replies; 3+ messages in thread
From: Ilias Apalodimas @ 2024-10-26 7:37 UTC (permalink / raw)
To: xypron.glpk
Cc: Ilias Apalodimas, Andy Shevchenko, Tom Rini, Masahisa Kojima,
Simon Glass, AKASHI Takahiro, u-boot
This is only used locally so make it static
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
lib/efi_loader/efi_bootmgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/efi_loader/efi_bootmgr.c b/lib/efi_loader/efi_bootmgr.c
index a3aa2b8d1b92..f9b5988a06ea 100644
--- a/lib/efi_loader/efi_bootmgr.c
+++ b/lib/efi_loader/efi_bootmgr.c
@@ -385,7 +385,7 @@ err:
* @ctx: event context
* Return: status code
*/
-efi_status_t efi_bootmgr_release_uridp(struct uridp_context *ctx)
+static efi_status_t efi_bootmgr_release_uridp(struct uridp_context *ctx)
{
efi_status_t ret = EFI_SUCCESS;
efi_status_t ret2 = EFI_SUCCESS;
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] efi_loader: Mark efi_bootmgr_release_uridp as static
2024-10-26 7:37 [PATCH] efi_loader: Mark efi_bootmgr_release_uridp as static Ilias Apalodimas
@ 2024-10-26 7:44 ` Heinrich Schuchardt
2024-10-28 7:53 ` Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2024-10-26 7:44 UTC (permalink / raw)
To: Ilias Apalodimas
Cc: Andy Shevchenko, Tom Rini, Masahisa Kojima, Simon Glass,
AKASHI Takahiro, u-boot
On 10/26/24 09:37, Ilias Apalodimas wrote:
> This is only used locally so make it static
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> ---
> lib/efi_loader/efi_bootmgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/efi_loader/efi_bootmgr.c b/lib/efi_loader/efi_bootmgr.c
> index a3aa2b8d1b92..f9b5988a06ea 100644
> --- a/lib/efi_loader/efi_bootmgr.c
> +++ b/lib/efi_loader/efi_bootmgr.c
> @@ -385,7 +385,7 @@ err:
> * @ctx: event context
> * Return: status code
> */
> -efi_status_t efi_bootmgr_release_uridp(struct uridp_context *ctx)
> +static efi_status_t efi_bootmgr_release_uridp(struct uridp_context *ctx)
> {
> efi_status_t ret = EFI_SUCCESS;
> efi_status_t ret2 = EFI_SUCCESS;
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] efi_loader: Mark efi_bootmgr_release_uridp as static
2024-10-26 7:37 [PATCH] efi_loader: Mark efi_bootmgr_release_uridp as static Ilias Apalodimas
2024-10-26 7:44 ` Heinrich Schuchardt
@ 2024-10-28 7:53 ` Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2024-10-28 7:53 UTC (permalink / raw)
To: Ilias Apalodimas
Cc: xypron.glpk, Tom Rini, Masahisa Kojima, Simon Glass,
AKASHI Takahiro, u-boot
On Sat, Oct 26, 2024 at 10:37:32AM +0300, Ilias Apalodimas wrote:
> This is only used locally so make it static
Missing period at the end.
Otherwise LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-28 7:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-26 7:37 [PATCH] efi_loader: Mark efi_bootmgr_release_uridp as static Ilias Apalodimas
2024-10-26 7:44 ` Heinrich Schuchardt
2024-10-28 7:53 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.