From: Xu Yilun <yilun.xu@linux.intel.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: iansdannapel@gmail.com, mdf@kernel.org, hao.wu@intel.com,
yilun.xu@intel.com, trix@redhat.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
neil.armstrong@linaro.org, heiko.stuebner@cherry.de,
rafal@milecki.pl, linus.walleij@linaro.org,
linux-fpga@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] fpga: Add Efinix Trion & Titanium serial SPI programming driver
Date: Fri, 18 Oct 2024 09:22:22 +0800 [thread overview]
Message-ID: <ZxG4TiP4tliF/bms@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <c292b99c-3d51-461e-aadb-cd21ed972db0@kernel.org>
> > +static int efinix_spi_apply_clk_cycles(struct efinix_spi_conf *conf)
> > +{
> > + char data[13] = {0};
> > +
> > + return spi_write(conf->spi, data, sizeof(data));
>
> Hm, aren't buffers from stack discouraged? spi-summary explicitly
> mentions this case or I am getting this wrong?
You are right. And there were already some fixes for this issue in FPGA. E.g.
https://lore.kernel.org/all/20221230092922.18822-2-i.bornyakov@metrotek.ru/
Thanks,
Yilun
next prev parent reply other threads:[~2024-10-18 1:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 14:14 [PATCH 1/3] fpga: Add Efinix Trion & Titanium serial SPI programming driver iansdannapel
2024-09-27 14:14 ` [PATCH 2/3] dt-bindings: fpga: Add Efinix serial SPI programming bindings iansdannapel
2024-09-27 14:26 ` Krzysztof Kozlowski
2024-09-27 15:34 ` Ian Dannapel
2024-09-28 7:31 ` Krzysztof Kozlowski
2024-09-28 12:33 ` Ian Dannapel
2024-09-28 12:53 ` Krzysztof Kozlowski
2024-09-28 14:26 ` Ian Dannapel
2024-09-29 19:49 ` Krzysztof Kozlowski
2024-09-27 14:14 ` [PATCH 3/3] dt-bindings: vendor-prefix: Add prefix for Efinix, Inc iansdannapel
2024-09-27 14:26 ` Krzysztof Kozlowski
2024-09-30 6:23 ` Alexander Dahl
2024-09-27 14:14 ` [PATCH v3 0/3] Summary of changes iansdannapel
2024-09-27 14:27 ` Krzysztof Kozlowski
2024-09-27 14:22 ` [PATCH 1/3] fpga: Add Efinix Trion & Titanium serial SPI programming driver Krzysztof Kozlowski
2024-10-18 1:22 ` Xu Yilun [this message]
2024-10-18 1:37 ` Xu Yilun
2024-10-18 16:58 ` Conor Dooley
2024-10-21 2:10 ` Xu Yilun
2024-10-21 12:18 ` Conor Dooley
2024-10-21 13:23 ` Ian Dannapel
-- strict thread matches above, loose matches on Subject: below --
2024-06-20 14:42 iansdannapel
2024-06-20 18:05 ` Marco Pagani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxG4TiP4tliF/bms@yilunxu-OptiPlex-7050 \
--to=yilun.xu@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hao.wu@intel.com \
--cc=heiko.stuebner@cherry.de \
--cc=iansdannapel@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.