* [PATCH v2 00/10] drm: Increase COMPILE_TEST=y coverage
@ 2024-10-03 11:18 ` Ville Syrjala
0 siblings, 0 replies; 24+ messages in thread
From: Ville Syrjala @ 2024-10-03 11:18 UTC (permalink / raw)
To: dri-devel
Cc: Alison Wang, Chun-Kuang Hu, Laurentiu Palcu, linux-amlogic,
linux-mediatek, Lucas Stach, Neil Armstrong, Philipp Zabel,
Russell King, Stefan Agner, Tomi Valkeinen
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Repost of the stragglers from
https://patchwork.freedesktop.org/series/132164/
Cc: Alison Wang <alison.wang@nxp.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Cc: linux-amlogic@lists.infradead.org
Cc: linux-mediatek@lists.infradead.org
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Stefan Agner <stefan@agner.ch>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Ville Syrjälä (10):
drm/tilcdc: Allow build without __iowmb()
drm/tilcdc: Allow build with COMPILE_TEST=y
drm/armada: Fix printk arguments
drm/armada: Fix armada_debugfs_crtc_reg_write() return type
drm/armada: Allow build with COMPILE_TEST=y
drm/imx/dcss: Fix 64bit divisions
drm/imx/dcss: Allow build with COMPILE_TEST=y
drm/fsl-dcu: Allow build with COMPILE_TEST=y
drm/mediatek: Allow build with COMPILE_TEST=y
drm/meson: Allow build with COMPILE_TEST=y
drivers/gpu/drm/armada/Kconfig | 2 +-
drivers/gpu/drm/armada/armada_debugfs.c | 2 +-
drivers/gpu/drm/armada/armada_gem.c | 2 +-
drivers/gpu/drm/fsl-dcu/Kconfig | 2 +-
drivers/gpu/drm/imx/dcss/Kconfig | 2 +-
drivers/gpu/drm/imx/dcss/dcss-scaler.c | 4 ++--
drivers/gpu/drm/mediatek/Kconfig | 4 ++--
drivers/gpu/drm/meson/Kconfig | 2 +-
drivers/gpu/drm/tilcdc/Kconfig | 2 +-
drivers/gpu/drm/tilcdc/tilcdc_regs.h | 3 +++
10 files changed, 14 insertions(+), 11 deletions(-)
--
2.45.2
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 01/10] drm/tilcdc: Allow build without __iowmb()
2024-10-03 11:18 ` Ville Syrjala
(?)
@ 2024-10-03 11:18 ` Ville Syrjala
-1 siblings, 0 replies; 24+ messages in thread
From: Ville Syrjala @ 2024-10-03 11:18 UTC (permalink / raw)
To: dri-devel; +Cc: Tomi Valkeinen, Jyri Sarha
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
__iowmb() isn't available on most architectures. Make
its use optional so that the driver can be built on
other architectures with COMPILE_TEST=y.
v2: Add a comment stating this is for COMPILE_TEST (Tomi)
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Acked-by: Jyri Sarha <jyri.sarha@iki.fi>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/tilcdc/tilcdc_regs.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_regs.h b/drivers/gpu/drm/tilcdc/tilcdc_regs.h
index f90e2dc3457c..332b24327386 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_regs.h
+++ b/drivers/gpu/drm/tilcdc/tilcdc_regs.h
@@ -125,7 +125,10 @@ static inline void tilcdc_write64(struct drm_device *dev, u32 reg, u64 data)
#if defined(iowrite64) && !defined(iowrite64_is_nonatomic)
iowrite64(data, addr);
#else
+ /* allow compilation without __iowmb() for COMPILE_TEST */
+#ifdef __iowmb
__iowmb();
+#endif
/* This compiles to strd (=64-bit write) on ARM7 */
*(volatile u64 __force *)addr = __cpu_to_le64(data);
#endif
--
2.45.2
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v2 02/10] drm/tilcdc: Allow build with COMPILE_TEST=y
2024-10-03 11:18 ` Ville Syrjala
(?)
(?)
@ 2024-10-03 11:18 ` Ville Syrjala
2024-10-04 15:24 ` kernel test robot
-1 siblings, 1 reply; 24+ messages in thread
From: Ville Syrjala @ 2024-10-03 11:18 UTC (permalink / raw)
To: dri-devel; +Cc: Jyri Sarha, Tomi Valkeinen
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Allow tilcdc to be built with COMPILE_TEST=y for greater
coverage. Builds fine on x86/x86_64 at least.
Acked-by: Jyri Sarha <jyri.sarha@iki.fi>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/tilcdc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig
index 24f9a245ba59..c430914b1db7 100644
--- a/drivers/gpu/drm/tilcdc/Kconfig
+++ b/drivers/gpu/drm/tilcdc/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_TILCDC
tristate "DRM Support for TI LCDC Display Controller"
- depends on DRM && OF && ARM
+ depends on DRM && OF && (ARM || COMPILE_TEST)
select DRM_CLIENT_SELECTION
select DRM_KMS_HELPER
select DRM_GEM_DMA_HELPER
--
2.45.2
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH v2 02/10] drm/tilcdc: Allow build with COMPILE_TEST=y
2024-10-03 11:18 ` [PATCH v2 02/10] drm/tilcdc: Allow build with COMPILE_TEST=y Ville Syrjala
@ 2024-10-04 15:24 ` kernel test robot
0 siblings, 0 replies; 24+ messages in thread
From: kernel test robot @ 2024-10-04 15:24 UTC (permalink / raw)
To: Ville Syrjala, dri-devel; +Cc: oe-kbuild-all, Jyri Sarha, Tomi Valkeinen
Hi Ville,
kernel test robot noticed the following build warnings:
[auto build test WARNING on next-20241003]
[cannot apply to shawnguo/for-next linus/master rmk-arm/drm-armada-devel rmk-arm/drm-armada-fixes v6.12-rc1 v6.11 v6.11-rc7 v6.12-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Ville-Syrjala/drm-tilcdc-Allow-build-without-__iowmb/20241003-192043
base: next-20241003
patch link: https://lore.kernel.org/r/20241003111851.10453-3-ville.syrjala%40linux.intel.com
patch subject: [PATCH v2 02/10] drm/tilcdc: Allow build with COMPILE_TEST=y
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20241004/202410042345.cQDnF4wd-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241004/202410042345.cQDnF4wd-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410042345.cQDnF4wd-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from drivers/gpu/drm/tilcdc/tilcdc_crtc.c:24:
drivers/gpu/drm/tilcdc/tilcdc_regs.h: In function 'tilcdc_write64':
>> drivers/gpu/drm/tilcdc/tilcdc_regs.h:126:25: warning: passing argument 2 of 'iowrite64' discards 'volatile' qualifier from pointer target type [-Wdiscarded-qualifiers]
126 | iowrite64(data, addr);
| ^~~~
In file included from arch/alpha/include/asm/io.h:15,
from include/linux/scatterlist.h:9,
from include/linux/dma-mapping.h:11,
from drivers/gpu/drm/tilcdc/tilcdc_crtc.c:8:
include/asm-generic/iomap.h:56:28: note: expected 'void *' but argument is of type 'volatile void *'
56 | extern void iowrite64(u64, void __iomem *);
| ^~~~~~~~~~~~~~
vim +126 drivers/gpu/drm/tilcdc/tilcdc_regs.h
16ea975eac671f Rob Clark 2013-01-08 119
7eb9f069ff5dd3 Jyri Sarha 2016-08-26 120 static inline void tilcdc_write64(struct drm_device *dev, u32 reg, u64 data)
7eb9f069ff5dd3 Jyri Sarha 2016-08-26 121 {
7eb9f069ff5dd3 Jyri Sarha 2016-08-26 122 struct tilcdc_drm_private *priv = dev->dev_private;
7eb9f069ff5dd3 Jyri Sarha 2016-08-26 123 volatile void __iomem *addr = priv->mmio + reg;
7eb9f069ff5dd3 Jyri Sarha 2016-08-26 124
4e5ca2d930aa87 Logan Gunthorpe 2017-12-05 125 #if defined(iowrite64) && !defined(iowrite64_is_nonatomic)
7eb9f069ff5dd3 Jyri Sarha 2016-08-26 @126 iowrite64(data, addr);
7eb9f069ff5dd3 Jyri Sarha 2016-08-26 127 #else
d5b0aa96231c76 Ville Syrjälä 2024-10-03 128 /* allow compilation without __iowmb() for COMPILE_TEST */
d5b0aa96231c76 Ville Syrjälä 2024-10-03 129 #ifdef __iowmb
7eb9f069ff5dd3 Jyri Sarha 2016-08-26 130 __iowmb();
d5b0aa96231c76 Ville Syrjälä 2024-10-03 131 #endif
7eb9f069ff5dd3 Jyri Sarha 2016-08-26 132 /* This compiles to strd (=64-bit write) on ARM7 */
7eb9f069ff5dd3 Jyri Sarha 2016-08-26 133 *(volatile u64 __force *)addr = __cpu_to_le64(data);
7eb9f069ff5dd3 Jyri Sarha 2016-08-26 134 #endif
7eb9f069ff5dd3 Jyri Sarha 2016-08-26 135 }
7eb9f069ff5dd3 Jyri Sarha 2016-08-26 136
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 03/10] drm/armada: Fix printk arguments
2024-10-03 11:18 ` Ville Syrjala
` (2 preceding siblings ...)
(?)
@ 2024-10-03 11:18 ` Ville Syrjala
-1 siblings, 0 replies; 24+ messages in thread
From: Ville Syrjala @ 2024-10-03 11:18 UTC (permalink / raw)
To: dri-devel; +Cc: Russell King
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
../drivers/gpu/drm/armada/armada_gem.c: In function ‘armada_gem_pwrite_ioctl’:
../drivers/gpu/drm/armada/armada_gem.c:367:27: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 2 has type ‘size_t’ {aka ‘long unsigned int’} [-Wformat=]
367 | DRM_ERROR("invalid size: object size %u\n", dobj->obj.size);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~
| |
| size_t {aka long unsigned int}
Cc: Russell King <linux@armlinux.org.uk>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/armada/armada_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/armada/armada_gem.c b/drivers/gpu/drm/armada/armada_gem.c
index 26d10065d534..e9575ef5aaef 100644
--- a/drivers/gpu/drm/armada/armada_gem.c
+++ b/drivers/gpu/drm/armada/armada_gem.c
@@ -364,7 +364,7 @@ int armada_gem_pwrite_ioctl(struct drm_device *dev, void *data,
if (args->offset > dobj->obj.size ||
args->size > dobj->obj.size - args->offset) {
- DRM_ERROR("invalid size: object size %u\n", dobj->obj.size);
+ DRM_ERROR("invalid size: object size %zu\n", dobj->obj.size);
ret = -EINVAL;
goto unref;
}
--
2.45.2
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH v2 04/10] drm/armada: Fix armada_debugfs_crtc_reg_write() return type
2024-10-03 11:18 ` Ville Syrjala
` (3 preceding siblings ...)
(?)
@ 2024-10-03 11:18 ` Ville Syrjala
-1 siblings, 0 replies; 24+ messages in thread
From: Ville Syrjala @ 2024-10-03 11:18 UTC (permalink / raw)
To: dri-devel; +Cc: Russell King
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Change the armada_debugfs_crtc_reg_write() return type to
the correct ssize_t. This makes the code actually build on
certain architectures.
Cc: Russell King <linux@armlinux.org.uk>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/armada/armada_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/armada/armada_debugfs.c b/drivers/gpu/drm/armada/armada_debugfs.c
index a763349dd89f..96aebd56272f 100644
--- a/drivers/gpu/drm/armada/armada_debugfs.c
+++ b/drivers/gpu/drm/armada/armada_debugfs.c
@@ -49,7 +49,7 @@ static int armada_debugfs_crtc_reg_open(struct inode *inode, struct file *file)
inode->i_private);
}
-static int armada_debugfs_crtc_reg_write(struct file *file,
+static ssize_t armada_debugfs_crtc_reg_write(struct file *file,
const char __user *ptr, size_t len, loff_t *off)
{
struct armada_crtc *dcrtc;
--
2.45.2
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH v2 05/10] drm/armada: Allow build with COMPILE_TEST=y
2024-10-03 11:18 ` Ville Syrjala
` (4 preceding siblings ...)
(?)
@ 2024-10-03 11:18 ` Ville Syrjala
2024-10-07 0:19 ` kernel test robot
-1 siblings, 1 reply; 24+ messages in thread
From: Ville Syrjala @ 2024-10-03 11:18 UTC (permalink / raw)
To: dri-devel; +Cc: Russell King
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Allow armada to be built with COMPILE_TEST=y for greater
coverage. Builds fine on x86/x86_64 at least.
Cc: Russell King <linux@armlinux.org.uk>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/armada/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/armada/Kconfig b/drivers/gpu/drm/armada/Kconfig
index b22c891a670b..1376337548da 100644
--- a/drivers/gpu/drm/armada/Kconfig
+++ b/drivers/gpu/drm/armada/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_ARMADA
tristate "DRM support for Marvell Armada SoCs"
- depends on DRM && HAVE_CLK && ARM && MMU
+ depends on DRM && HAVE_CLK && MMU && (ARM || COMPILE_TEST)
select DRM_CLIENT_SELECTION
select DRM_KMS_HELPER
select FB_IOMEM_HELPERS if DRM_FBDEV_EMULATION
--
2.45.2
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH v2 05/10] drm/armada: Allow build with COMPILE_TEST=y
2024-10-03 11:18 ` [PATCH v2 05/10] drm/armada: Allow build with COMPILE_TEST=y Ville Syrjala
@ 2024-10-07 0:19 ` kernel test robot
0 siblings, 0 replies; 24+ messages in thread
From: kernel test robot @ 2024-10-07 0:19 UTC (permalink / raw)
To: Ville Syrjala, dri-devel; +Cc: oe-kbuild-all, Russell King
Hi Ville,
kernel test robot noticed the following build warnings:
[auto build test WARNING on next-20241003]
[cannot apply to shawnguo/for-next linus/master rmk-arm/drm-armada-devel rmk-arm/drm-armada-fixes v6.12-rc1 v6.11 v6.11-rc7 v6.12-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Ville-Syrjala/drm-tilcdc-Allow-build-without-__iowmb/20241003-192043
base: next-20241003
patch link: https://lore.kernel.org/r/20241003111851.10453-6-ville.syrjala%40linux.intel.com
patch subject: [PATCH v2 05/10] drm/armada: Allow build with COMPILE_TEST=y
config: csky-randconfig-r121-20241006 (https://download.01.org/0day-ci/archive/20241007/202410070736.GTeKJE6r-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 14.1.0
reproduce: (https://download.01.org/0day-ci/archive/20241007/202410070736.GTeKJE6r-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410070736.GTeKJE6r-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/armada/armada_gem.c:63:37: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got void *addr @@
drivers/gpu/drm/armada/armada_gem.c:63:37: sparse: expected void volatile [noderef] __iomem *addr
drivers/gpu/drm/armada/armada_gem.c:63:37: sparse: got void *addr
drivers/gpu/drm/armada/armada_gem.c:185:28: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void *addr @@ got void [noderef] __iomem * @@
drivers/gpu/drm/armada/armada_gem.c:185:28: sparse: expected void *addr
drivers/gpu/drm/armada/armada_gem.c:185:28: sparse: got void [noderef] __iomem *
vim +63 drivers/gpu/drm/armada/armada_gem.c
96f60e37dc6609 Russell King 2012-08-15 40
96f60e37dc6609 Russell King 2012-08-15 41 void armada_gem_free_object(struct drm_gem_object *obj)
96f60e37dc6609 Russell King 2012-08-15 42 {
96f60e37dc6609 Russell King 2012-08-15 43 struct armada_gem_object *dobj = drm_to_armada_gem(obj);
dad75a5208ec88 Simona Vetter 2020-09-04 44 struct armada_private *priv = drm_to_armada_dev(obj->dev);
96f60e37dc6609 Russell King 2012-08-15 45
96f60e37dc6609 Russell King 2012-08-15 46 DRM_DEBUG_DRIVER("release obj %p\n", dobj);
96f60e37dc6609 Russell King 2012-08-15 47
96f60e37dc6609 Russell King 2012-08-15 48 drm_gem_free_mmap_offset(&dobj->obj);
96f60e37dc6609 Russell King 2012-08-15 49
0b8ebeacf5ef43 Simona Vetter 2015-11-24 50 might_lock(&priv->linear_lock);
0b8ebeacf5ef43 Simona Vetter 2015-11-24 51
96f60e37dc6609 Russell King 2012-08-15 52 if (dobj->page) {
96f60e37dc6609 Russell King 2012-08-15 53 /* page backed memory */
96f60e37dc6609 Russell King 2012-08-15 54 unsigned int order = get_order(dobj->obj.size);
96f60e37dc6609 Russell King 2012-08-15 55 __free_pages(dobj->page, order);
96f60e37dc6609 Russell King 2012-08-15 56 } else if (dobj->linear) {
96f60e37dc6609 Russell King 2012-08-15 57 /* linear backed memory */
0b8ebeacf5ef43 Simona Vetter 2015-11-24 58 mutex_lock(&priv->linear_lock);
96f60e37dc6609 Russell King 2012-08-15 59 drm_mm_remove_node(dobj->linear);
0b8ebeacf5ef43 Simona Vetter 2015-11-24 60 mutex_unlock(&priv->linear_lock);
96f60e37dc6609 Russell King 2012-08-15 61 kfree(dobj->linear);
96f60e37dc6609 Russell King 2012-08-15 62 if (dobj->addr)
96f60e37dc6609 Russell King 2012-08-15 @63 iounmap(dobj->addr);
96f60e37dc6609 Russell King 2012-08-15 64 }
96f60e37dc6609 Russell King 2012-08-15 65
96f60e37dc6609 Russell King 2012-08-15 66 if (dobj->obj.import_attach) {
96f60e37dc6609 Russell King 2012-08-15 67 /* We only ever display imported data */
0481c8c47f5e85 Russell King 2015-06-15 68 if (dobj->sgt)
e4ea542846d0ef Dmitry Osipenko 2022-10-17 69 dma_buf_unmap_attachment_unlocked(dobj->obj.import_attach,
0481c8c47f5e85 Russell King 2015-06-15 70 dobj->sgt, DMA_TO_DEVICE);
96f60e37dc6609 Russell King 2012-08-15 71 drm_prime_gem_destroy(&dobj->obj, NULL);
96f60e37dc6609 Russell King 2012-08-15 72 }
96f60e37dc6609 Russell King 2012-08-15 73
96f60e37dc6609 Russell King 2012-08-15 74 drm_gem_object_release(&dobj->obj);
96f60e37dc6609 Russell King 2012-08-15 75
96f60e37dc6609 Russell King 2012-08-15 76 kfree(dobj);
96f60e37dc6609 Russell King 2012-08-15 77 }
96f60e37dc6609 Russell King 2012-08-15 78
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 06/10] drm/imx/dcss: Fix 64bit divisions
2024-10-03 11:18 ` Ville Syrjala
` (5 preceding siblings ...)
(?)
@ 2024-10-03 11:18 ` Ville Syrjala
2024-10-04 11:39 ` Laurentiu Palcu
-1 siblings, 1 reply; 24+ messages in thread
From: Ville Syrjala @ 2024-10-03 11:18 UTC (permalink / raw)
To: dri-devel; +Cc: Laurentiu Palcu, Lucas Stach
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Use the appropriate 64bit division helpers to make the code
build on 32bit architectures.
Cc: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/imx/dcss/dcss-scaler.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/imx/dcss/dcss-scaler.c b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
index 825728c356ff..32c3f46b21da 100644
--- a/drivers/gpu/drm/imx/dcss/dcss-scaler.c
+++ b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
@@ -136,7 +136,7 @@ static int div_q(int A, int B)
else
temp -= B / 2;
- result = (int)(temp / B);
+ result = div_s64(temp, B);
return result;
}
@@ -239,7 +239,7 @@ static void dcss_scaler_gaussian_filter(int fc_q, bool use_5_taps,
ll_temp = coef[phase][i];
ll_temp <<= PSC_COEFF_PRECISION;
ll_temp += sum >> 1;
- ll_temp /= sum;
+ ll_temp = div_s64(ll_temp, sum);
coef[phase][i] = (int)ll_temp;
}
}
--
2.45.2
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH v2 06/10] drm/imx/dcss: Fix 64bit divisions
2024-10-03 11:18 ` [PATCH v2 06/10] drm/imx/dcss: Fix 64bit divisions Ville Syrjala
@ 2024-10-04 11:39 ` Laurentiu Palcu
0 siblings, 0 replies; 24+ messages in thread
From: Laurentiu Palcu @ 2024-10-04 11:39 UTC (permalink / raw)
To: Ville Syrjala; +Cc: dri-devel, Lucas Stach
Hi,
On Thu, Oct 03, 2024 at 02:18:47PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Use the appropriate 64bit division helpers to make the code
> build on 32bit architectures.
>
> Cc: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Thanks,
Laurentiu
> ---
> drivers/gpu/drm/imx/dcss/dcss-scaler.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/imx/dcss/dcss-scaler.c b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
> index 825728c356ff..32c3f46b21da 100644
> --- a/drivers/gpu/drm/imx/dcss/dcss-scaler.c
> +++ b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
> @@ -136,7 +136,7 @@ static int div_q(int A, int B)
> else
> temp -= B / 2;
>
> - result = (int)(temp / B);
> + result = div_s64(temp, B);
> return result;
> }
>
> @@ -239,7 +239,7 @@ static void dcss_scaler_gaussian_filter(int fc_q, bool use_5_taps,
> ll_temp = coef[phase][i];
> ll_temp <<= PSC_COEFF_PRECISION;
> ll_temp += sum >> 1;
> - ll_temp /= sum;
> + ll_temp = div_s64(ll_temp, sum);
> coef[phase][i] = (int)ll_temp;
> }
> }
> --
> 2.45.2
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 07/10] drm/imx/dcss: Allow build with COMPILE_TEST=y
2024-10-03 11:18 ` Ville Syrjala
` (6 preceding siblings ...)
(?)
@ 2024-10-03 11:18 ` Ville Syrjala
2024-10-04 11:40 ` Laurentiu Palcu
-1 siblings, 1 reply; 24+ messages in thread
From: Ville Syrjala @ 2024-10-03 11:18 UTC (permalink / raw)
To: dri-devel; +Cc: Laurentiu Palcu, Lucas Stach
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Allow imx/dcss to be built with COMPILE_TEST=y for greater
coverage. Builds fine on x86/x86_64 at least.
Cc: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/imx/dcss/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/dcss/Kconfig b/drivers/gpu/drm/imx/dcss/Kconfig
index 9d58f41bd00c..e014ed3ae66c 100644
--- a/drivers/gpu/drm/imx/dcss/Kconfig
+++ b/drivers/gpu/drm/imx/dcss/Kconfig
@@ -7,7 +7,7 @@ config DRM_IMX_DCSS
select DRM_BRIDGE_CONNECTOR
select DRM_GEM_DMA_HELPER
select VIDEOMODE_HELPERS
- depends on DRM && ARCH_MXC && ARM64
+ depends on DRM && ((ARCH_MXC && ARM64) || COMPILE_TEST)
help
Choose this if you have a NXP i.MX8MQ based system and want to use the
Display Controller Subsystem. This option enables DCSS support.
--
2.45.2
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH v2 07/10] drm/imx/dcss: Allow build with COMPILE_TEST=y
2024-10-03 11:18 ` [PATCH v2 07/10] drm/imx/dcss: Allow build with COMPILE_TEST=y Ville Syrjala
@ 2024-10-04 11:40 ` Laurentiu Palcu
0 siblings, 0 replies; 24+ messages in thread
From: Laurentiu Palcu @ 2024-10-04 11:40 UTC (permalink / raw)
To: Ville Syrjala; +Cc: dri-devel, Lucas Stach
Hi,
On Thu, Oct 03, 2024 at 02:18:48PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Allow imx/dcss to be built with COMPILE_TEST=y for greater
> coverage. Builds fine on x86/x86_64 at least.
>
> Cc: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>a
Reviewed-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Thanks,
Laurentiu
> ---
> drivers/gpu/drm/imx/dcss/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/imx/dcss/Kconfig b/drivers/gpu/drm/imx/dcss/Kconfig
> index 9d58f41bd00c..e014ed3ae66c 100644
> --- a/drivers/gpu/drm/imx/dcss/Kconfig
> +++ b/drivers/gpu/drm/imx/dcss/Kconfig
> @@ -7,7 +7,7 @@ config DRM_IMX_DCSS
> select DRM_BRIDGE_CONNECTOR
> select DRM_GEM_DMA_HELPER
> select VIDEOMODE_HELPERS
> - depends on DRM && ARCH_MXC && ARM64
> + depends on DRM && ((ARCH_MXC && ARM64) || COMPILE_TEST)
> help
> Choose this if you have a NXP i.MX8MQ based system and want to use the
> Display Controller Subsystem. This option enables DCSS support.
> --
> 2.45.2
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 08/10] drm/fsl-dcu: Allow build with COMPILE_TEST=y
2024-10-03 11:18 ` Ville Syrjala
` (7 preceding siblings ...)
(?)
@ 2024-10-03 11:18 ` Ville Syrjala
-1 siblings, 0 replies; 24+ messages in thread
From: Ville Syrjala @ 2024-10-03 11:18 UTC (permalink / raw)
To: dri-devel; +Cc: Stefan Agner, Alison Wang
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Allow fsl-dcu to be built with COMPILE_TEST=y for greater
coverage. Builds fine on x86/x86_64 at least.
Cc: Stefan Agner <stefan@agner.ch>
Cc: Alison Wang <alison.wang@nxp.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/fsl-dcu/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/fsl-dcu/Kconfig b/drivers/gpu/drm/fsl-dcu/Kconfig
index 588ce2420af2..4226e54f94c6 100644
--- a/drivers/gpu/drm/fsl-dcu/Kconfig
+++ b/drivers/gpu/drm/fsl-dcu/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_FSL_DCU
tristate "DRM Support for Freescale DCU"
- depends on DRM && OF && ARM && COMMON_CLK
+ depends on DRM && OF && (ARM || COMPILE_TEST) && COMMON_CLK
select BACKLIGHT_CLASS_DEVICE
select DRM_CLIENT_SELECTION
select DRM_GEM_DMA_HELPER
--
2.45.2
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH v2 09/10] drm/mediatek: Allow build with COMPILE_TEST=y
2024-10-03 11:18 ` Ville Syrjala
` (8 preceding siblings ...)
(?)
@ 2024-10-03 11:18 ` Ville Syrjala
2024-10-22 9:46 ` CK Hu (胡俊光)
-1 siblings, 1 reply; 24+ messages in thread
From: Ville Syrjala @ 2024-10-03 11:18 UTC (permalink / raw)
To: dri-devel; +Cc: Chun-Kuang Hu, Philipp Zabel, linux-mediatek
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Allow mediatek to be built with COMPILE_TEST=y for greater
coverage. Builds fine on x86/x86_64 at least.
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-mediatek@lists.infradead.org
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/mediatek/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
index 3d2436272ff2..2e0e7c4079b6 100644
--- a/drivers/gpu/drm/mediatek/Kconfig
+++ b/drivers/gpu/drm/mediatek/Kconfig
@@ -2,9 +2,9 @@
config DRM_MEDIATEK
tristate "DRM Support for Mediatek SoCs"
depends on DRM
- depends on ARCH_MEDIATEK || (ARM && COMPILE_TEST)
+ depends on (ARCH_MEDIATEK && ARM) || COMPILE_TEST
depends on COMMON_CLK
- depends on HAVE_ARM_SMCCC
+ depends on HAVE_ARM_SMCCC || COMPILE_TEST
depends on OF
depends on MTK_MMSYS
select DRM_CLIENT_SELECTION
--
2.45.2
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH v2 09/10] drm/mediatek: Allow build with COMPILE_TEST=y
2024-10-03 11:18 ` [PATCH v2 09/10] drm/mediatek: " Ville Syrjala
@ 2024-10-22 9:46 ` CK Hu (胡俊光)
0 siblings, 0 replies; 24+ messages in thread
From: CK Hu (胡俊光) @ 2024-10-22 9:46 UTC (permalink / raw)
To: ville.syrjala@linux.intel.com, dri-devel@lists.freedesktop.org
Cc: p.zabel@pengutronix.de, linux-mediatek@lists.infradead.org,
chunkuang.hu@kernel.org
Hi, Ville:
On Thu, 2024-10-03 at 14:18 +0300, Ville Syrjala wrote:
>
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Allow mediatek to be built with COMPILE_TEST=y for greater
> coverage. Builds fine on x86/x86_64 at least.
I don't know why need this greater coverage?
This driver always execute on ARM.
Regards,
CK
>
> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: linux-mediatek@lists.infradead.org
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/mediatek/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
> index 3d2436272ff2..2e0e7c4079b6 100644
> --- a/drivers/gpu/drm/mediatek/Kconfig
> +++ b/drivers/gpu/drm/mediatek/Kconfig
> @@ -2,9 +2,9 @@
> config DRM_MEDIATEK
> tristate "DRM Support for Mediatek SoCs"
> depends on DRM
> -depends on ARCH_MEDIATEK || (ARM && COMPILE_TEST)
> +depends on (ARCH_MEDIATEK && ARM) || COMPILE_TEST
> depends on COMMON_CLK
> -depends on HAVE_ARM_SMCCC
> +depends on HAVE_ARM_SMCCC || COMPILE_TEST
> depends on OF
> depends on MTK_MMSYS
> select DRM_CLIENT_SELECTION
> --
> 2.45.2
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 09/10] drm/mediatek: Allow build with COMPILE_TEST=y
@ 2024-10-22 9:46 ` CK Hu (胡俊光)
0 siblings, 0 replies; 24+ messages in thread
From: CK Hu (胡俊光) @ 2024-10-22 9:46 UTC (permalink / raw)
To: ville.syrjala@linux.intel.com, dri-devel@lists.freedesktop.org
Cc: p.zabel@pengutronix.de, linux-mediatek@lists.infradead.org,
chunkuang.hu@kernel.org
[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]
Hi, Ville:
On Thu, 2024-10-03 at 14:18 +0300, Ville Syrjala wrote:
>
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Allow mediatek to be built with COMPILE_TEST=y for greater
> coverage. Builds fine on x86/x86_64 at least.
I don't know why need this greater coverage?
This driver always execute on ARM.
Regards,
CK
>
> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: linux-mediatek@lists.infradead.org
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/mediatek/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
> index 3d2436272ff2..2e0e7c4079b6 100644
> --- a/drivers/gpu/drm/mediatek/Kconfig
> +++ b/drivers/gpu/drm/mediatek/Kconfig
> @@ -2,9 +2,9 @@
> config DRM_MEDIATEK
> tristate "DRM Support for Mediatek SoCs"
> depends on DRM
> -depends on ARCH_MEDIATEK || (ARM && COMPILE_TEST)
> +depends on (ARCH_MEDIATEK && ARM) || COMPILE_TEST
> depends on COMMON_CLK
> -depends on HAVE_ARM_SMCCC
> +depends on HAVE_ARM_SMCCC || COMPILE_TEST
> depends on OF
> depends on MTK_MMSYS
> select DRM_CLIENT_SELECTION
> --
> 2.45.2
>
[-- Attachment #2: Type: text/html, Size: 3207 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 09/10] drm/mediatek: Allow build with COMPILE_TEST=y
2024-10-22 9:46 ` CK Hu (胡俊光)
(?)
@ 2024-10-22 13:06 ` Ville Syrjälä
2024-10-23 1:36 ` CK Hu (胡俊光)
-1 siblings, 1 reply; 24+ messages in thread
From: Ville Syrjälä @ 2024-10-22 13:06 UTC (permalink / raw)
To: CK Hu (胡俊光)
Cc: dri-devel@lists.freedesktop.org, p.zabel@pengutronix.de,
linux-mediatek@lists.infradead.org, chunkuang.hu@kernel.org
On Tue, Oct 22, 2024 at 09:46:24AM +0000, CK Hu (胡俊光) wrote:
> Hi, Ville:
>
> On Thu, 2024-10-03 at 14:18 +0300, Ville Syrjala wrote:
> >
> > External email : Please do not click links or open attachments until you have verified the sender or the content.
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Allow mediatek to be built with COMPILE_TEST=y for greater
> > coverage. Builds fine on x86/x86_64 at least.
>
> I don't know why need this greater coverage?
It allows people to make subsystem wide changes without
having to cross compile on every single architecture to
see if the code still builds.
> This driver always execute on ARM.
COMPILE_TEST (as the name suggests) is only about compile
testing the code.
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 09/10] drm/mediatek: Allow build with COMPILE_TEST=y
2024-10-22 13:06 ` Ville Syrjälä
@ 2024-10-23 1:36 ` CK Hu (胡俊光)
0 siblings, 0 replies; 24+ messages in thread
From: CK Hu (胡俊光) @ 2024-10-23 1:36 UTC (permalink / raw)
To: ville.syrjala@linux.intel.com
Cc: dri-devel@lists.freedesktop.org, p.zabel@pengutronix.de,
linux-mediatek@lists.infradead.org, chunkuang.hu@kernel.org
Hi, Ville:
On Tue, 2024-10-22 at 16:06 +0300, Ville Syrjälä wrote:
>
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> On Tue, Oct 22, 2024 at 09:46:24AM +0000, CK Hu (胡俊光) wrote:
> > Hi, Ville:
> >
> > On Thu, 2024-10-03 at 14:18 +0300, Ville Syrjala wrote:
> > >
> > > External email : Please do not click links or open attachments until you have verified the sender or the content.
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > Allow mediatek to be built with COMPILE_TEST=y for greater
> > > coverage. Builds fine on x86/x86_64 at least.
> >
> > I don't know why need this greater coverage?
>
> It allows people to make subsystem wide changes without
> having to cross compile on every single architecture to
> see if the code still builds.
>
> > This driver always execute on ARM.
>
> COMPILE_TEST (as the name suggests) is only about compile
> testing the code.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> --
> Ville Syrjälä
> Intel
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 09/10] drm/mediatek: Allow build with COMPILE_TEST=y
@ 2024-10-23 1:36 ` CK Hu (胡俊光)
0 siblings, 0 replies; 24+ messages in thread
From: CK Hu (胡俊光) @ 2024-10-23 1:36 UTC (permalink / raw)
To: ville.syrjala@linux.intel.com
Cc: dri-devel@lists.freedesktop.org, p.zabel@pengutronix.de,
linux-mediatek@lists.infradead.org, chunkuang.hu@kernel.org
[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]
Hi, Ville:
On Tue, 2024-10-22 at 16:06 +0300, Ville Syrjälä wrote:
>
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> On Tue, Oct 22, 2024 at 09:46:24AM +0000, CK Hu (胡俊光) wrote:
> > Hi, Ville:
> >
> > On Thu, 2024-10-03 at 14:18 +0300, Ville Syrjala wrote:
> > >
> > > External email : Please do not click links or open attachments until you have verified the sender or the content.
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > Allow mediatek to be built with COMPILE_TEST=y for greater
> > > coverage. Builds fine on x86/x86_64 at least.
> >
> > I don't know why need this greater coverage?
>
> It allows people to make subsystem wide changes without
> having to cross compile on every single architecture to
> see if the code still builds.
>
> > This driver always execute on ARM.
>
> COMPILE_TEST (as the name suggests) is only about compile
> testing the code.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> --
> Ville Syrjälä
> Intel
>
[-- Attachment #2: Type: text/html, Size: 2988 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 10/10] drm/meson: Allow build with COMPILE_TEST=y
2024-10-03 11:18 ` Ville Syrjala
@ 2024-10-03 11:18 ` Ville Syrjala
-1 siblings, 0 replies; 24+ messages in thread
From: Ville Syrjala @ 2024-10-03 11:18 UTC (permalink / raw)
To: dri-devel; +Cc: Neil Armstrong, linux-amlogic
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Allow meson to be built with COMPILE_TEST=y for greater
coverage. Builds fine on x86/x86_64 at least.
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: linux-amlogic@lists.infradead.org
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/meson/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/meson/Kconfig b/drivers/gpu/drm/meson/Kconfig
index b410e0d8015a..417f79829cf8 100644
--- a/drivers/gpu/drm/meson/Kconfig
+++ b/drivers/gpu/drm/meson/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_MESON
tristate "DRM Support for Amlogic Meson Display Controller"
- depends on DRM && OF && (ARM || ARM64)
+ depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
depends on ARCH_MESON || COMPILE_TEST
select DRM_CLIENT_SELECTION
select DRM_KMS_HELPER
--
2.45.2
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v2 10/10] drm/meson: Allow build with COMPILE_TEST=y
@ 2024-10-03 11:18 ` Ville Syrjala
0 siblings, 0 replies; 24+ messages in thread
From: Ville Syrjala @ 2024-10-03 11:18 UTC (permalink / raw)
To: dri-devel; +Cc: Neil Armstrong, linux-amlogic
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Allow meson to be built with COMPILE_TEST=y for greater
coverage. Builds fine on x86/x86_64 at least.
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: linux-amlogic@lists.infradead.org
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/meson/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/meson/Kconfig b/drivers/gpu/drm/meson/Kconfig
index b410e0d8015a..417f79829cf8 100644
--- a/drivers/gpu/drm/meson/Kconfig
+++ b/drivers/gpu/drm/meson/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_MESON
tristate "DRM Support for Amlogic Meson Display Controller"
- depends on DRM && OF && (ARM || ARM64)
+ depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
depends on ARCH_MESON || COMPILE_TEST
select DRM_CLIENT_SELECTION
select DRM_KMS_HELPER
--
2.45.2
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH v2 10/10] drm/meson: Allow build with COMPILE_TEST=y
2024-10-03 11:18 ` Ville Syrjala
@ 2024-10-03 11:55 ` Neil Armstrong
-1 siblings, 0 replies; 24+ messages in thread
From: Neil Armstrong @ 2024-10-03 11:55 UTC (permalink / raw)
To: Ville Syrjala, dri-devel; +Cc: linux-amlogic
On 03/10/2024 13:18, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Allow meson to be built with COMPILE_TEST=y for greater
> coverage. Builds fine on x86/x86_64 at least.
>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: linux-amlogic@lists.infradead.org
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/meson/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/meson/Kconfig b/drivers/gpu/drm/meson/Kconfig
> index b410e0d8015a..417f79829cf8 100644
> --- a/drivers/gpu/drm/meson/Kconfig
> +++ b/drivers/gpu/drm/meson/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config DRM_MESON
> tristate "DRM Support for Amlogic Meson Display Controller"
> - depends on DRM && OF && (ARM || ARM64)
> + depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
> depends on ARCH_MESON || COMPILE_TEST
> select DRM_CLIENT_SELECTION
> select DRM_KMS_HELPER
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 10/10] drm/meson: Allow build with COMPILE_TEST=y
@ 2024-10-03 11:55 ` Neil Armstrong
0 siblings, 0 replies; 24+ messages in thread
From: Neil Armstrong @ 2024-10-03 11:55 UTC (permalink / raw)
To: Ville Syrjala, dri-devel; +Cc: linux-amlogic
On 03/10/2024 13:18, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Allow meson to be built with COMPILE_TEST=y for greater
> coverage. Builds fine on x86/x86_64 at least.
>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: linux-amlogic@lists.infradead.org
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/meson/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/meson/Kconfig b/drivers/gpu/drm/meson/Kconfig
> index b410e0d8015a..417f79829cf8 100644
> --- a/drivers/gpu/drm/meson/Kconfig
> +++ b/drivers/gpu/drm/meson/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config DRM_MESON
> tristate "DRM Support for Amlogic Meson Display Controller"
> - depends on DRM && OF && (ARM || ARM64)
> + depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
> depends on ARCH_MESON || COMPILE_TEST
> select DRM_CLIENT_SELECTION
> select DRM_KMS_HELPER
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 24+ messages in thread