From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Michael Walle <mwalle@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Pratyush Yadav <pratyush@kernel.org>
Subject: Re: [PATCH v2] mtd: spi-nor: atmel: add at25sf321 entry
Date: Tue, 29 Oct 2024 14:16:57 +0100 [thread overview]
Message-ID: <ZyDgSRcT79yksuG2@gmail.com> (raw)
In-Reply-To: <0bbd2514-ff51-4b0c-b3ad-547e4937d9f4@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]
Hi Tudor,
On Tue, Oct 29, 2024 at 11:36:17AM +0000, Tudor Ambarus wrote:
>
>
> On 10/29/24 11:23 AM, Marcus Folkesson wrote:
> > Add entry for the at25sf321 32Mbit SPI flash.
> >
> > This flash is populated on a custom board and was tested at
> > 10MHz frequency using the "ti,da830-spi" SPI controller.
> >
>
> no sfdp for this one?
No SFDP for this one!
>
> > Link:
> > https://www.renesas.com/en/document/dst/at25sf321-datasheet?r=1608801
> >
> > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> > ---
[...]
> > diff --git a/drivers/mtd/spi-nor/atmel.c b/drivers/mtd/spi-nor/atmel.c
> > index 45d1153a04a07b7c61f46b117311b24ab695038f..8285a16b253d54ae8c4a5302850244d2248aa755 100644
> > --- a/drivers/mtd/spi-nor/atmel.c
> > +++ b/drivers/mtd/spi-nor/atmel.c
> > @@ -238,6 +238,11 @@ static const struct flash_info atmel_nor_parts[] = {
> > .flags = SPI_NOR_HAS_LOCK,
> > .no_sfdp_flags = SECT_4K,
> > .fixups = &at25fs_nor_fixups
> > + }, {
> > + .id = SNOR_ID(0x1f, 0x87, 0x01),
> > + .name = "at25sf321",
> > + .size = SZ_4M,
> > + .no_sfdp_flags = SECT_4K,
>
> it seems this flash supports dual and quad reads. Do you care to
> add/test these modes?
>
> you'll need mtd-utils
Sure, not sure how I test it though.
I've added mtd-utils but I do not see any good parameters to set mode?
>
> > },
> > };
> >
> >
> > ---
> > base-commit: 200289db261f0c8131a5756133e9d30966289c3b
> > change-id: 20241018-spi-nor-dc29698dea0f
> >
> > Best regards,
Best regards,
Marcus Folkesson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <mwalle@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: spi-nor: atmel: add at25sf321 entry
Date: Tue, 29 Oct 2024 14:16:57 +0100 [thread overview]
Message-ID: <ZyDgSRcT79yksuG2@gmail.com> (raw)
In-Reply-To: <0bbd2514-ff51-4b0c-b3ad-547e4937d9f4@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 1589 bytes --]
Hi Tudor,
On Tue, Oct 29, 2024 at 11:36:17AM +0000, Tudor Ambarus wrote:
>
>
> On 10/29/24 11:23 AM, Marcus Folkesson wrote:
> > Add entry for the at25sf321 32Mbit SPI flash.
> >
> > This flash is populated on a custom board and was tested at
> > 10MHz frequency using the "ti,da830-spi" SPI controller.
> >
>
> no sfdp for this one?
No SFDP for this one!
>
> > Link:
> > https://www.renesas.com/en/document/dst/at25sf321-datasheet?r=1608801
> >
> > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> > ---
[...]
> > diff --git a/drivers/mtd/spi-nor/atmel.c b/drivers/mtd/spi-nor/atmel.c
> > index 45d1153a04a07b7c61f46b117311b24ab695038f..8285a16b253d54ae8c4a5302850244d2248aa755 100644
> > --- a/drivers/mtd/spi-nor/atmel.c
> > +++ b/drivers/mtd/spi-nor/atmel.c
> > @@ -238,6 +238,11 @@ static const struct flash_info atmel_nor_parts[] = {
> > .flags = SPI_NOR_HAS_LOCK,
> > .no_sfdp_flags = SECT_4K,
> > .fixups = &at25fs_nor_fixups
> > + }, {
> > + .id = SNOR_ID(0x1f, 0x87, 0x01),
> > + .name = "at25sf321",
> > + .size = SZ_4M,
> > + .no_sfdp_flags = SECT_4K,
>
> it seems this flash supports dual and quad reads. Do you care to
> add/test these modes?
>
> you'll need mtd-utils
Sure, not sure how I test it though.
I've added mtd-utils but I do not see any good parameters to set mode?
>
> > },
> > };
> >
> >
> > ---
> > base-commit: 200289db261f0c8131a5756133e9d30966289c3b
> > change-id: 20241018-spi-nor-dc29698dea0f
> >
> > Best regards,
Best regards,
Marcus Folkesson
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <mwalle@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: spi-nor: atmel: add at25sf321 entry
Date: Tue, 29 Oct 2024 14:16:57 +0100 [thread overview]
Message-ID: <ZyDgSRcT79yksuG2@gmail.com> (raw)
In-Reply-To: <0bbd2514-ff51-4b0c-b3ad-547e4937d9f4@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]
Hi Tudor,
On Tue, Oct 29, 2024 at 11:36:17AM +0000, Tudor Ambarus wrote:
>
>
> On 10/29/24 11:23 AM, Marcus Folkesson wrote:
> > Add entry for the at25sf321 32Mbit SPI flash.
> >
> > This flash is populated on a custom board and was tested at
> > 10MHz frequency using the "ti,da830-spi" SPI controller.
> >
>
> no sfdp for this one?
No SFDP for this one!
>
> > Link:
> > https://www.renesas.com/en/document/dst/at25sf321-datasheet?r=1608801
> >
> > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> > ---
[...]
> > diff --git a/drivers/mtd/spi-nor/atmel.c b/drivers/mtd/spi-nor/atmel.c
> > index 45d1153a04a07b7c61f46b117311b24ab695038f..8285a16b253d54ae8c4a5302850244d2248aa755 100644
> > --- a/drivers/mtd/spi-nor/atmel.c
> > +++ b/drivers/mtd/spi-nor/atmel.c
> > @@ -238,6 +238,11 @@ static const struct flash_info atmel_nor_parts[] = {
> > .flags = SPI_NOR_HAS_LOCK,
> > .no_sfdp_flags = SECT_4K,
> > .fixups = &at25fs_nor_fixups
> > + }, {
> > + .id = SNOR_ID(0x1f, 0x87, 0x01),
> > + .name = "at25sf321",
> > + .size = SZ_4M,
> > + .no_sfdp_flags = SECT_4K,
>
> it seems this flash supports dual and quad reads. Do you care to
> add/test these modes?
>
> you'll need mtd-utils
Sure, not sure how I test it though.
I've added mtd-utils but I do not see any good parameters to set mode?
>
> > },
> > };
> >
> >
> > ---
> > base-commit: 200289db261f0c8131a5756133e9d30966289c3b
> > change-id: 20241018-spi-nor-dc29698dea0f
> >
> > Best regards,
Best regards,
Marcus Folkesson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-10-29 13:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 11:23 [PATCH v2] mtd: spi-nor: atmel: add at25sf321 entry Marcus Folkesson
2024-10-29 11:23 ` Marcus Folkesson
2024-10-29 11:36 ` Tudor Ambarus
2024-10-29 11:36 ` Tudor Ambarus
2024-10-29 13:16 ` Marcus Folkesson [this message]
2024-10-29 13:16 ` Marcus Folkesson
2024-10-29 13:16 ` Marcus Folkesson
2024-10-29 13:35 ` Tudor Ambarus
2024-10-29 13:35 ` Tudor Ambarus
2024-10-29 13:35 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyDgSRcT79yksuG2@gmail.com \
--to=marcus.folkesson@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.