All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] bios_emulator: define the comment symbol for RISC-V assembler too
@ 2024-10-30 13:00 Yuri Zaporozhets
  2024-11-05  1:07 ` Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Yuri Zaporozhets @ 2024-10-30 13:00 UTC (permalink / raw)
  To: u-boot

The bios_emulator driver cannot be compiled for RISC-V because the x86emu.h
header file doesn't define the comment symbol ("#") for the assembler.
With this patch, use the same symbol as for e.g. x86.

Signed-off-by: Yuri Zaporozhets <yuriz@qrv-systems.net>
---
 drivers/bios_emulator/include/x86emu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bios_emulator/include/x86emu.h b/drivers/bios_emulator/include/x86emu.h
index d2650a8d16..cfdcd7b3e1 100644
--- a/drivers/bios_emulator/include/x86emu.h
+++ b/drivers/bios_emulator/include/x86emu.h
@@ -54,7 +54,7 @@ typedef u16 X86EMU_pioAddr;
 
 #if defined(CONFIG_ARM)
 #define GAS_LINE_COMMENT	"@"
-#elif defined(CONFIG_MIPS) || defined(CONFIG_PPC) || defined(CONFIG_X86)
+#elif defined(CONFIG_MIPS) || defined(CONFIG_PPC) || defined(CONFIG_X86) || defined(CONFIG_RISCV)
 #define GAS_LINE_COMMENT	"#"
 #elif defined (CONFIG_SH)
 #define GAS_LINE_COMMENT	"!"
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] bios_emulator: define the comment symbol for RISC-V assembler too
  2024-10-30 13:00 [PATCH] bios_emulator: define the comment symbol for RISC-V assembler too Yuri Zaporozhets
@ 2024-11-05  1:07 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2024-11-05  1:07 UTC (permalink / raw)
  To: u-boot, Yuri Zaporozhets

On Wed, 30 Oct 2024 14:00:51 +0100, Yuri Zaporozhets wrote:

> The bios_emulator driver cannot be compiled for RISC-V because the x86emu.h
> header file doesn't define the comment symbol ("#") for the assembler.
> With this patch, use the same symbol as for e.g. x86.
> 
> 

Applied to u-boot/master, thanks!

-- 
Tom



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-05  1:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-30 13:00 [PATCH] bios_emulator: define the comment symbol for RISC-V assembler too Yuri Zaporozhets
2024-11-05  1:07 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.