From: Cyrill Gorcunov <gorcunov@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>, linux-efi@vger.kernel.org
Cc: Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH] efi: Fix memory leak in efivar_ssdt_load
Date: Mon, 4 Nov 2024 14:53:58 +0300 [thread overview]
Message-ID: <Zyi11v-6V_ivKS5x@grain> (raw)
In-Reply-To: <ZyizcvscUWIyZYdE@grain>
On Mon, Nov 04, 2024 at 02:43:46PM +0300, Cyrill Gorcunov wrote:
> When we load ssdt from efi variable (specified with efivar_ssdt=something
> boot command line argument) a name for the variable is allocated
> dynamically because we traverse all efi variables. Unlike an acpi table
> data, which is later used by acpi engine, the name is no longer needed
> once traverse is complete -- don't forget to free this memory.
Drop it for a while: found that ret variable is shadowed while compiler
didn't spit a warn about, not a bug but better fix it. Will send v2.
next prev parent reply other threads:[~2024-11-04 11:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 11:43 [PATCH] efi: Fix memory leak in efivar_ssdt_load Cyrill Gorcunov
2024-11-04 11:53 ` Cyrill Gorcunov [this message]
2024-11-04 12:13 ` [PATCH v2] " Cyrill Gorcunov
2024-11-15 17:02 ` Ard Biesheuvel
2024-11-15 18:36 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zyi11v-6V_ivKS5x@grain \
--to=gorcunov@gmail.com \
--cc=ardb@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.