From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-efi@vger.kernel.org
Subject: Re: [PATCH v2] efi: Fix memory leak in efivar_ssdt_load
Date: Fri, 15 Nov 2024 21:36:14 +0300 [thread overview]
Message-ID: <ZzeUnn99B47FAA6R@grain> (raw)
In-Reply-To: <CAMj1kXEujWSOLjtwqSrmeP8yxuYof_Vn-vPVFi+gA2m=p64sEw@mail.gmail.com>
On Fri, Nov 15, 2024 at 06:02:07PM +0100, Ard Biesheuvel wrote:
> > It is still unclear for me why we don't exit with error if acpi_load_table
> > failed but continue to iterate keys and don't report a caller with error
> > instead. I didn't change this logic for backward compatibility sake but
> > still looks suspicious.
> >
>
> I've queued this up now.
>
> I think there may be cases where it might make sense, or at least,
> where currently, we might rely on the behavior where acpi_load_table()
> failures are ignored. If a table references an object that does not
> exist in the namespace (e.g., because some I2C controller is
> disabled), it might still make sense to load remaining SSDTs if they
> describe things that are unrelated.
Yeah, sound reasonable. Thanks, Ard!
prev parent reply other threads:[~2024-11-15 18:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 11:43 [PATCH] efi: Fix memory leak in efivar_ssdt_load Cyrill Gorcunov
2024-11-04 11:53 ` Cyrill Gorcunov
2024-11-04 12:13 ` [PATCH v2] " Cyrill Gorcunov
2024-11-15 17:02 ` Ard Biesheuvel
2024-11-15 18:36 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzeUnn99B47FAA6R@grain \
--to=gorcunov@gmail.com \
--cc=ardb@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.