* Can perf record make buildid-mmap the default
@ 2024-11-03 6:03 Ian Rogers
2024-11-04 10:25 ` James Clark
0 siblings, 1 reply; 3+ messages in thread
From: Ian Rogers @ 2024-11-03 6:03 UTC (permalink / raw)
To: linux-perf-users, Arnaldo Carvalho de Melo, Namhyung Kim,
Jiri Olsa, Adrian Hunter, Liang, Kan
Hi,
Without command line flags perf record will post process samples
adding DSO buildid events with samples it will also populate the
buildid cache. The --buildid-mmap option is superior as mmap events
have buildids within them and the buildid cache isn't generated. As
buildid-mmap has been available since 5.12, a full major release, can
we just make its defaults the defaults for perf record?
Thanks,
Ian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Can perf record make buildid-mmap the default
2024-11-03 6:03 Can perf record make buildid-mmap the default Ian Rogers
@ 2024-11-04 10:25 ` James Clark
2024-11-04 18:28 ` Namhyung Kim
0 siblings, 1 reply; 3+ messages in thread
From: James Clark @ 2024-11-04 10:25 UTC (permalink / raw)
To: Ian Rogers
Cc: linux-perf-users, Arnaldo Carvalho de Melo, Namhyung Kim,
Jiri Olsa, Adrian Hunter, Liang, Kan
On 03/11/2024 6:03 am, Ian Rogers wrote:
> Hi,
>
> Without command line flags perf record will post process samples
> adding DSO buildid events with samples it will also populate the
> buildid cache. The --buildid-mmap option is superior as mmap events
> have buildids within them and the buildid cache isn't generated. As
> buildid-mmap has been available since 5.12, a full major release, can
> we just make its defaults the defaults for perf record?
>
> Thanks,
> Ian
>
There's already the perf_can_record_build_id() check when it's
requested, so seems easy enough to have it on by default only when it's
supported.
Ubuntu 20 is still in support and on 5.4 kernel so there could be a
small potential to break someones workflow if we had it on unconditionally.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Can perf record make buildid-mmap the default
2024-11-04 10:25 ` James Clark
@ 2024-11-04 18:28 ` Namhyung Kim
0 siblings, 0 replies; 3+ messages in thread
From: Namhyung Kim @ 2024-11-04 18:28 UTC (permalink / raw)
To: James Clark
Cc: Ian Rogers, linux-perf-users, Arnaldo Carvalho de Melo, Jiri Olsa,
Adrian Hunter, Liang, Kan
On Mon, Nov 04, 2024 at 10:25:53AM +0000, James Clark wrote:
>
>
> On 03/11/2024 6:03 am, Ian Rogers wrote:
> > Hi,
> >
> > Without command line flags perf record will post process samples
> > adding DSO buildid events with samples it will also populate the
> > buildid cache. The --buildid-mmap option is superior as mmap events
> > have buildids within them and the buildid cache isn't generated. As
> > buildid-mmap has been available since 5.12, a full major release, can
> > we just make its defaults the defaults for perf record?
> >
> > Thanks,
> > Ian
> >
>
> There's already the perf_can_record_build_id() check when it's requested, so
> seems easy enough to have it on by default only when it's supported.
Probably we can move it to the missing feature detection and enable it
by default.
Thanks,
Namhyung
>
> Ubuntu 20 is still in support and on 5.4 kernel so there could be a small
> potential to break someones workflow if we had it on unconditionally.
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-04 18:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-03 6:03 Can perf record make buildid-mmap the default Ian Rogers
2024-11-04 10:25 ` James Clark
2024-11-04 18:28 ` Namhyung Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.