* [PATCH] clk: imx: imx8-acm: Fix return value check in clk_imx_acm_attach_pm_domains()
@ 2024-10-26 11:24 Yang Yingliang
2024-11-05 10:07 ` Abel Vesa
2024-11-05 10:21 ` Abel Vesa
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2024-10-26 11:24 UTC (permalink / raw)
To: abelvesa, peng.fan, mturquette, sboyd, shawnguo, s.hauer, kernel,
festevam, shengjiu.wang
Cc: linux-clk, imx, yangyingliang, bobo.shaobowang
From: Yang Yingliang <yangyingliang@huawei.com>
If device_link_add() fails, it returns NULL pointer not ERR_PTR(),
replace IS_ERR() with NULL pointer check, and return -EINVAL.
Fixes: d3a0946d7ac9 ("clk: imx: imx8: add audio clock mux driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/clk/imx/clk-imx8-acm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/imx/clk-imx8-acm.c b/drivers/clk/imx/clk-imx8-acm.c
index 6c351050b82a..c169fe53a35f 100644
--- a/drivers/clk/imx/clk-imx8-acm.c
+++ b/drivers/clk/imx/clk-imx8-acm.c
@@ -294,9 +294,9 @@ static int clk_imx_acm_attach_pm_domains(struct device *dev,
DL_FLAG_STATELESS |
DL_FLAG_PM_RUNTIME |
DL_FLAG_RPM_ACTIVE);
- if (IS_ERR(dev_pm->pd_dev_link[i])) {
+ if (!dev_pm->pd_dev_link[i]) {
dev_pm_domain_detach(dev_pm->pd_dev[i], false);
- ret = PTR_ERR(dev_pm->pd_dev_link[i]);
+ ret = -EINVAL;
goto detach_pm;
}
}
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: imx: imx8-acm: Fix return value check in clk_imx_acm_attach_pm_domains()
2024-10-26 11:24 [PATCH] clk: imx: imx8-acm: Fix return value check in clk_imx_acm_attach_pm_domains() Yang Yingliang
@ 2024-11-05 10:07 ` Abel Vesa
2024-11-05 10:21 ` Abel Vesa
1 sibling, 0 replies; 3+ messages in thread
From: Abel Vesa @ 2024-11-05 10:07 UTC (permalink / raw)
To: Yang Yingliang
Cc: abelvesa, peng.fan, mturquette, sboyd, shawnguo, s.hauer, kernel,
festevam, shengjiu.wang, linux-clk, imx, yangyingliang,
bobo.shaobowang
On 24-10-26 19:24:52, Yang Yingliang wrote:
> From: Yang Yingliang <yangyingliang@huawei.com>
>
> If device_link_add() fails, it returns NULL pointer not ERR_PTR(),
> replace IS_ERR() with NULL pointer check, and return -EINVAL.
>
> Fixes: d3a0946d7ac9 ("clk: imx: imx8: add audio clock mux driver")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> drivers/clk/imx/clk-imx8-acm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/imx/clk-imx8-acm.c b/drivers/clk/imx/clk-imx8-acm.c
> index 6c351050b82a..c169fe53a35f 100644
> --- a/drivers/clk/imx/clk-imx8-acm.c
> +++ b/drivers/clk/imx/clk-imx8-acm.c
> @@ -294,9 +294,9 @@ static int clk_imx_acm_attach_pm_domains(struct device *dev,
> DL_FLAG_STATELESS |
> DL_FLAG_PM_RUNTIME |
> DL_FLAG_RPM_ACTIVE);
> - if (IS_ERR(dev_pm->pd_dev_link[i])) {
> + if (!dev_pm->pd_dev_link[i]) {
> dev_pm_domain_detach(dev_pm->pd_dev[i], false);
> - ret = PTR_ERR(dev_pm->pd_dev_link[i]);
> + ret = -EINVAL;
> goto detach_pm;
> }
> }
> --
> 2.33.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: imx: imx8-acm: Fix return value check in clk_imx_acm_attach_pm_domains()
2024-10-26 11:24 [PATCH] clk: imx: imx8-acm: Fix return value check in clk_imx_acm_attach_pm_domains() Yang Yingliang
2024-11-05 10:07 ` Abel Vesa
@ 2024-11-05 10:21 ` Abel Vesa
1 sibling, 0 replies; 3+ messages in thread
From: Abel Vesa @ 2024-11-05 10:21 UTC (permalink / raw)
To: abelvesa, peng.fan, mturquette, sboyd, shawnguo, s.hauer, kernel,
festevam, shengjiu.wang, Yang Yingliang
Cc: linux-clk, imx, yangyingliang, bobo.shaobowang
On Sat, 26 Oct 2024 19:24:52 +0800, Yang Yingliang wrote:
> If device_link_add() fails, it returns NULL pointer not ERR_PTR(),
> replace IS_ERR() with NULL pointer check, and return -EINVAL.
>
>
Applied, thanks!
[1/1] clk: imx: imx8-acm: Fix return value check in clk_imx_acm_attach_pm_domains()
commit: 81a206d736c19139d3863b79e7174f9e98b45499
Best regards,
--
Abel Vesa <abel.vesa@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-05 10:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-26 11:24 [PATCH] clk: imx: imx8-acm: Fix return value check in clk_imx_acm_attach_pm_domains() Yang Yingliang
2024-11-05 10:07 ` Abel Vesa
2024-11-05 10:21 ` Abel Vesa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.