[PATCH] CI: Fix package installation for Coverity run

[PATCH] CI: Fix package installation for Coverity run

[Andrew Cooper]

Something has changed recently in the Github Actions environment and the
golang metapacakge resolves to something that no longer exists:

  https://github.com/xen-project/xen/actions/runs/11539340171/job/32120834909

Update metadata before installing, which fixes things.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Anthony PERARD <anthony.perard@vates.tech>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Michal Orzel <michal.orzel@amd.com>
CC: Doug Goldstein <cardoe@cardoe.com>
CC: Roger Pau Monné <roger.pau@citrix.com>

Example dry run with this fix:

  https://github.com/andyhhp/xen/actions/runs/11692180675/job/32560954258
---
 .github/workflows/coverity.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml
index 984636eb4635..a6c2819b0a24 100644
--- a/.github/workflows/coverity.yml
+++ b/.github/workflows/coverity.yml
@@ -12,6 +12,7 @@ jobs:
     steps:
     - name: Install build dependencies
       run: |
+        sudo apt-get update
         sudo apt-get install -y \
           build-essential \
           git-core \
-- 
2.39.5

Re: [PATCH] CI: Fix package installation for Coverity run

[Roger Pau Monné]

On Tue, Nov 05, 2024 at 08:46:03PM +0000, Andrew Cooper wrote:
> Something has changed recently in the Github Actions environment and the
> golang metapacakge resolves to something that no longer exists:
> 
>   https://github.com/xen-project/xen/actions/runs/11539340171/job/32120834909
> 
> Update metadata before installing, which fixes things.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Seems like the current Ubuntu image has a stale apt cache?  It's good
practice to update before we install anyway.

Thanks, Roger.

Re: [PATCH] CI: Fix package installation for Coverity run

[Stefano Stabellini]

[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]

On Tue, 5 Nov 2024, Andrew Cooper wrote:
> Something has changed recently in the Github Actions environment and the
> golang metapacakge resolves to something that no longer exists:
> 
>   https://github.com/xen-project/xen/actions/runs/11539340171/job/32120834909
> 
> Update metadata before installing, which fixes things.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> CC: Anthony PERARD <anthony.perard@vates.tech>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Michal Orzel <michal.orzel@amd.com>
> CC: Doug Goldstein <cardoe@cardoe.com>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> 
> Example dry run with this fix:
> 
>   https://github.com/andyhhp/xen/actions/runs/11692180675/job/32560954258
> ---
>  .github/workflows/coverity.yml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml
> index 984636eb4635..a6c2819b0a24 100644
> --- a/.github/workflows/coverity.yml
> +++ b/.github/workflows/coverity.yml
> @@ -12,6 +12,7 @@ jobs:
>      steps:
>      - name: Install build dependencies
>        run: |
> +        sudo apt-get update
>          sudo apt-get install -y \
>            build-essential \
>            git-core \
> -- 
> 2.39.5
> 

Re: [PATCH] CI: Fix package installation for Coverity run

[Andrew Cooper]

On 06/11/2024 11:40 am, Roger Pau Monné wrote:
> On Tue, Nov 05, 2024 at 08:46:03PM +0000, Andrew Cooper wrote:
>> Something has changed recently in the Github Actions environment and the
>> golang metapacakge resolves to something that no longer exists:
>>
>>   https://github.com/xen-project/xen/actions/runs/11539340171/job/32120834909
>>
>> Update metadata before installing, which fixes things.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
>
> Seems like the current Ubuntu image has a stale apt cache?  It's good
> practice to update before we install anyway.

Thanks, and yeah.   As chance would have it, the problem resolved itself
in this mornings run, but we should take the patch anyway.

A couple of weeks ago, they did strip out one of the versions of Go, but
it wasn't the version of Go we were trying to use.  But in hindsight,
that doesn't mean that the metadata was kept properly up to date.

~Andrew