Re: [PATCH libmnl] whitespace: remove spacing irregularities

[Duncan Roe <duncan_roe@optusnet.com.au>]

Hi Pablo,

On Mon, Nov 11, 2024 at 11:30:08AM +0100, Pablo Neira Ayuso wrote:
> On Mon, Nov 11, 2024 at 01:56:08PM +1100, Duncan Roe wrote:
> > Two distinct actions:
> >  1. Remove trailing spaces and tabs.
> >  2. Remove spaces that are followed by a tab, inserting extra tabs
> >     as required.
> > Action 2 is only performed in the indent region of a line.
> >
> > Signed-off-by: Duncan Roe <duncan_roe@optusnet.com.au>
> > ---
> >  include/linux/netlink.h | 6 +++---
> >  src/callback.c          | 4 ++--
> >  src/socket.c            | 6 +++---
> >  3 files changed, 8 insertions(+), 8 deletions(-)
>
> Submit uapi/netlink.h update upstream via netdev@
>
> This is a cached copy of uapi/netlink.h
>
> If I take this, the extra line spaces and indentation will come back
> sooner or later.
>
> Thanks.

Thanks for that advice, I've submitted a v2 which only fixes spacing in 2
.c files. The .c files are the ones giving me grief because q, the editor I
use, is configured to fix spacing on saving any file. I could change the
configuration but would rather not.

As for uapi/linux/netlink.h, well hmm. One of the q editor's "party tricks"
is to go through the entire kernel tree correcting all the space irregularities.
I've wondered about sending a kernel-wide patch except there are a few
sources which seem to assume 4-char tabs: I'd leave them out for now.

q finds 120 space-irregular files under uapi/linux alone, but obviously only a
few are appropriate for netdev@.

Just these 2?

| include/uapi/linux/netlink.h                        |   6 +++---
| include/uapi/linux/rtnetlink.h                      |   8 ++++----

Or these as well?

| include/uapi/linux/netfilter/nf_conntrack_common.h  |   2 +-
| include/uapi/linux/netfilter/nfnetlink.h            |   6 +++---
| include/uapi/linux/netfilter/nfnetlink_compat.h     |   8 ++++----
| include/uapi/linux/netfilter/x_tables.h             |   4 ++--
| include/uapi/linux/netfilter/xt_NFQUEUE.h           |   2 +-
| include/uapi/linux/netfilter/xt_ecn.h               |   2 +-
| include/uapi/linux/netfilter_arp/arp_tables.h       |   2 +-
| include/uapi/linux/netfilter_bridge.h               |   2 +-
| include/uapi/linux/netfilter_bridge/ebt_802_3.h     |   2 +-
| include/uapi/linux/netfilter_bridge/ebt_among.h     |   4 ++--
| include/uapi/linux/netfilter_bridge/ebt_vlan.h      |   2 +-
| include/uapi/linux/netfilter_bridge/ebtables.h      |  10 +++++-----
| include/uapi/linux/netfilter_ipv4.h                 |   2 +-
| include/uapi/linux/netfilter_ipv4/ip_tables.h       |   2 +-
| include/uapi/linux/netfilter_ipv4/ipt_ECN.h         |   2 +-
| include/uapi/linux/netfilter_ipv6.h                 |   4 ++--
| include/uapi/linux/netfilter_ipv6/ip6_tables.h      |   6 +++---
| include/uapi/linux/netfilter_ipv6/ip6t_ipv6header.h |   2 +-

and what about this lot?

| include/uapi/linux/ax25.h                           |  14 +++++++-------
| include/uapi/linux/icmpv6.h                         |  24 ++++++++++++------------
| include/uapi/linux/if.h                             |   6 +++---
| include/uapi/linux/if_eql.h                         |   2 +-
| include/uapi/linux/if_hippi.h                       |   6 +++---
| include/uapi/linux/if_plip.h                        |   2 +-
| include/uapi/linux/if_pppox.h                       |  14 +++++++-------
| include/uapi/linux/if_slip.h                        |   8 ++++----
| include/uapi/linux/if_tun.h                         |   8 ++++----
| include/uapi/linux/if_vlan.h                        |   6 +++---
| include/uapi/linux/in.h                             |   2 +-
| include/uapi/linux/in6.h                            |   8 ++++----
| include/uapi/linux/inet_diag.h                      |   2 +-
| include/uapi/linux/ip.h                             |   2 +-
| include/uapi/linux/ipv6.h                           |   4 ++--
| include/uapi/linux/ipv6_route.h                     |   6 +++---
| include/uapi/linux/netdevice.h                      |  14 +++++++-------
| include/uapi/linux/ppp_defs.h                       |   2 +-
| include/uapi/linux/sockios.h                        |   8 ++++----
| include/uapi/linux/x25.h                            |   4 ++--

Any advice greatly appreciated,

Cheers ... Duncan.