* [PATCH] uboot-sign: fix concat_dtb arguments
@ 2024-11-07 17:10 Clayton Casciato
2024-11-14 13:35 ` Clayton Casciato
0 siblings, 1 reply; 4+ messages in thread
From: Clayton Casciato @ 2024-11-07 17:10 UTC (permalink / raw)
To: openembedded-core; +Cc: randy.macleod, yoann.congal
Fixes [YOCTO #15642]
Ensure empty argument passed from do_uboot_assemble_fitimage is passed to
concat_dtb
Signed-off-by: Clayton Casciato <majortomtosourcecontrol@gmail.com>
---
Sponsor: 21SoftWare LLC
meta/classes-recipe/uboot-sign.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes-recipe/uboot-sign.bbclass b/meta/classes-recipe/uboot-sign.bbclass
index 3e5f5dcf66..a17be745ce 100644
--- a/meta/classes-recipe/uboot-sign.bbclass
+++ b/meta/classes-recipe/uboot-sign.bbclass
@@ -338,7 +338,7 @@ uboot_assemble_fitimage_helper() {
binary="$2"
if [ "${UBOOT_SIGN_ENABLE}" = "1" -a -n "${UBOOT_DTB_BINARY}" ] ; then
- concat_dtb $type $binary
+ concat_dtb "$type" "$binary"
fi
if [ "${UBOOT_FITIMAGE_ENABLE}" = "1" -a -n "${SPL_DTB_BINARY}" ]; then
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] uboot-sign: fix concat_dtb arguments
2024-11-07 17:10 [PATCH] uboot-sign: fix concat_dtb arguments Clayton Casciato
@ 2024-11-14 13:35 ` Clayton Casciato
2024-11-14 14:35 ` [OE-core] " Mathieu Dubois-Briand
0 siblings, 1 reply; 4+ messages in thread
From: Clayton Casciato @ 2024-11-14 13:35 UTC (permalink / raw)
To: openembedded-core; +Cc: randy.macleod, yoann.congal
Hello!
I am looking for feedback and/or the status for this patch.
Thanks!
--
Clayton Casciato
On 11/7/24 10:10 AM, Clayton Casciato wrote:
> Fixes [YOCTO #15642]
>
> Ensure empty argument passed from do_uboot_assemble_fitimage is passed to
> concat_dtb
>
> Signed-off-by: Clayton Casciato <majortomtosourcecontrol@gmail.com>
> ---
> Sponsor: 21SoftWare LLC
>
> meta/classes-recipe/uboot-sign.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes-recipe/uboot-sign.bbclass b/meta/classes-recipe/uboot-sign.bbclass
> index 3e5f5dcf66..a17be745ce 100644
> --- a/meta/classes-recipe/uboot-sign.bbclass
> +++ b/meta/classes-recipe/uboot-sign.bbclass
> @@ -338,7 +338,7 @@ uboot_assemble_fitimage_helper() {
> binary="$2"
>
> if [ "${UBOOT_SIGN_ENABLE}" = "1" -a -n "${UBOOT_DTB_BINARY}" ] ; then
> - concat_dtb $type $binary
> + concat_dtb "$type" "$binary"
> fi
>
> if [ "${UBOOT_FITIMAGE_ENABLE}" = "1" -a -n "${SPL_DTB_BINARY}" ]; then
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OE-core] [PATCH] uboot-sign: fix concat_dtb arguments
2024-11-14 13:35 ` Clayton Casciato
@ 2024-11-14 14:35 ` Mathieu Dubois-Briand
2024-11-14 14:49 ` Clayton Casciato
0 siblings, 1 reply; 4+ messages in thread
From: Mathieu Dubois-Briand @ 2024-11-14 14:35 UTC (permalink / raw)
To: majortomtosourcecontrol; +Cc: openembedded-core, randy.macleod, yoann.congal
On Thu, Nov 14, 2024 at 06:35:29AM -0700, Clayton Casciato via lists.openembedded.org wrote:
> Hello!
>
> I am looking for feedback and/or the status for this patch.
>
> Thanks!
>
Hi Clayton,
This patch has now been merged in master:
https://git.openembedded.org/openembedded-core/commit/?id=b3c473785e5ceef677ff2b77c5fc17f5704c622f
--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OE-core] [PATCH] uboot-sign: fix concat_dtb arguments
2024-11-14 14:35 ` [OE-core] " Mathieu Dubois-Briand
@ 2024-11-14 14:49 ` Clayton Casciato
0 siblings, 0 replies; 4+ messages in thread
From: Clayton Casciato @ 2024-11-14 14:49 UTC (permalink / raw)
To: openembedded-core, mathieu.dubois-briand; +Cc: randy.macleod, yoann.congal
> On Thu, Nov 14, 2024 at 06:35:29AM -0700, Clayton Casciato via lists.openembedded.org wrote:
>> Hello!
>>
>> I am looking for feedback and/or the status for this patch.
>>
>> Thanks!
>>
>
> Hi Clayton,
>
> This patch has now been merged in master:
> https://git.openembedded.org/openembedded-core/commit/?id=b3c473785e5ceef677ff2b77c5fc17f5704c622f
>
Hi, Mathieu!
That's good to see.
Thank you for the quick response and link!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-11-14 14:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-07 17:10 [PATCH] uboot-sign: fix concat_dtb arguments Clayton Casciato
2024-11-14 13:35 ` Clayton Casciato
2024-11-14 14:35 ` [OE-core] " Mathieu Dubois-Briand
2024-11-14 14:49 ` Clayton Casciato
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.