From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org,
Mike Manning <mmanning@vyatta.att-mail.com>,
Ed Santiago <santiago@redhat.com>,
Paul Holzinger <pholzing@redhat.com>
Subject: Re: [PATCH RFC net 0/2] Fix race between datagram socket address change and rehash
Date: Fri, 15 Nov 2024 14:01:23 +1100 [thread overview]
Message-ID: <Zza5gypLK6jWDWov@zatzit> (raw)
In-Reply-To: <20241114215414.3357873-1-sbrivio@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 565 bytes --]
On Thu, Nov 14, 2024 at 10:54:12PM +0100, Stefano Brivio wrote:
> Patch 2/2 fixes a race condition in the lookup of datagram sockets
> between address change (triggered by connect()) and rehashing.
>
> Patch 1/2 is a small optimisation to simplify 2/2.
These both LGTM, but I don't know the code in question well enough to
claim to have done a full review.
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2024-11-15 3:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 21:54 [PATCH RFC net 0/2] Fix race between datagram socket address change and rehash Stefano Brivio
2024-11-14 21:54 ` [PATCH RFC net 1/2] datagram: Rehash sockets only if local address changed for their family Stefano Brivio
2024-11-15 17:48 ` Willem de Bruijn
2024-11-15 18:10 ` Stefano Brivio
2024-11-15 18:23 ` Stefano Brivio
2024-11-19 12:33 ` Stefano Brivio
2024-11-19 14:54 ` Willem de Bruijn
2024-11-14 21:54 ` [PATCH RFC net 2/2] datagram, udp: Set local address and rehash socket atomically against lookup Stefano Brivio
2024-11-15 17:50 ` Willem de Bruijn
2024-11-15 18:10 ` Stefano Brivio
2024-11-15 19:55 ` Kuniyuki Iwashima
2024-11-19 12:33 ` Stefano Brivio
2024-11-17 6:40 ` kernel test robot
2024-11-15 3:01 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zza5gypLK6jWDWov@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=edumazet@google.com \
--cc=mmanning@vyatta.att-mail.com \
--cc=netdev@vger.kernel.org \
--cc=pholzing@redhat.com \
--cc=santiago@redhat.com \
--cc=sbrivio@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.