All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wen Gong <wgong@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 9/9] mac80211: save transmit power envelope element and power constraint
Date: Fri, 13 Aug 2021 16:47:55 +0800	[thread overview]
Message-ID: <a056e32d4911400fb0822bf02167e91c@codeaurora.org> (raw)
In-Reply-To: <1273cc1a399a7457c3d908648a7651c8fe9b93f3.camel@sipsolutions.net>

On 2021-08-13 15:25, Johannes Berg wrote:
> On Fri, 2021-08-13 at 09:19 +0200, Johannes Berg wrote:
>> 
>> > > 2) Should we at least check it again from the protected beacon or such
>> > > after association, so we don't blindly trust the probe response or
>> > > beacon (received during scan, not validated) at least when BIGTK is in
>> > > use?
>> >
>> > May we add support for BIGTK in future with another patch?
>> 
>> We already have BIGTK support in mac80211, so if we don't do that now
>> we're almost certainly not going to do it, so I'd really prefer if you
>> did it here, or if a separate patch still did it now.
> 
> Actually, I should say though - the question was more whether we even
> need/want that, rather than whether we can do it later or not.
> 
> If we should protect this data/information then IMHO we should do it
> now, but it's not clear to me that we should, given that we also don't
> have encrypted association response and we still take information from
> there too, etc.
> 
> johannes
I prefer to add a new enum(not use BSS_CHANGED_TXPOWER),e.g, 
BSS_CHANGED_PWR_ENV.
And add check in ieee80211_rx_mgmt_beacon() as well as 
ieee80211_handle_pwr_constr(),
when the value of pwr_reduction or content of elems.tx_pwr_env changed,
save the pwr_reduction and elems.tx_pwr_env to ieee80211_bss_conf, and 
notify lower
driver with BSS_CHANGED_PWR_ENV, then lower driver will do next action.

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Wen Gong <wgong@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 9/9] mac80211: save transmit power envelope element and power constraint
Date: Fri, 13 Aug 2021 16:47:55 +0800	[thread overview]
Message-ID: <a056e32d4911400fb0822bf02167e91c@codeaurora.org> (raw)
In-Reply-To: <1273cc1a399a7457c3d908648a7651c8fe9b93f3.camel@sipsolutions.net>

On 2021-08-13 15:25, Johannes Berg wrote:
> On Fri, 2021-08-13 at 09:19 +0200, Johannes Berg wrote:
>> 
>> > > 2) Should we at least check it again from the protected beacon or such
>> > > after association, so we don't blindly trust the probe response or
>> > > beacon (received during scan, not validated) at least when BIGTK is in
>> > > use?
>> >
>> > May we add support for BIGTK in future with another patch?
>> 
>> We already have BIGTK support in mac80211, so if we don't do that now
>> we're almost certainly not going to do it, so I'd really prefer if you
>> did it here, or if a separate patch still did it now.
> 
> Actually, I should say though - the question was more whether we even
> need/want that, rather than whether we can do it later or not.
> 
> If we should protect this data/information then IMHO we should do it
> now, but it's not clear to me that we should, given that we also don't
> have encrypted association response and we still take information from
> there too, etc.
> 
> johannes
I prefer to add a new enum(not use BSS_CHANGED_TXPOWER),e.g, 
BSS_CHANGED_PWR_ENV.
And add check in ieee80211_rx_mgmt_beacon() as well as 
ieee80211_handle_pwr_constr(),
when the value of pwr_reduction or content of elems.tx_pwr_env changed,
save the pwr_reduction and elems.tx_pwr_env to ieee80211_bss_conf, and 
notify lower
driver with BSS_CHANGED_PWR_ENV, then lower driver will do next action.

  reply	other threads:[~2021-08-13  8:48 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17 20:19 [PATCH 0/9] cfg80211/mac80211: Add support for 6GHZ STA for various modes : LPI, SP and VLP Wen Gong
2021-05-17 20:19 ` Wen Gong
2021-05-17 20:19 ` [PATCH 1/9] cfg80211: add power type definition for 6G Hz Wen Gong
2021-05-17 20:19   ` Wen Gong
2021-07-23  9:22   ` Johannes Berg
2021-07-23  9:22     ` Johannes Berg
2021-05-17 20:19 ` [PATCH 2/9] mac80211: add definition of regulatory info in 6G Hz operation information Wen Gong
2021-05-17 20:19   ` Wen Gong
2021-05-17 20:19 ` [PATCH 3/9] mac80211: add parse " Wen Gong
2021-05-17 20:19   ` Wen Gong
2021-07-23  9:23   ` Johannes Berg
2021-07-23  9:23     ` Johannes Berg
2021-05-17 20:19 ` [PATCH 4/9] cfg80211: add definition for 6G power spectral density(psd) Wen Gong
2021-05-17 20:19   ` Wen Gong
2021-07-23  9:24   ` Johannes Berg
2021-07-23  9:24     ` Johannes Berg
2021-07-30 10:00     ` Wen Gong
2021-07-30 10:00       ` Wen Gong
2021-05-17 20:19 ` [PATCH 5/9] cfg80211: save power spectral density(psd) of regulatory rule Wen Gong
2021-05-17 20:19   ` Wen Gong
2021-07-23  9:27   ` Johannes Berg
2021-07-23  9:27     ` Johannes Berg
2021-07-30 10:06     ` Wen Gong
2021-07-30 10:06       ` Wen Gong
2021-05-17 20:19 ` [PATCH 6/9] mac80211: add definition for transmit power envelope element Wen Gong
2021-05-17 20:19   ` Wen Gong
2021-07-23  9:29   ` Johannes Berg
2021-07-23  9:29     ` Johannes Berg
2021-07-23  9:31   ` Johannes Berg
2021-07-23  9:31     ` Johannes Berg
2021-07-30 10:27     ` Wen Gong
2021-07-30 10:27       ` Wen Gong
2021-05-17 20:19 ` [PATCH 7/9] mac80211: add parse " Wen Gong
2021-05-17 20:19   ` Wen Gong
2021-07-23  9:33   ` Johannes Berg
2021-07-23  9:33     ` Johannes Berg
2021-07-30 10:16     ` Wen Gong
2021-07-30 10:16       ` Wen Gong
2021-05-17 20:19 ` [PATCH 8/9] mac80211: add transmit power envelope element and power constraint in bss_conf Wen Gong
2021-05-17 20:19   ` Wen Gong
2021-07-23  9:33   ` Johannes Berg
2021-07-23  9:33     ` Johannes Berg
2021-05-17 20:19 ` [PATCH 9/9] mac80211: save transmit power envelope element and power constraint Wen Gong
2021-05-17 20:19   ` Wen Gong
2021-07-23  9:38   ` Johannes Berg
2021-07-23  9:38     ` Johannes Berg
2021-07-30 10:47     ` Wen Gong
2021-07-30 10:47       ` Wen Gong
2021-08-03  8:53       ` Wen Gong
2021-08-03  8:53         ` Wen Gong
2021-08-13  7:19       ` Johannes Berg
2021-08-13  7:19         ` Johannes Berg
2021-08-13  7:25         ` Johannes Berg
2021-08-13  7:25           ` Johannes Berg
2021-08-13  8:47           ` Wen Gong [this message]
2021-08-13  8:47             ` Wen Gong
2021-08-13  8:53             ` Johannes Berg
2021-08-13  8:53               ` Johannes Berg
2021-08-13  9:16               ` Wen Gong
2021-08-13  9:16                 ` Wen Gong
2021-08-13 10:11                 ` Johannes Berg
2021-08-13 10:11                   ` Johannes Berg
2021-08-13 10:29                   ` Wen Gong
2021-08-13 10:29                     ` Wen Gong
2021-08-13  8:13         ` Wen Gong
2021-08-13  8:13           ` Wen Gong
2021-05-25 10:04 ` [PATCH 0/9] cfg80211/mac80211: Add support for 6GHZ STA for various modes : LPI, SP and VLP Wen Gong
2021-05-25 10:04   ` Wen Gong
2021-06-15  8:52   ` Wen Gong
2021-06-15  8:52     ` Wen Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a056e32d4911400fb0822bf02167e91c@codeaurora.org \
    --to=wgong@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.