From: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
To: Peter Oh <peter.oh@eero.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH 1/4] mac80211: save HE oper info in BSS config for mesh
Date: Tue, 20 Oct 2020 08:34:52 -0700 [thread overview]
Message-ID: <a08d1aae3c4359f736f25053c3075afd@codeaurora.org> (raw)
In-Reply-To: <cc254230-5909-b77a-8c13-2c769a618660@eero.com>
>> + if (ieee80211_get_he_iftype_cap(sband, NL80211_IFTYPE_MESH_POINT) &&
>> + !(sdata->vif.bss_conf.chandef.width ==
>> NL80211_CHAN_WIDTH_20_NOHT ||
>> + sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_5 ||
>> + sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_10))
>> + return;
>
> Are you update BSS only for sub-20Mhz?
>
> Shouldn't you remove "!" for 20~160Mhz?
>
>
> Thanks,
>
> Peter
Thanks Peter for the review..Might have been a typo and I missed it..
I will fix this and submit next revision.
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
To: Peter Oh <peter.oh@eero.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/4] mac80211: save HE oper info in BSS config for mesh
Date: Tue, 20 Oct 2020 08:34:52 -0700 [thread overview]
Message-ID: <a08d1aae3c4359f736f25053c3075afd@codeaurora.org> (raw)
In-Reply-To: <cc254230-5909-b77a-8c13-2c769a618660@eero.com>
>> + if (ieee80211_get_he_iftype_cap(sband, NL80211_IFTYPE_MESH_POINT) &&
>> + !(sdata->vif.bss_conf.chandef.width ==
>> NL80211_CHAN_WIDTH_20_NOHT ||
>> + sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_5 ||
>> + sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_10))
>> + return;
>
> Are you update BSS only for sub-20Mhz?
>
> Shouldn't you remove "!" for 20~160Mhz?
>
>
> Thanks,
>
> Peter
Thanks Peter for the review..Might have been a typo and I missed it..
I will fix this and submit next revision.
next prev parent reply other threads:[~2020-10-20 15:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 2:18 [PATCH 0/4] ath11k: add support for 256 bitmap in Block ack and duration based RTS threshold Pradeep Kumar Chitrapu
2020-10-09 2:18 ` Pradeep Kumar Chitrapu
2020-10-09 2:18 ` [PATCH 1/4] mac80211: save HE oper info in BSS config for mesh Pradeep Kumar Chitrapu
2020-10-09 2:18 ` Pradeep Kumar Chitrapu
2020-10-19 20:29 ` Peter Oh
2020-10-19 20:29 ` Peter Oh
2020-10-20 15:34 ` Pradeep Kumar Chitrapu [this message]
2020-10-20 15:34 ` Pradeep Kumar Chitrapu
2020-10-09 2:18 ` [PATCH 2/4] ath11k: fix incorrect wmi param for configuring HE operation Pradeep Kumar Chitrapu
2020-10-09 2:18 ` Pradeep Kumar Chitrapu
2020-10-09 2:18 ` [PATCH 3/4] ath11k: support TXOP duration based RTS threshold Pradeep Kumar Chitrapu
2020-10-09 2:18 ` Pradeep Kumar Chitrapu
2020-10-09 2:18 ` [PATCH 4/4] ath11k: mesh: add support for 256 bitmap in blockack frames in 11ax Pradeep Kumar Chitrapu
2020-10-09 2:18 ` Pradeep Kumar Chitrapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a08d1aae3c4359f736f25053c3075afd@codeaurora.org \
--to=pradeepc@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=peter.oh@eero.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.