Re: [PATCH v4 0/3] Selective Fetch and async flip

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Tue, 2025-12-09 at 20:26 +0200, Ville Syrjälä wrote:
> On Thu, Dec 04, 2025 at 09:07:15AM +0200, Jouni Högander wrote:
> > This patch set contains fixes for Selective Fetch async flip
> > sequences. On async flip selective fetch is choosing full frame
> > update. Also subsequent flip/update is still using full frame
> > update
> > to ensure plane with pending async flip is not taken in to
> > selective
> > fetch/update.
> > 
> > v4:
> >   - rework if-else if to if-if
> >   - added comment updated
> >   - check crtc_state->async_flip_planes in
> >     psr2_sel_fetch_pipe_state_supported
> > v3:
> >   - rebase
> >   - fix old_crtc_state->pipe_srcsz_early_tpt
> >   - fix using intel_atomic_get_new_crtc_state
> > v2:
> >   - check also crtc_state->async_flip_planes in
> >     psr2_sel_fetch_plane_state_supported
> > 
> > Jouni Högander (3):
> >   drm/i915/psr: Set plane id bit in crtc_state->async_flip_planes
> > for
> >     PSR
> >   drm/i915/psr: Perform full frame update on async flip
> >   drm/i915/psr: Allow async flip when Selective Fetch enabled
> 
> Series is
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Thank you Ville for your review. This set is now pushed to drm-intel-
next.

BR,

Jouni Högander

> 
> When testing this I saw that we get stuck into full frame mode
> all the time. But that seems to be a pre-existing issues caused
> by the broken selective fetch area calculation code. I suppose
> now that I have a laptop with a PSR2 panel I might have to dig out
> that branch of mine where I attempted to rewrite the whoile thing
> and figure out what was wrong with it...
> 
> > 
> >  drivers/gpu/drm/i915/display/intel_display.c |  8 --------
> >  drivers/gpu/drm/i915/display/intel_plane.c   | 10 ++++++----
> >  drivers/gpu/drm/i915/display/intel_psr.c     |  3 ++-
> >  3 files changed, 8 insertions(+), 13 deletions(-)
> > 
> > -- 
> > 2.43.0
>