* Re: [PATCH] kernel/bpf/verifier: removed an unused parameter in check_func_proto
[not found] <20260105140236.7321-1-chensong_2000@189.cn>
@ 2026-01-05 16:32 ` Yonghong Song
0 siblings, 0 replies; 3+ messages in thread
From: Yonghong Song @ 2026-01-05 16:32 UTC (permalink / raw)
To: chensong_2000, ast, daniel, john.fastabend, andrii, martin.lau,
eddyz87, song, kpsingh, sdf, haoluo, jolsa
Cc: bpf, linux-kernel
On 1/5/26 6:02 AM, chensong_2000@189.cn wrote:
> From: Song Chen <chensong_2000@189.cn>
>
> I accidentally saw an unused parameter in check_func_proto,
> it's harmless but better be removed.
>
> Signed-off-by: Song Chen <chensong_2000@189.cn>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] kernel/bpf/verifier: removed an unused parameter in check_func_proto
@ 2026-01-05 15:50 chensong_2000
2026-01-13 18:17 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 3+ messages in thread
From: chensong_2000 @ 2026-01-05 15:50 UTC (permalink / raw)
To: ast, andrii, jolsa; +Cc: bpf, linux-kernel, Song Chen
From: Song Chen <chensong_2000@189.cn>
I accidentally saw an unused parameter in check_func_proto,
it's harmless but better be removed.
Signed-off-by: Song Chen <chensong_2000@189.cn>
---
kernel/bpf/verifier.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index f0ca69f888fa..30232863bb47 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -10349,7 +10349,7 @@ static bool check_btf_id_ok(const struct bpf_func_proto *fn)
return true;
}
-static int check_func_proto(const struct bpf_func_proto *fn, int func_id)
+static int check_func_proto(const struct bpf_func_proto *fn)
{
return check_raw_mode_ok(fn) &&
check_arg_pair_ok(fn) &&
@@ -11524,7 +11524,7 @@ static int check_helper_call(struct bpf_verifier_env *env, struct bpf_insn *insn
memset(&meta, 0, sizeof(meta));
meta.pkt_access = fn->pkt_access;
- err = check_func_proto(fn, func_id);
+ err = check_func_proto(fn);
if (err) {
verifier_bug(env, "incorrect func proto %s#%d", func_id_name(func_id), func_id);
return err;
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-13 18:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260105140236.7321-1-chensong_2000@189.cn>
2026-01-05 16:32 ` [PATCH] kernel/bpf/verifier: removed an unused parameter in check_func_proto Yonghong Song
2026-01-05 15:50 chensong_2000
2026-01-13 18:17 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.