All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nirmoy <nirmodas-5C7GfCeVMHo@public.gmane.org>
To: "Koenig,
	Christian" <Christian.Koenig-5C7GfCeVMHo@public.gmane.org>,
	Nirmoy Das <nirmoy.aiemd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Deucher,
	Alexander" <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org>
Cc: "Das, Nirmoy" <Nirmoy.Das-5C7GfCeVMHo@public.gmane.org>,
	"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] drm/amdgpu: remove unused variable in amdgpu_gfx_kiq_free_ring
Date: Wed, 23 Oct 2019 15:27:21 +0000	[thread overview]
Message-ID: <a177beed-e7a4-df24-e3f2-97c86b9d3a88@amd.com> (raw)
In-Reply-To: <b1569003-1b14-d71d-32b8-3695677189ac-5C7GfCeVMHo@public.gmane.org>

Thanks Updated and pushed to  brahma HEAD:refs/for/amd-staging-drm-next

On 10/23/19 5:21 PM, Koenig, Christian wrote:
> Maybe say parameter instead of variable in the subject.
>
> Am 23.10.19 um 16:35 schrieb Nirmoy Das:
>> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
> Apart from that Acked-by: Christian König <christian.koenig@amd.com>
>
>> ---
>>    drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 3 +--
>>    drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 3 +--
>>    drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c  | 2 +-
>>    drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c   | 2 +-
>>    drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c   | 2 +-
>>    5 files changed, 5 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
>> index 069515f57c2a..c9d1fada6188 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
>> @@ -319,8 +319,7 @@ int amdgpu_gfx_kiq_init_ring(struct amdgpu_device *adev,
>>    	return r;
>>    }
>>    
>> -void amdgpu_gfx_kiq_free_ring(struct amdgpu_ring *ring,
>> -			      struct amdgpu_irq_src *irq)
>> +void amdgpu_gfx_kiq_free_ring(struct amdgpu_ring *ring)
>>    {
>>    	amdgpu_device_wb_free(ring->adev, ring->adev->virt.reg_val_offs);
>>    	amdgpu_ring_fini(ring);
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
>> index 35eff9e6ce16..459aa9059542 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
>> @@ -330,8 +330,7 @@ int amdgpu_gfx_kiq_init_ring(struct amdgpu_device *adev,
>>    			     struct amdgpu_ring *ring,
>>    			     struct amdgpu_irq_src *irq);
>>    
>> -void amdgpu_gfx_kiq_free_ring(struct amdgpu_ring *ring,
>> -			      struct amdgpu_irq_src *irq);
>> +void amdgpu_gfx_kiq_free_ring(struct amdgpu_ring *ring);
>>    
>>    void amdgpu_gfx_kiq_fini(struct amdgpu_device *adev);
>>    int amdgpu_gfx_kiq_init(struct amdgpu_device *adev,
>> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
>> index 8fca6ab5fa8f..ac43b1af69e3 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
>> @@ -1443,7 +1443,7 @@ static int gfx_v10_0_sw_fini(void *handle)
>>    		amdgpu_ring_fini(&adev->gfx.compute_ring[i]);
>>    
>>    	amdgpu_gfx_mqd_sw_fini(adev);
>> -	amdgpu_gfx_kiq_free_ring(&adev->gfx.kiq.ring, &adev->gfx.kiq.irq);
>> +	amdgpu_gfx_kiq_free_ring(&adev->gfx.kiq.ring);
>>    	amdgpu_gfx_kiq_fini(adev);
>>    
>>    	gfx_v10_0_pfp_fini(adev);
>> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
>> index a7fe0ea24d1f..e4c645da4e28 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
>> @@ -2103,7 +2103,7 @@ static int gfx_v8_0_sw_fini(void *handle)
>>    		amdgpu_ring_fini(&adev->gfx.compute_ring[i]);
>>    
>>    	amdgpu_gfx_mqd_sw_fini(adev);
>> -	amdgpu_gfx_kiq_free_ring(&adev->gfx.kiq.ring, &adev->gfx.kiq.irq);
>> +	amdgpu_gfx_kiq_free_ring(&adev->gfx.kiq.ring);
>>    	amdgpu_gfx_kiq_fini(adev);
>>    
>>    	gfx_v8_0_mec_fini(adev);
>> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
>> index dd345fcedb97..9fe95e7693d5 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
>> @@ -2153,7 +2153,7 @@ static int gfx_v9_0_sw_fini(void *handle)
>>    		amdgpu_ring_fini(&adev->gfx.compute_ring[i]);
>>    
>>    	amdgpu_gfx_mqd_sw_fini(adev);
>> -	amdgpu_gfx_kiq_free_ring(&adev->gfx.kiq.ring, &adev->gfx.kiq.irq);
>> +	amdgpu_gfx_kiq_free_ring(&adev->gfx.kiq.ring);
>>    	amdgpu_gfx_kiq_fini(adev);
>>    
>>    	gfx_v9_0_mec_fini(adev);
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Nirmoy <nirmodas@amd.com>
To: "Koenig, Christian" <Christian.Koenig@amd.com>,
	Nirmoy Das <nirmoy.aiemd@gmail.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>
Cc: "Das, Nirmoy" <Nirmoy.Das@amd.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: remove unused variable in amdgpu_gfx_kiq_free_ring
Date: Wed, 23 Oct 2019 15:27:21 +0000	[thread overview]
Message-ID: <a177beed-e7a4-df24-e3f2-97c86b9d3a88@amd.com> (raw)
Message-ID: <20191023152721.4CV7tvn2hQVAKt7vcy3lH1hxzT9OYD5BOGtAf56bomY@z> (raw)
In-Reply-To: <b1569003-1b14-d71d-32b8-3695677189ac@amd.com>

Thanks Updated and pushed to  brahma HEAD:refs/for/amd-staging-drm-next

On 10/23/19 5:21 PM, Koenig, Christian wrote:
> Maybe say parameter instead of variable in the subject.
>
> Am 23.10.19 um 16:35 schrieb Nirmoy Das:
>> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
> Apart from that Acked-by: Christian König <christian.koenig@amd.com>
>
>> ---
>>    drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 3 +--
>>    drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 3 +--
>>    drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c  | 2 +-
>>    drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c   | 2 +-
>>    drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c   | 2 +-
>>    5 files changed, 5 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
>> index 069515f57c2a..c9d1fada6188 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
>> @@ -319,8 +319,7 @@ int amdgpu_gfx_kiq_init_ring(struct amdgpu_device *adev,
>>    	return r;
>>    }
>>    
>> -void amdgpu_gfx_kiq_free_ring(struct amdgpu_ring *ring,
>> -			      struct amdgpu_irq_src *irq)
>> +void amdgpu_gfx_kiq_free_ring(struct amdgpu_ring *ring)
>>    {
>>    	amdgpu_device_wb_free(ring->adev, ring->adev->virt.reg_val_offs);
>>    	amdgpu_ring_fini(ring);
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
>> index 35eff9e6ce16..459aa9059542 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
>> @@ -330,8 +330,7 @@ int amdgpu_gfx_kiq_init_ring(struct amdgpu_device *adev,
>>    			     struct amdgpu_ring *ring,
>>    			     struct amdgpu_irq_src *irq);
>>    
>> -void amdgpu_gfx_kiq_free_ring(struct amdgpu_ring *ring,
>> -			      struct amdgpu_irq_src *irq);
>> +void amdgpu_gfx_kiq_free_ring(struct amdgpu_ring *ring);
>>    
>>    void amdgpu_gfx_kiq_fini(struct amdgpu_device *adev);
>>    int amdgpu_gfx_kiq_init(struct amdgpu_device *adev,
>> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
>> index 8fca6ab5fa8f..ac43b1af69e3 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
>> @@ -1443,7 +1443,7 @@ static int gfx_v10_0_sw_fini(void *handle)
>>    		amdgpu_ring_fini(&adev->gfx.compute_ring[i]);
>>    
>>    	amdgpu_gfx_mqd_sw_fini(adev);
>> -	amdgpu_gfx_kiq_free_ring(&adev->gfx.kiq.ring, &adev->gfx.kiq.irq);
>> +	amdgpu_gfx_kiq_free_ring(&adev->gfx.kiq.ring);
>>    	amdgpu_gfx_kiq_fini(adev);
>>    
>>    	gfx_v10_0_pfp_fini(adev);
>> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
>> index a7fe0ea24d1f..e4c645da4e28 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
>> @@ -2103,7 +2103,7 @@ static int gfx_v8_0_sw_fini(void *handle)
>>    		amdgpu_ring_fini(&adev->gfx.compute_ring[i]);
>>    
>>    	amdgpu_gfx_mqd_sw_fini(adev);
>> -	amdgpu_gfx_kiq_free_ring(&adev->gfx.kiq.ring, &adev->gfx.kiq.irq);
>> +	amdgpu_gfx_kiq_free_ring(&adev->gfx.kiq.ring);
>>    	amdgpu_gfx_kiq_fini(adev);
>>    
>>    	gfx_v8_0_mec_fini(adev);
>> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
>> index dd345fcedb97..9fe95e7693d5 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
>> @@ -2153,7 +2153,7 @@ static int gfx_v9_0_sw_fini(void *handle)
>>    		amdgpu_ring_fini(&adev->gfx.compute_ring[i]);
>>    
>>    	amdgpu_gfx_mqd_sw_fini(adev);
>> -	amdgpu_gfx_kiq_free_ring(&adev->gfx.kiq.ring, &adev->gfx.kiq.irq);
>> +	amdgpu_gfx_kiq_free_ring(&adev->gfx.kiq.ring);
>>    	amdgpu_gfx_kiq_fini(adev);
>>    
>>    	gfx_v9_0_mec_fini(adev);
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2019-10-23 15:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23 14:35 [PATCH] drm/amdgpu: remove unused variable in amdgpu_gfx_kiq_free_ring Nirmoy Das
2019-10-23 14:35 ` Nirmoy Das
     [not found] ` <20191023143517.57753-1-nirmoy.das-5C7GfCeVMHo@public.gmane.org>
2019-10-23 15:21   ` Koenig, Christian
2019-10-23 15:21     ` Koenig, Christian
     [not found]     ` <b1569003-1b14-d71d-32b8-3695677189ac-5C7GfCeVMHo@public.gmane.org>
2019-10-23 15:27       ` Nirmoy [this message]
2019-10-23 15:27         ` Nirmoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a177beed-e7a4-df24-e3f2-97c86b9d3a88@amd.com \
    --to=nirmodas-5c7gfcevmho@public.gmane.org \
    --cc=Alexander.Deucher-5C7GfCeVMHo@public.gmane.org \
    --cc=Christian.Koenig-5C7GfCeVMHo@public.gmane.org \
    --cc=Nirmoy.Das-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=nirmoy.aiemd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.