All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sibi Sankar <quic_sibis@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	<andersson@kernel.org>, <konrad.dybcio@linaro.org>,
	<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<catalin.marinas@arm.com>, <ulf.hansson@linaro.org>
Cc: <agross@kernel.org>, <conor+dt@kernel.org>,
	<ayan.kumar.halder@amd.com>, <j@jannau.net>,
	<dmitry.baryshkov@linaro.org>, <nfraprado@collabora.com>,
	<m.szyprowski@samsung.com>, <u-kumar1@ti.com>, <peng.fan@nxp.com>,
	<lpieralisi@kernel.org>, <quic_rjendra@quicinc.com>,
	<abel.vesa@linaro.org>, <linux-arm-msm@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <quic_tsoni@quicinc.com>,
	<neil.armstrong@linaro.org>
Subject: Re: [PATCH 2/5] dt-bindings: arm: qcom: Document SC8380XP SoC and boards
Date: Fri, 17 Nov 2023 09:37:18 +0530	[thread overview]
Message-ID: <a17d3739-504a-9502-4a2c-3aeddd96c8fa@quicinc.com> (raw)
In-Reply-To: <2cecb51e-9528-471c-8de0-cb716977c0e0@linaro.org>

Hey Krzysztof,

Thanks for taking time to review the series.

On 10/27/23 13:46, Krzysztof Kozlowski wrote:
> On 25/10/2023 16:24, Sibi Sankar wrote:
>> From: Rajendra Nayak <quic_rjendra@quicinc.com>
>>
>> Document the SC8380XP SoC binding and also the boards using it.
>> Also document the new board id qcp (Qualcomm Compute Platform).
>>
>> Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
>> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/arm/qcom.yaml | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 88b84035e7b1..6145e9ad340c 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -62,6 +62,7 @@ description: |
>>           sc7280
>>           sc8180x
>>           sc8280xp
>> +        sc8380xp
>>           sda660
>>           sdm450
>>           sdm630
>> @@ -110,6 +111,7 @@ description: |
>>           liquid
>>           rdp432-c2
>>           mtp
>> +        qcp
>>           qrd
>>           rb2
>>           ride
>> @@ -1044,6 +1046,12 @@ properties:
>>                 - qcom,sm8550-qrd
>>             - const: qcom,sm8550
>>   
>> +      - items:
>> +          - enum:
>> +              - qcom,sc8380xp-crd
>> +              - qcom,sc8380xp-qcp
>> +          - const: qcom,sc8380xp
> 
> This is some odd placement. Please keep things properly ordered.

will fix this in the next re-spin.

-Sibi

> 
> Best regards,
> Krzysztof
> 

WARNING: multiple messages have this Message-ID (diff)
From: Sibi Sankar <quic_sibis@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	<andersson@kernel.org>, <konrad.dybcio@linaro.org>,
	<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<catalin.marinas@arm.com>, <ulf.hansson@linaro.org>
Cc: <agross@kernel.org>, <conor+dt@kernel.org>,
	<ayan.kumar.halder@amd.com>, <j@jannau.net>,
	<dmitry.baryshkov@linaro.org>, <nfraprado@collabora.com>,
	<m.szyprowski@samsung.com>, <u-kumar1@ti.com>, <peng.fan@nxp.com>,
	<lpieralisi@kernel.org>, <quic_rjendra@quicinc.com>,
	<abel.vesa@linaro.org>, <linux-arm-msm@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <quic_tsoni@quicinc.com>,
	<neil.armstrong@linaro.org>
Subject: Re: [PATCH 2/5] dt-bindings: arm: qcom: Document SC8380XP SoC and boards
Date: Fri, 17 Nov 2023 09:37:18 +0530	[thread overview]
Message-ID: <a17d3739-504a-9502-4a2c-3aeddd96c8fa@quicinc.com> (raw)
In-Reply-To: <2cecb51e-9528-471c-8de0-cb716977c0e0@linaro.org>

Hey Krzysztof,

Thanks for taking time to review the series.

On 10/27/23 13:46, Krzysztof Kozlowski wrote:
> On 25/10/2023 16:24, Sibi Sankar wrote:
>> From: Rajendra Nayak <quic_rjendra@quicinc.com>
>>
>> Document the SC8380XP SoC binding and also the boards using it.
>> Also document the new board id qcp (Qualcomm Compute Platform).
>>
>> Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
>> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/arm/qcom.yaml | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 88b84035e7b1..6145e9ad340c 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -62,6 +62,7 @@ description: |
>>           sc7280
>>           sc8180x
>>           sc8280xp
>> +        sc8380xp
>>           sda660
>>           sdm450
>>           sdm630
>> @@ -110,6 +111,7 @@ description: |
>>           liquid
>>           rdp432-c2
>>           mtp
>> +        qcp
>>           qrd
>>           rb2
>>           ride
>> @@ -1044,6 +1046,12 @@ properties:
>>                 - qcom,sm8550-qrd
>>             - const: qcom,sm8550
>>   
>> +      - items:
>> +          - enum:
>> +              - qcom,sc8380xp-crd
>> +              - qcom,sc8380xp-qcp
>> +          - const: qcom,sc8380xp
> 
> This is some odd placement. Please keep things properly ordered.

will fix this in the next re-spin.

-Sibi

> 
> Best regards,
> Krzysztof
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-11-17  4:07 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-25 14:24 [PATCH 0/5] dts: qcom: Introduce SC8380XP platforms device tree Sibi Sankar
2023-10-25 14:24 ` Sibi Sankar
2023-10-25 14:24 ` [PATCH 1/5] dt-bindings: arm: cpus: Add qcom,oryon compatible Sibi Sankar
2023-10-25 14:24   ` Sibi Sankar
2023-10-26 10:23   ` Konrad Dybcio
2023-10-26 10:23     ` Konrad Dybcio
2023-10-25 14:24 ` [PATCH 2/5] dt-bindings: arm: qcom: Document SC8380XP SoC and boards Sibi Sankar
2023-10-25 14:24   ` Sibi Sankar
2023-10-26 10:24   ` Konrad Dybcio
2023-10-26 10:24     ` Konrad Dybcio
2023-11-17  4:05     ` Sibi Sankar
2023-11-17  4:05       ` Sibi Sankar
2023-10-27  8:16   ` Krzysztof Kozlowski
2023-10-27  8:16     ` Krzysztof Kozlowski
2023-11-17  4:07     ` Sibi Sankar [this message]
2023-11-17  4:07       ` Sibi Sankar
2023-10-25 14:24 ` [PATCH 3/5] arm64: dts: qcom: Add base SC8380XP dtsi and the QCP dts Sibi Sankar
2023-10-25 14:24   ` Sibi Sankar
2023-10-26 10:36   ` Konrad Dybcio
2023-10-26 10:36     ` Konrad Dybcio
2023-11-17  4:16     ` Sibi Sankar
2023-11-17  4:16       ` Sibi Sankar
2023-10-26 18:05   ` kernel test robot
2023-10-26 18:05     ` kernel test robot
2023-10-25 14:24 ` [PATCH 4/5] arm64: dts: qcom: sc8380xp: Add Compute Reference Device Sibi Sankar
2023-10-25 14:24   ` Sibi Sankar
2023-10-26 10:38   ` Konrad Dybcio
2023-10-26 10:38     ` Konrad Dybcio
2023-11-17  4:17     ` Sibi Sankar
2023-11-17  4:17       ` Sibi Sankar
2023-10-25 14:24 ` [PATCH 5/5] arm64: defconfig: Enable SC8380XP SoC base configs Sibi Sankar
2023-10-25 14:24   ` Sibi Sankar
2023-10-26 10:55   ` Konrad Dybcio
2023-10-26 10:55     ` Konrad Dybcio
2023-11-17  4:18     ` Sibi Sankar
2023-11-17  4:18       ` Sibi Sankar
2023-10-27  8:18   ` Krzysztof Kozlowski
2023-10-27  8:18     ` Krzysztof Kozlowski
2023-11-17  4:19     ` Sibi Sankar
2023-11-17  4:19       ` Sibi Sankar
2023-10-30 16:00 ` [PATCH 0/5] dts: qcom: Introduce SC8380XP platforms device tree Abel Vesa
2023-10-30 16:00   ` Abel Vesa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a17d3739-504a-9502-4a2c-3aeddd96c8fa@quicinc.com \
    --to=quic_sibis@quicinc.com \
    --cc=abel.vesa@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=ayan.kumar.halder@amd.com \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=j@jannau.net \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=neil.armstrong@linaro.org \
    --cc=nfraprado@collabora.com \
    --cc=peng.fan@nxp.com \
    --cc=quic_rjendra@quicinc.com \
    --cc=quic_tsoni@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=u-kumar1@ti.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.