From: Nicola Vetrini <nicola.vetrini@bugseng.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xenproject.org,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/PV: make mmio_ro_emulated_write() static
Date: Wed, 04 Jun 2025 11:58:20 +0200 [thread overview]
Message-ID: <a1a31f4bc252bd8509e7ad9962adfa0f@bugseng.com> (raw)
In-Reply-To: <aEARj_GYTZrPrXl_@macbook.local>
On 2025-06-04 11:27, Roger Pau Monné wrote:
> On Wed, Jun 04, 2025 at 11:22:00AM +0200, Jan Beulich wrote:
>> It being non-static and it not having a declaration (anymore) violates
>> one or more Misra rules, iirc.
>>
>> Fixes: ff3e5dfa7c2d ("x86/mm: move mmio_ro_emulated_write() to PV only
>> file")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
>
> We are not checking for those rules in Eclair I think? Otherwise this
> won't have passed the CI testing. Or maybe we are just checking
> builds with !CONFIG_PV?
>
> Thanks, Roger.
That seems to be the case on x86. On Arm64 there is no override for
CONFIG_PV [1], but perhaps that is unset by default? I'm not opposed to
having more variants under analysis, but that is not something I can
decide on individually.
Thanks,
Nicola
[1]
https://gitlab.com/xen-project/hardware/xen/-/blob/staging/automation/gitlab-ci/analyze.yaml?ref_type=heads
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
prev parent reply other threads:[~2025-06-04 9:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 9:22 [PATCH] x86/PV: make mmio_ro_emulated_write() static Jan Beulich
2025-06-04 9:27 ` Roger Pau Monné
2025-06-04 9:58 ` Nicola Vetrini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1a31f4bc252bd8509e7ad9962adfa0f@bugseng.com \
--to=nicola.vetrini@bugseng.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.