All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/PV: make mmio_ro_emulated_write() static
Date: Wed, 4 Jun 2025 11:27:43 +0200	[thread overview]
Message-ID: <aEARj_GYTZrPrXl_@macbook.local> (raw)
In-Reply-To: <5dadf381-0f97-4362-93ed-aa5b01d73d88@suse.com>

On Wed, Jun 04, 2025 at 11:22:00AM +0200, Jan Beulich wrote:
> It being non-static and it not having a declaration (anymore) violates
> one or more Misra rules, iirc.
> 
> Fixes: ff3e5dfa7c2d ("x86/mm: move mmio_ro_emulated_write() to PV only file")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

We are not checking for those rules in Eclair I think?  Otherwise this
won't have passed the CI testing.  Or maybe we are just checking
builds with !CONFIG_PV?

Thanks, Roger.


  reply	other threads:[~2025-06-04  9:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-04  9:22 [PATCH] x86/PV: make mmio_ro_emulated_write() static Jan Beulich
2025-06-04  9:27 ` Roger Pau Monné [this message]
2025-06-04  9:58   ` Nicola Vetrini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEARj_GYTZrPrXl_@macbook.local \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.