From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org,
Mikko Perttunen <mperttunen@nvidia.com>
Subject: Re: [PATCH] drm/tegra: vic: Do not clear driver data
Date: Wed, 23 Jan 2019 17:56:15 +0300 [thread overview]
Message-ID: <a213287c-bd58-42e4-e683-87e0a1ce9ae6@gmail.com> (raw)
In-Reply-To: <20190123134234.2625-1-thierry.reding@gmail.com>
23.01.2019 16:42, Thierry Reding пишет:
> From: Thierry Reding <treding@nvidia.com>
>
> Upon driver failure, the driver core will take care of clearing the
> driver data, so there's no need to do so explicitly in the driver.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/gpu/drm/tegra/vic.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tegra/vic.c b/drivers/gpu/drm/tegra/vic.c
> index 9cb10d1e923a..d20fcbf6196d 100644
> --- a/drivers/gpu/drm/tegra/vic.c
> +++ b/drivers/gpu/drm/tegra/vic.c
> @@ -412,7 +412,6 @@ static int vic_probe(struct platform_device *pdev)
> err = host1x_client_register(&vic->client.base);
> if (err < 0) {
> dev_err(dev, "failed to register host1x client: %d\n", err);
> - platform_set_drvdata(pdev, NULL);
> goto exit_falcon;
> }
>
>
Looks good,
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-01-23 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 13:42 [PATCH] drm/tegra: vic: Do not clear driver data Thierry Reding
2019-01-23 14:56 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a213287c-bd58-42e4-e683-87e0a1ce9ae6@gmail.com \
--to=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.