* [PATCH] drm/tegra: vic: Do not clear driver data
@ 2019-01-23 13:42 Thierry Reding
2019-01-23 14:56 ` Dmitry Osipenko
0 siblings, 1 reply; 2+ messages in thread
From: Thierry Reding @ 2019-01-23 13:42 UTC (permalink / raw)
To: Thierry Reding; +Cc: linux-tegra, Dmitry Osipenko, dri-devel, Mikko Perttunen
From: Thierry Reding <treding@nvidia.com>
Upon driver failure, the driver core will take care of clearing the
driver data, so there's no need to do so explicitly in the driver.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/gpu/drm/tegra/vic.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/vic.c b/drivers/gpu/drm/tegra/vic.c
index 9cb10d1e923a..d20fcbf6196d 100644
--- a/drivers/gpu/drm/tegra/vic.c
+++ b/drivers/gpu/drm/tegra/vic.c
@@ -412,7 +412,6 @@ static int vic_probe(struct platform_device *pdev)
err = host1x_client_register(&vic->client.base);
if (err < 0) {
dev_err(dev, "failed to register host1x client: %d\n", err);
- platform_set_drvdata(pdev, NULL);
goto exit_falcon;
}
--
2.19.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/tegra: vic: Do not clear driver data
2019-01-23 13:42 [PATCH] drm/tegra: vic: Do not clear driver data Thierry Reding
@ 2019-01-23 14:56 ` Dmitry Osipenko
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Osipenko @ 2019-01-23 14:56 UTC (permalink / raw)
To: Thierry Reding; +Cc: linux-tegra, dri-devel, Mikko Perttunen
23.01.2019 16:42, Thierry Reding пишет:
> From: Thierry Reding <treding@nvidia.com>
>
> Upon driver failure, the driver core will take care of clearing the
> driver data, so there's no need to do so explicitly in the driver.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/gpu/drm/tegra/vic.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tegra/vic.c b/drivers/gpu/drm/tegra/vic.c
> index 9cb10d1e923a..d20fcbf6196d 100644
> --- a/drivers/gpu/drm/tegra/vic.c
> +++ b/drivers/gpu/drm/tegra/vic.c
> @@ -412,7 +412,6 @@ static int vic_probe(struct platform_device *pdev)
> err = host1x_client_register(&vic->client.base);
> if (err < 0) {
> dev_err(dev, "failed to register host1x client: %d\n", err);
> - platform_set_drvdata(pdev, NULL);
> goto exit_falcon;
> }
>
>
Looks good,
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-23 14:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-23 13:42 [PATCH] drm/tegra: vic: Do not clear driver data Thierry Reding
2019-01-23 14:56 ` Dmitry Osipenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.