All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bod@kernel.org>
To: Abel Vesa <abel.vesa@oss.qualcomm.com>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver
Date: Mon, 6 Apr 2026 16:37:37 +0100	[thread overview]
Message-ID: <a310c4bc-0ebe-4caf-b784-e438c9460487@kernel.org> (raw)
In-Reply-To: <qrzaihfpujlhqeukp7wioqrqjbpih65smmieliixavzlev6las@odmnpbuc3wrm>

On 06/04/2026 15:28, Abel Vesa wrote:
>> +
>> +	for (i = 0; i < num_pds; i++) {
>> +		csi2phy->pds[i] = dev_pm_domain_attach_by_name(dev,
>> +							       csi2phy->soc_cfg->genpd_names[i]);
> You need to do detach these on error, otherwise you get:
> 
>   sysfs: cannot create duplicate filename '/devices/genpd:0:acec000.phy'
>   CPU: 1 UID: 0 PID: 93 Comm: kworker/u49:2 Not tainted 7.0.0-rc6-00062-gd691cf9ea708 #12 PREEMPT
>   Hardware name: Dell Inc. XPS 13 9345/05H2K4, BIOS 2.11.0 09/21/2025
>   Workqueue: events_unbound deferred_probe_work_func

Yeah I noticed that myself, thanks for posting.

---
bod

WARNING: multiple messages have this Message-ID (diff)
From: Bryan O'Donoghue <bod@kernel.org>
To: Abel Vesa <abel.vesa@oss.qualcomm.com>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver
Date: Mon, 6 Apr 2026 16:37:37 +0100	[thread overview]
Message-ID: <a310c4bc-0ebe-4caf-b784-e438c9460487@kernel.org> (raw)
In-Reply-To: <qrzaihfpujlhqeukp7wioqrqjbpih65smmieliixavzlev6las@odmnpbuc3wrm>

On 06/04/2026 15:28, Abel Vesa wrote:
>> +
>> +	for (i = 0; i < num_pds; i++) {
>> +		csi2phy->pds[i] = dev_pm_domain_attach_by_name(dev,
>> +							       csi2phy->soc_cfg->genpd_names[i]);
> You need to do detach these on error, otherwise you get:
> 
>   sysfs: cannot create duplicate filename '/devices/genpd:0:acec000.phy'
>   CPU: 1 UID: 0 PID: 93 Comm: kworker/u49:2 Not tainted 7.0.0-rc6-00062-gd691cf9ea708 #12 PREEMPT
>   Hardware name: Dell Inc. XPS 13 9345/05H2K4, BIOS 2.11.0 09/21/2025
>   Workqueue: events_unbound deferred_probe_work_func

Yeah I noticed that myself, thanks for posting.

---
bod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2026-04-06 15:37 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26  1:04 [PATCH v5 0/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver Bryan O'Donoghue
2026-03-26  1:04 ` Bryan O'Donoghue
2026-03-26  1:04 ` [PATCH v5 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema Bryan O'Donoghue
2026-03-26  1:04   ` Bryan O'Donoghue
2026-03-26  1:46   ` Vladimir Zapolskiy
2026-03-26  1:46     ` Vladimir Zapolskiy
2026-03-26  2:03     ` Bryan O'Donoghue
2026-03-26  2:03       ` Bryan O'Donoghue
2026-03-26 10:28       ` Vladimir Zapolskiy
2026-03-26 10:28         ` Vladimir Zapolskiy
2026-03-26 14:42         ` Bryan O'Donoghue
2026-03-26 14:42           ` Bryan O'Donoghue
2026-03-26 14:49           ` Vladimir Zapolskiy
2026-03-26 14:49             ` Vladimir Zapolskiy
2026-03-27  1:03             ` Bryan O'Donoghue
2026-03-27  1:03               ` Bryan O'Donoghue
2026-03-27  7:54               ` Vladimir Zapolskiy
2026-03-27  7:54                 ` Vladimir Zapolskiy
2026-03-27 20:51           ` Dmitry Baryshkov
2026-03-27 20:51             ` Dmitry Baryshkov
2026-03-27 22:29             ` Bryan O'Donoghue
2026-03-27 22:29               ` Bryan O'Donoghue
2026-03-27 23:12               ` Vladimir Zapolskiy
2026-03-27 23:12                 ` Vladimir Zapolskiy
2026-03-27 23:23                 ` Dmitry Baryshkov
2026-03-27 23:23                   ` Dmitry Baryshkov
2026-03-27 23:40                   ` Bryan O'Donoghue
2026-03-27 23:40                     ` Bryan O'Donoghue
2026-03-29 10:54                     ` Dmitry Baryshkov
2026-03-29 10:54                       ` Dmitry Baryshkov
2026-03-30  9:46                       ` Konrad Dybcio
2026-03-30  9:46                         ` Konrad Dybcio
2026-03-28  0:41                   ` Vladimir Zapolskiy
2026-03-28  0:41                     ` Vladimir Zapolskiy
2026-03-26  2:31   ` Rob Herring (Arm)
2026-03-26  2:31     ` Rob Herring (Arm)
2026-03-27 10:07   ` Konrad Dybcio
2026-03-27 10:07     ` Konrad Dybcio
2026-03-27 10:10     ` Konrad Dybcio
2026-03-27 10:10       ` Konrad Dybcio
2026-03-27 14:38     ` Bryan O'Donoghue
2026-03-27 14:38       ` Bryan O'Donoghue
2026-03-27 15:28       ` Neil Armstrong
2026-03-27 15:28         ` Neil Armstrong
2026-03-27 17:42         ` Bryan O'Donoghue
2026-03-27 17:42           ` Bryan O'Donoghue
2026-03-30  7:49           ` Neil Armstrong
2026-03-30  7:49             ` Neil Armstrong
2026-03-30  9:02             ` Bryan O'Donoghue
2026-03-30  9:02               ` Bryan O'Donoghue
2026-03-30  9:17               ` Neil Armstrong
2026-03-30  9:17                 ` Neil Armstrong
2026-03-30  9:25                 ` Bryan O'Donoghue
2026-03-30  9:25                   ` Bryan O'Donoghue
2026-03-30 11:34                   ` Konrad Dybcio
2026-03-30 11:34                     ` Konrad Dybcio
2026-03-30 11:41                     ` Bryan O'Donoghue
2026-03-30 11:41                       ` Bryan O'Donoghue
2026-04-15  9:41                       ` Konrad Dybcio
2026-04-15  9:41                         ` Konrad Dybcio
2026-03-30 11:49                     ` Dmitry Baryshkov
2026-03-30 11:49                       ` Dmitry Baryshkov
2026-03-30 12:03                       ` Bryan O'Donoghue
2026-03-30 12:03                         ` Bryan O'Donoghue
2026-03-30 10:39               ` Vladimir Zapolskiy
2026-03-30 10:39                 ` Vladimir Zapolskiy
2026-03-26  1:04 ` [PATCH v5 2/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver Bryan O'Donoghue
2026-03-26  1:04   ` Bryan O'Donoghue
2026-03-27  2:23   ` Hangxiang Ma
2026-03-27  2:23     ` Hangxiang Ma
2026-03-27 10:07     ` Konrad Dybcio
2026-03-27 10:07       ` Konrad Dybcio
2026-03-27 20:57       ` Dmitry Baryshkov
2026-03-27 20:57         ` Dmitry Baryshkov
2026-03-27 20:54   ` Dmitry Baryshkov
2026-03-27 20:54     ` Dmitry Baryshkov
2026-03-27 22:11     ` Bryan O'Donoghue
2026-03-27 22:11       ` Bryan O'Donoghue
2026-03-27 22:30       ` Dmitry Baryshkov
2026-03-27 22:30         ` Dmitry Baryshkov
2026-04-02  2:22   ` Vijay Kumar Tumati
2026-04-02  2:22     ` Vijay Kumar Tumati
2026-04-06 14:28   ` Abel Vesa
2026-04-06 14:28     ` Abel Vesa
2026-04-06 15:37     ` Bryan O'Donoghue [this message]
2026-04-06 15:37       ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a310c4bc-0ebe-4caf-b784-e438c9460487@kernel.org \
    --to=bod@kernel.org \
    --cc=abel.vesa@oss.qualcomm.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.